Shreyaskr1409 commented on code in PR #15504:
URL: https://github.com/apache/datafusion/pull/15504#discussion_r2021132605


##########
datafusion/physical-expr/src/aggregate.rs:
##########
@@ -97,6 +97,167 @@ impl AggregateExprBuilder {
     /// Constructs an `AggregateFunctionExpr` from the builder
     ///
     /// Note that an [`Self::alias`] must be provided before calling this 
method.
+    ///
+    /// # Example: Create an `AggregateUDF`
+    ///
+    /// In the following example, `AggregateFunctionExpr` will be built using 
`AggregateExprBuilder`
+    /// which provides a build function.
+    ///
+    /// First we will create an `Accumulator` which will be used to further 
implement `AggregateUDFImpl`.
+    /// After implementing `AggregateUDFImpl`, it could be used to pass in as 
a parameter to create an `AggregateExprBuilder`.
+    /// `AggregateExprBuilder` could the be used to generate 
`AggregateFunctionExpr` after chaining
+    /// queries on top of each other.
+    ///
+    /// ```

Review Comment:
   this specific part is tested



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to