alamb merged PR #14887:
URL: https://github.com/apache/datafusion/pull/14887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #14887:
URL: https://github.com/apache/datafusion/pull/14887#issuecomment-2685448073
Since this is a minor additive API I am just going to merge it in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
alamb commented on PR #14887:
URL: https://github.com/apache/datafusion/pull/14887#issuecomment-2685448270
Thanks again @kosiew
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
alamb commented on PR #14885:
URL: https://github.com/apache/datafusion/pull/14885#issuecomment-2685446386
Thanks for understanding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
diegoreis42 closed pull request #14885: Implement builder style API for
ParserOptions
URL: https://github.com/apache/datafusion/pull/14885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
diegoreis42 commented on PR #14885:
URL: https://github.com/apache/datafusion/pull/14885#issuecomment-2684816983
No problem at all, although I opened first, the other seems richer. I'll try
to do best in another issue for my first contribution.
--
This is an automated message from the Apa
alamb commented on PR #14885:
URL: https://github.com/apache/datafusion/pull/14885#issuecomment-2684779813
Thank you for the contribution @diegoreis42 -- it seems there is another PR
with the same feature here:
- https://github.com/apache/datafusion/pull/14887
--
This is an automated
kosiew commented on code in PR #14887:
URL: https://github.com/apache/datafusion/pull/14887#discussion_r1970909759
##
datafusion/sql/src/planner.rs:
##
@@ -43,15 +43,30 @@ pub use datafusion_expr::planner::ContextProvider;
/// SQL parser options
#[derive(Debug, Clone, Copy)]
kosiew opened a new pull request, #14887:
URL: https://github.com/apache/datafusion/pull/14887
## Which issue does this PR close?
- Closes #14879.
## Rationale for this change
Currently, adding new fields to ParserOptions requires a downstream API
change,
diegoreis42 opened a new pull request, #14885:
URL: https://github.com/apache/datafusion/pull/14885
## Which issue does this PR close?
- Closes #14879
## Rationale for this change
## What changes are included in this PR?
## Are these change
10 matches
Mail list logo
