kosiew opened a new pull request, #14887:
URL: https://github.com/apache/datafusion/pull/14887
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #14879.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Currently, adding new fields to ParserOptions requires a downstream API
change, making it less flexible and introducing breaking changes. Implementing
a builder pattern will allow adding new fields without modifying the struct's
initialization directly, improving API stability and usability.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Introduced a builder-style API for ParserOptions.
- Replaced direct struct instantiation with method chaining, e.g.,
ParserOptions::new().with_parse_float_as_decimal(...).
- Added documentation and doc tests to demonstrate usage.
- Ensured all existing functionality remains intact.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes, tests have been added to validate the new builder API. Existing tests
for ParserOptions remain unchanged to ensure backward compatibility.
## Are there any user-facing changes?
Yes, this PR introduces a new way to construct ParserOptions, but it does
not break existing usage. Developers can still use the struct as before, but
they now have a more flexible alternative with the builder pattern.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
