alamb commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2711632709
Related:
- https://github.com/apache/datafusion/issues/13814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
alamb commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2659408025
BTW potentially related ticket for binary size:
- https://github.com/apache/datafusion/issues/13816
--
This is an automated message from the Apache Git Service.
To respond to
waynexia commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2639241508
Thanks for those updates!
I was trying to replace type parameters (`F` for `Fn`) inside `TreeNode`
with `Box` this holiday. Let's see if it works. (it should reduce some
crepererum commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2624035825
I have another hunch, but still need to proof it: DataFusion uses a lot of
```rust
fn f(param: impl Into, ...) -> ... {
let param: Type = param.into();
alamb commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2622937724
> Let me see if I can find ways to make Expr smaller though
I can make Expr less than half the size in this PR:
- https://github.com/apache/datafusion/pull/14366
I
alamb commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2622826545
> > After removing the WildcardOptions (by replacing it with an empty
structure) I can see the build time drops. Removing the rule itself and the
change in core doesn't help. It l
alamb commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2622793735
> After removing the WildcardOptions (by replacing it with an empty
structure) I can see the build time drops. Removing the rule itself and the
change in core doesn't help. It loo
alamb commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2622793969
Thanks to some great work from @buraksenn @berkaysynnada and @logan-keede
we have completed extracting physical optimizer rules:
- https://github.com/apache/datafusion/issues/1
waynexia commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2614436290
After removing the `WildcardOptions` (by replacing it with an empty
structure) I can see the build time drops. Removing the rule itself and the
change in `core` doesn't help. I
alamb commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2614323152
> I located the biggest jump happens on
[#11681](https://github.com/apache/datafusion/pull/11681), commit
[3438b35](https://github.com/apache/datafusion/commit/3438b355308afa23dba
waynexia commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2614019259
I located the biggest jump happens on
https://github.com/apache/datafusion/pull/11681/, commit 3438b355. But I can't
tell the reason. I go through it and it's just a normal log
waynexia commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2613967071
Looking forward to the ongoing refactors!
>Also, can you make sure there is no bias in the measurement? If you build
in reverse order and run cargo clean between each ste
alamb commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2613925243
100% making build time better would be really appreciated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
alamb commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2613493318
> After `physical-optimizer`, `datasource` could be a potential target to
move out of core.
Yes, 100% splitting out datasource is my next thing I would love to see (and
I t
findepi commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-261107
> datasource could be a potential target to move out of core.
related
- https://github.com/apache/datafusion/issues/10782
> The build time keeps incre
jayzhan211 commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2611451332
After `physical-optimizer`, `datasource` could be a potential target to move
out of core.
--
This is an automated message from the Apache Git Service.
To respond to the mes
waynexia commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2611429425
A few more details:
The build command I use is `cargo build --release --timings --lib --quiet`
The latest timing file is (rename it to HTML, restriction from GitHub
waynexia opened a new issue, #14256:
URL: https://github.com/apache/datafusion/issues/14256
### Is your feature request related to a problem or challenge?
We observed a huge increase after upgrading datafusion
https://github.com/GreptimeTeam/greptimedb/pull/5417. I run a script to tes
18 matches
Mail list logo
