waynexia commented on issue #14256: URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2614436290
After removing the `WildcardOptions` (by replacing it with an empty structure) I can see the build time drops. Removing the rule itself and the change in `core` doesn't help. It looks like the change to `Expr` is the root cause, though I don't know the reason... One guess is that both `Expr` and `LogicalPlan` are key enums used in many places, especially many type parameters (like the `TreeNode`). Thus a slight change to them will be amplified by a lot. I have some thoughts on this specific case, like putting the expansion somewhere else, or changing some Fn type parameters to trait objects. But I can't tell how good it will be, and the balance between runtime overhead and build time consumption. Or we can wait for those refactors until we figure out why `WildcardOptions` causes that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
