alamb commented on issue #13652:
URL: https://github.com/apache/datafusion/issues/13652#issuecomment-2640130621
Task complete!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
alamb closed issue #13652: Automatically check "invariants"
URL: https://github.com/apache/datafusion/issues/13652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
wiedld commented on issue #13652:
URL: https://github.com/apache/datafusion/issues/13652#issuecomment-2573659546
> I suggest we use this ticket to track the infrastructure for checking
invariants
Agreed. Modifying [this list
above](https://github.com/apache/datafusion/issues/13652#is
alamb commented on issue #13652:
URL: https://github.com/apache/datafusion/issues/13652#issuecomment-2573635690
I suggest we use this ticket to track the infrastructure for checking
invariants (e.g. what @wiedld is doing in
https://github.com/apache/datafusion/pull/13986) and then claim suc
alamb commented on issue #13652:
URL: https://github.com/apache/datafusion/issues/13652#issuecomment-2572966102
I just discovered that @houqp basically filed this same ticket 2 years ago:
- https://github.com/apache/datafusion/issues/594
--
This is an automated message from the
alamb commented on issue #13652:
URL: https://github.com/apache/datafusion/issues/13652#issuecomment-2564362086
> My impression was that the plan construction occurred with the LP (as we
do), and not by constructing their own de novo physical plan. Is this correct?
I am sorry -- I don
wiedld commented on issue #13652:
URL: https://github.com/apache/datafusion/issues/13652#issuecomment-2563932418
My impression was that the plan construction occurred with the LP (as we
do), and not by constructing their own de novo physical plan. Is this correct?
If so, then I think
alamb commented on issue #13652:
URL: https://github.com/apache/datafusion/issues/13652#issuecomment-2563115493
> For the [physical
optimization](https://docs.rs/datafusion/43.0.0/datafusion/physical_optimizer/trait.PhysicalOptimizerRule.html)
invariants, we have that the [output physical p
wiedld commented on issue #13652:
URL: https://github.com/apache/datafusion/issues/13652#issuecomment-2563033771
For the [physical
optimization](https://docs.rs/datafusion/43.0.0/datafusion/physical_optimizer/trait.PhysicalOptimizerRule.html)
invariants, we have that the [output physical pl
wiedld commented on issue #13652:
URL: https://github.com/apache/datafusion/issues/13652#issuecomment-2550443777
### Possible tasks
- [x] Define when to check LP invariant. PR:
https://github.com/apache/datafusion/pull/13651
- [ ] Define when to check physical plan invariants.
-
wiedld commented on issue #13652:
URL: https://github.com/apache/datafusion/issues/13652#issuecomment-2520636646
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
alamb opened a new issue, #13652:
URL: https://github.com/apache/datafusion/issues/13652
### Is your feature request related to a problem or challenge?
- Part of https://github.com/apache/datafusion/issues/13648
- Inspired by / copyed from https://github.com/apache/datafusion/pull/1
12 matches
Mail list logo
