alamb commented on issue #13652: URL: https://github.com/apache/datafusion/issues/13652#issuecomment-2564362086
> My impression was that the plan construction occurred with the LP (as we do), and not by constructing their own de novo physical plan. Is this correct? I am sorry -- I don't understand what you are asking (is LP LogicalPlan?) What does a de novo physical plan mean? You mean like creating a `ExecutionPlan` directly (not from a `LogicalPlan`)? > > If so, then I think the [above list of invariants](https://github.com/apache/datafusion/issues/13652#issuecomment-2563115493) to check would most likely occur at the LP-level (not the physical plan). I can definitely put up a PR for those. Thank you! > > Whereas for the physical plan invariants, (not LP), do we want any invariant checking there? Because I looked at the apache docs & physical plan APIs and from (my naive) understanding [these are the only two invariants](https://github.com/apache/datafusion/issues/13652#issuecomment-2563033771) to check after physical plan mutations (a.k.a. PhysicalOptimizerRule applied). Is this correct? 🤔 I am not sure what the actual invariants are (part of this project I think is to discover that information) In my opinion we should be seeking to discover what the existing implicit assumptions are and encode them explicitly in the invariant check. Once we have all the existing assumptions encoded then we can move on to trying to add more assumptions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
