gabotechs commented on issue #15069:
URL: https://github.com/apache/datafusion/issues/15069#issuecomment-2893161350
That sounds reasonable, although given the current state there's a lot of
ignoring to be done in the Substrait validation mode, some numbers here:
currently out of 7302 `query
nirnayroy commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-2893026630
fixed formatting error in workflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
LucaCappelletti94 commented on code in PR #1826:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1826#discussion_r2096954711
##
tests/sqlparser_postgres.rs:
##
@@ -4098,6 +4099,219 @@ fn parse_update_in_with_subquery() {
pg_and_generic().verified_stmt(r#"WITH "
iffyio commented on code in PR #1852:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1852#discussion_r2096922347
##
src/parser/mod.rs:
##
@@ -16571,6 +16575,23 @@ mod tests {
}
}
+#[test]
+fn test_mysql_srid_create_table() {
+let sql
iffyio commented on code in PR #1826:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1826#discussion_r2096911544
##
src/parser/mod.rs:
##
@@ -5200,12 +5200,26 @@ impl<'a> Parser<'a> {
// parse: [ argname ] argtype
let mut name = None;
let
tlm365 commented on code in PR #16087:
URL: https://github.com/apache/datafusion/pull/16087#discussion_r2096902385
##
datafusion/functions/benches/ascii.rs:
##
@@ -0,0 +1,116 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
iffyio commented on code in PR #1839:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1839#discussion_r2096898613
##
src/parser/mod.rs:
##
@@ -5204,19 +5204,79 @@ impl<'a> Parser<'a> {
let (name, args) = self.parse_create_function_name_and_params()?;
duongcongtoai commented on issue #5492:
URL: https://github.com/apache/datafusion/issues/5492#issuecomment-2892904604
In this case, we may need at least 2 new optimizor passes 🤔
`SubqueryDecorrelation` and `DelimGetRemoval`.
and looks like this [PR](https://github.com/apache/datafusion/pu
iffyio merged PR #1857:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
duongcongtoai commented on issue #5492:
URL: https://github.com/apache/datafusion/issues/5492#issuecomment-2892878744
Thank you everyone for your opinions. Looks like my implementation is trying
to wrap everything inside a single optimizor, which is hard to follow and
reduces space for coll
comphead commented on PR #16062:
URL: https://github.com/apache/datafusion/pull/16062#issuecomment-2892876543
Finally there is a green build. Please do not merge it until I fix ignored
tests which will be in a separate PR
--
This is an automated message from the Apache Git Service.
To res
iffyio commented on PR #1855:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1855#issuecomment-2892870653
@lovasoa when you get the time could you merge in latest from main to fix up
the ci failure in this and the #1854 PRs?
--
This is an automated message from the Apache Gi
zhuqi-lucas commented on PR #15380:
URL: https://github.com/apache/datafusion/pull/15380#issuecomment-2892754141
> 🤖: Benchmark completed
>
> Details
>
> ```
> Comparing HEAD and concat_batches_for_sort
>
> Benchmark clickbench_extended.json
> --
zhuqi-lucas commented on code in PR #15380:
URL: https://github.com/apache/datafusion/pull/15380#discussion_r2096766180
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -674,16 +676,35 @@ impl ExternalSorter {
return self.sort_batch_stream(batch, metrics, reserv
github-actions[bot] commented on PR #15306:
URL: https://github.com/apache/datafusion/pull/15306#issuecomment-2892705292
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
github-actions[bot] commented on PR #15018:
URL: https://github.com/apache/datafusion/pull/15018#issuecomment-2892705347
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
ahirner closed issue #10764: Error `NamedStructField should be rewritten in
OperatorToFunction with subquery` if query is wrapped in view
URL: https://github.com/apache/datafusion/issues/10764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
ianmcook commented on issue #10987:
URL: https://github.com/apache/datafusion/issues/10987#issuecomment-2892638977
There's a discussion happening on the Arrow dev mailing list about adding
Variant as a canonical extension type in the Arrow spec. Input from the
DataFusion developer community
codecov-commenter commented on PR #1755:
URL:
https://github.com/apache/datafusion-comet/pull/1755#issuecomment-2892635123
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1755?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
chenkovsky commented on code in PR #16097:
URL: https://github.com/apache/datafusion/pull/16097#discussion_r2096658640
##
datafusion/core/src/physical_planner.rs:
##
@@ -1757,6 +1757,12 @@ impl DefaultPhysicalPlanner {
)));
}
+if !e.logical_optimi
comphead merged PR #16085:
URL: https://github.com/apache/datafusion/pull/16085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
parthchandra commented on PR #1755:
URL:
https://github.com/apache/datafusion-comet/pull/1755#issuecomment-2892542148
@mbutrovich @andygrove Spark test fixes for native_iceberg_compat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
parthchandra opened a new pull request, #1755:
URL: https://github.com/apache/datafusion-comet/pull/1755
## Which issue does this PR close?
Part of https://github.com/apache/datafusion-comet/issues/1542
Closes #.
## Rationale for this change
This addresses test fai
irenjj commented on issue #5492:
URL: https://github.com/apache/datafusion/issues/5492#issuecomment-2892527051
> There are one thing we surely know that should be implemented: detect
which nodes in the LogicalPlan AST is a dependent join node. However, we don't
need to create a new LogicalP
codecov-commenter commented on PR #1753:
URL:
https://github.com/apache/datafusion-comet/pull/1753#issuecomment-2892394556
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1753?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
andygrove commented on PR #16058:
URL: https://github.com/apache/datafusion/pull/16058#issuecomment-2892388867
@alamb I'd like to go ahead and merge this one if there are no objections
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
andygrove commented on issue #1754:
URL:
https://github.com/apache/datafusion-comet/issues/1754#issuecomment-2892387185
Thanks @comphead!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
nirnayroy commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-289230
fixed the cippy errors showing up in the workflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
comphead commented on issue #1754:
URL:
https://github.com/apache/datafusion-comet/issues/1754#issuecomment-2892335517
you wanna me to take this @andygrove ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
etseidl commented on PR #15816:
URL: https://github.com/apache/datafusion/pull/15816#issuecomment-2892365766
Thanks @alamb!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
comphead commented on issue #1754:
URL:
https://github.com/apache/datafusion-comet/issues/1754#issuecomment-2892357390
the similar issue also for the map_values, hopefully the fix can fix both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
andygrove commented on issue #1754:
URL:
https://github.com/apache/datafusion-comet/issues/1754#issuecomment-2892277712
I am guessing that we need to implement logic for casting between maps,
similar to what @comphead did for lists in
https://github.com/apache/datafusion-comet/pull/1687
adriangb commented on code in PR #16086:
URL: https://github.com/apache/datafusion/pull/16086#discussion_r2095856518
##
datafusion/core/src/datasource/physical_plan/parquet.rs:
##
@@ -156,10 +162,20 @@ mod tests {
source = source
.with_pushd
andygrove opened a new issue, #1754:
URL: https://github.com/apache/datafusion-comet/issues/1754
### Describe the bug
Repro:
```
ignore("read map[struct, struct] from parquet") {
assume(usingDataSourceExec(conf))
withTempPath { dir =>
// create in
theirix commented on issue #13563:
URL: https://github.com/apache/datafusion/issues/13563#issuecomment-2892193833
Sorry for the long absence. After datafusion-sqlparser-rs gained SQL support
for tablesamples in
[0.54](https://github.com/apache/datafusion-sqlparser-rs/pull/1566), I am going
aharpervc commented on PR #1839:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1839#issuecomment-2892157468
It seems the CI failure for the lint job was addressed by
https://github.com/apache/datafusion-sqlparser-rs/pull/1856. I've rebased
again, all good 👍
--
This is an
andygrove opened a new pull request, #1753:
URL: https://github.com/apache/datafusion-comet/pull/1753
## Which issue does this PR close?
N/A
## Rationale for this change
Enable some complex tests that were previously ignored
## What changes are incl
timsaucer closed issue #15902: Add metadata support for Aggregate and Window
Functions
URL: https://github.com/apache/datafusion/issues/15902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
timsaucer merged PR #15911:
URL: https://github.com/apache/datafusion/pull/15911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
Dandandan commented on code in PR #15380:
URL: https://github.com/apache/datafusion/pull/15380#discussion_r2096369131
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -674,16 +676,35 @@ impl ExternalSorter {
return self.sort_batch_stream(batch, metrics, reservat
alamb commented on code in PR #16087:
URL: https://github.com/apache/datafusion/pull/16087#discussion_r2096357959
##
datafusion/functions/src/string/ascii.rs:
##
@@ -103,19 +103,22 @@ impl ScalarUDFImpl for AsciiFunc {
fn calculate_ascii<'a, V>(array: V) -> Result
where
-
alamb commented on PR #15748:
URL: https://github.com/apache/datafusion/pull/15748#issuecomment-2892029694
🤖: Benchmark completed
Details
```
Comparing HEAD and avg_duration_ga
Benchmark clickbench_extended.json
┏━
mbutrovich commented on issue #1750:
URL:
https://github.com/apache/datafusion-comet/issues/1750#issuecomment-2892026436
Taking a look at this today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
coderfender commented on PR #1752:
URL:
https://github.com/apache/datafusion-comet/pull/1752#issuecomment-2892016663
Thank you for the approval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
adriangb commented on PR #16080:
URL: https://github.com/apache/datafusion/pull/16080#issuecomment-2891982600
Will try to fix tests later today but may be tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
alamb commented on PR #15748:
URL: https://github.com/apache/datafusion/pull/15748#issuecomment-2891939602
🤖 `./gh_compare_branch.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh)
Running
Linux aal-dev 6.11.0-1013-gcp #13~24.04.1-Ubun
alamb commented on PR #15380:
URL: https://github.com/apache/datafusion/pull/15380#issuecomment-2891939456
🤖: Benchmark completed
Details
```
Comparing HEAD and concat_batches_for_sort
Benchmark clickbench_extended.json
--
leoyvens commented on code in PR #16100:
URL: https://github.com/apache/datafusion/pull/16100#discussion_r2096272547
##
datafusion/common/src/config.rs:
##
@@ -292,7 +292,9 @@ config_namespace! {
/// target batch size is determined by the configuration setting
duongcongtoai commented on issue #5492:
URL: https://github.com/apache/datafusion/issues/5492#issuecomment-2891917519
There are one thing we surely know that should be implemented: detect which
nodes in the LogicalPlan AST is a dependent join node. However, we don't need
to create a new Log
alamb commented on issue #16084:
URL: https://github.com/apache/datafusion/issues/16084#issuecomment-2891905096
@Adez017 -- thank you -- maybe you can help review the post. I think we
need to do more of the work before writing a post about it so this probably
can't start for another few we
comphead commented on PR #16072:
URL: https://github.com/apache/datafusion/pull/16072#issuecomment-2891899456
Thanks @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
alamb commented on PR #15748:
URL: https://github.com/apache/datafusion/pull/15748#issuecomment-2891868596
@logan-keede just finished up a benchmark for this PR here;
- https://github.com/apache/datafusion/pull/16105
I will merge this PR up from main and run the benchmarks on it to
alamb merged PR #16105:
URL: https://github.com/apache/datafusion/pull/16105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed issue #15949: Add Extended Clickbench benchmark for avg(duration)
URL: https://github.com/apache/datafusion/issues/15949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
alamb commented on PR #16105:
URL: https://github.com/apache/datafusion/pull/16105#issuecomment-2891864844
```shell
./bench.sh run clickbench_extended
...
Q8: SELECT "RegionID", "UserAgent", "OS",
AVG(to_timestamp("ResponseEndTiming")-to_timestamp("ResponseStartTiming")) as
avg_res
alamb merged PR #16068:
URL: https://github.com/apache/datafusion/pull/16068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed issue #16061: Update workspace / CI to Rust 1.87
URL: https://github.com/apache/datafusion/issues/16061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
alamb closed issue #9846: [Epic] Remove Sort Merge Join Experimental status
URL: https://github.com/apache/datafusion/issues/9846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
alamb merged PR #16072:
URL: https://github.com/apache/datafusion/pull/16072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
andygrove commented on code in PR #1752:
URL: https://github.com/apache/datafusion-comet/pull/1752#discussion_r2096248604
##
docs/source/contributor-guide/spark-sql-tests.md:
##
@@ -65,6 +65,15 @@ ENABLE_COMET=true build/sbt "hive/testOnly * -- -l
org.apache.spark.tags.Extende
alamb merged PR #16031:
URL: https://github.com/apache/datafusion/pull/16031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed issue #16030: Stack overflow for substrait functions with large
argument lists that translate to DataFusion binary operators
URL: https://github.com/apache/datafusion/issues/16030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
alamb commented on PR #16031:
URL: https://github.com/apache/datafusion/pull/16031#issuecomment-2891850119
Thanks again everyone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
alamb commented on PR #15816:
URL: https://github.com/apache/datafusion/pull/15816#issuecomment-2891848455
I took the liberty of adding some basic slt tests as well to get this PR
moving and ready for merge
--
This is an automated message from the Apache Git Service.
To respond to the mes
alamb commented on PR #15380:
URL: https://github.com/apache/datafusion/pull/15380#issuecomment-2891843039
🤖 `./gh_compare_branch.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh)
Running
Linux aal-dev 6.11.0-1013-gcp #13~24.04.1-Ubun
alamb commented on PR #15380:
URL: https://github.com/apache/datafusion/pull/15380#issuecomment-2891842936
🤖: Benchmark completed
Details
```
Comparing HEAD and concat_batches_for_sort
Benchmark sort_tpch.json
┏━━━
alamb commented on PR #16105:
URL: https://github.com/apache/datafusion/pull/16105#issuecomment-2891815932
I am just running this quickly locally and then I'll merge it in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
alamb commented on PR #15380:
URL: https://github.com/apache/datafusion/pull/15380#issuecomment-2891815391
🤖 `./gh_compare_branch.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh)
Running
Linux aal-dev 6.11.0-1013-gcp #13~24.04.1-Ubun
alamb commented on code in PR #16105:
URL: https://github.com/apache/datafusion/pull/16105#discussion_r2096222012
##
benchmarks/queries/clickbench/README.md:
##
@@ -192,10 +193,46 @@ Results look like
+-+--+--+--+
```
+### Q8: Average Late
coderfender commented on PR #1752:
URL:
https://github.com/apache/datafusion-comet/pull/1752#issuecomment-2891795103
@andygrove . Please take a look whenever you get a chance. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
milenkovicm opened a new pull request, #1266:
URL: https://github.com/apache/datafusion-ballista/pull/1266
# Which issue does this PR close?
Closes #.
# Rationale for this change
In some cases stage plan should not be cached, as task plan may change, as
there is no easy
alamb closed issue #15934: Add imdb 10 rows slt test
URL: https://github.com/apache/datafusion/issues/15934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
alamb commented on PR #16067:
URL: https://github.com/apache/datafusion/pull/16067#issuecomment-2891785070
I merged up and ran this locally and everything looks good still
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
alamb merged PR #16067:
URL: https://github.com/apache/datafusion/pull/16067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
coderfender opened a new pull request, #1752:
URL: https://github.com/apache/datafusion-comet/pull/1752
## Which issue does this PR close?
Closes #1751
## Rationale for this change
Doc changes to help users run needed unit tests
## What changes are include
alamb commented on PR #16067:
URL: https://github.com/apache/datafusion/pull/16067#issuecomment-2891784584
🚀
Thank you @kumarlokesh and @jayzhan211 for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
coderfender opened a new issue, #1751:
URL: https://github.com/apache/datafusion-comet/issues/1751
Doc changes to provide steps to run individual unit tests in Apache-Spark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
alamb commented on PR #16095:
URL: https://github.com/apache/datafusion/pull/16095#issuecomment-2891779107
Welcome back @findepi 🤗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
alamb merged PR #16095:
URL: https://github.com/apache/datafusion/pull/16095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb merged PR #16094:
URL: https://github.com/apache/datafusion/pull/16094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #16031:
URL: https://github.com/apache/datafusion/pull/16031#issuecomment-2891772639
I plan to merge this PR to main once the CI has passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
alamb commented on PR #15911:
URL: https://github.com/apache/datafusion/pull/15911#issuecomment-2891771248
I just merged a fix for CI on main, and remerged this PR. Hopefully it will
now be good to go
--
This is an automated message from the Apache Git Service.
To respond to the message,
suibianwanwank commented on issue #5492:
URL: https://github.com/apache/datafusion/issues/5492#issuecomment-2891769413
I'm not sure if I fully understand your point. In this paper, the
decorrelate should be based on `DependentJoin`, as can be seen from the example
relational algebra diagram
alamb merged PR #16089:
URL: https://github.com/apache/datafusion/pull/16089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #16089:
URL: https://github.com/apache/datafusion/pull/16089#issuecomment-2891767670
Since this is just moving code around and is likely uncontroversial I am
going to merge it in without waiting the customary 24 hours
--
This is an automated message from the Apache G
alamb merged PR #16102:
URL: https://github.com/apache/datafusion/pull/16102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #16102:
URL: https://github.com/apache/datafusion/pull/16102#issuecomment-2891764217
Thank you for the quick review @andygrove -- merging this in to unblock CI
(we have a pile of PRs waiting to merge)
--
This is an automated message from the Apache Git Service.
To r
alamb commented on issue #16065:
URL: https://github.com/apache/datafusion/issues/16065#issuecomment-2891762929
> Stabilize external sort and aggregate.
In my opinion, I suggest starting and finishing with external sort -- having
a robust and performance external sort can be a key
jsai28 commented on PR #16079:
URL: https://github.com/apache/datafusion/pull/16079#issuecomment-2891756937
@alamb Yep I just need to fix that clippy issue and then I'll add it to the
rest of the tests. I'll probably just do it in this PR itself
--
This is an automated message from th
parthchandra commented on PR #1747:
URL:
https://github.com/apache/datafusion-comet/pull/1747#issuecomment-2891757995
Looking good so far. Will do a final review once it is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
timsaucer commented on PR #15911:
URL: https://github.com/apache/datafusion/pull/15911#issuecomment-2891757264
> > > Do you think it is feasible to update the scalar, aggregate, and
window function APIs to use `FieldRef` instead of Field? That way we can avoid
most string copies.
> >
andygrove commented on code in PR #1746:
URL: https://github.com/apache/datafusion-comet/pull/1746#discussion_r2096187472
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2376,12 +2375,26 @@ object QueryPlanSerde extends Logging with
CometExprShim {
Dandandan commented on code in PR #16087:
URL: https://github.com/apache/datafusion/pull/16087#discussion_r2096162977
##
datafusion/functions/src/string/ascii.rs:
##
@@ -103,19 +106,29 @@ impl ScalarUDFImpl for AsciiFunc {
fn calculate_ascii<'a, V>(array: V) -> Result
where
alamb commented on PR #15911:
URL: https://github.com/apache/datafusion/pull/15911#issuecomment-2891735853
> > Do you think it is feasible to update the scalar, aggregate, and window
function APIs to use `FieldRef` instead of Field? That way we can avoid most
string copies.
>
> Do yo
alamb commented on PR #16072:
URL: https://github.com/apache/datafusion/pull/16072#issuecomment-2891733882
I also looked around for more docs about sort merge join or experimental and
could not find them
--
This is an automated message from the Apache Git Service.
To respond to the messag
Dandandan commented on code in PR #16087:
URL: https://github.com/apache/datafusion/pull/16087#discussion_r2096168025
##
datafusion/functions/src/string/ascii.rs:
##
@@ -103,19 +103,22 @@ impl ScalarUDFImpl for AsciiFunc {
fn calculate_ascii<'a, V>(array: V) -> Result
where
andygrove commented on code in PR #1744:
URL: https://github.com/apache/datafusion-comet/pull/1744#discussion_r2096163931
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2518,6 +2518,15 @@ object QueryPlanSerde extends Logging with CometExprShim
{
parthchandra commented on code in PR #1746:
URL: https://github.com/apache/datafusion-comet/pull/1746#discussion_r2096122217
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2376,12 +2375,26 @@ object QueryPlanSerde extends Logging with
CometExprShim
Dandandan commented on code in PR #16087:
URL: https://github.com/apache/datafusion/pull/16087#discussion_r2096161845
##
datafusion/functions/src/string/ascii.rs:
##
@@ -103,19 +103,22 @@ impl ScalarUDFImpl for AsciiFunc {
fn calculate_ascii<'a, V>(array: V) -> Result
where
duongcongtoai commented on issue #5492:
URL: https://github.com/apache/datafusion/issues/5492#issuecomment-2891716695
I wonder if creating `LogicalPlan::DependentJoin` make sense in our case? if
the only place it is being used is inside the optimizor that does the
decorrelation
In du
1 - 100 of 237 matches
Mail list logo
