timsaucer commented on PR #15911: URL: https://github.com/apache/datafusion/pull/15911#issuecomment-2891757264
> > > Do you think it is feasible to update the scalar, aggregate, and window function APIs to use `FieldRef` instead of Field? That way we can avoid most string copies. > > > > > > Do you think it's reasonable to merge this as is and do switch to `FieldRef` in a separate PR? > > Absolutely -- it makes sense to me -- it would also be great to see if we can update the scalar function API while we are at it Thanks. I'll re-try CI after pulling in main. This passes every time on my local machine. I'm not sure why it's failing here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
