idn't find anything blatantly wrong ;-). Will
> nitpick individual patches later but I expect that it would be
> sufficient to locally tweak while queuing without rerolling.
I have one small issue ...
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git&
degree of detail of GIT_CURL_VERBOSE, in particular
>> the complete transport header and all the data payload exchanged.
>> It might be useful if a particular situation could require a more
>> thorough debugging analysis.
>>
>> Helped-by: Torsten Bögershausen
>> Helped
?), so I thought I would just make sure you were aware
of these 'unexpected passes'.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
`, when it uses the am backend, is also significantly
> faster.
I just tried to git-am these patches, but patch #78 did not make it
to the list.
(Also, patches #59 and #62 both issue a 'new blank line at EOF' warning).
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the li
Sparse complains thus:
SP convert.c
convert.c:178:24: warning: Using plain integer as NULL pointer
convert.c:239:28: warning: dubious: !x & y
Signed-off-by: Ramsay Jones
---
Hi Torsten,
When you next re-roll your 'tb/convert-eol-autocrlf' branch, could you
please sq
On 24/04/16 17:56, Christian Couder wrote:
> On Sun, Apr 24, 2016 at 6:27 PM, Christian Couder
> wrote:
>> On Sun, Apr 24, 2016 at 5:23 PM, Ramsay Jones
>> wrote:
>>>
>>>
>>> On 24/04/16 14:33, Christian Couder wrote:
>>>> This is a pa
t;>> VS (or another file) setting __GNUC__?
>>
>> Of course it helps if we spell the name right...
Indeed! ;-)
Not that it matters, but the above #define in git-compat-util.h is not
the relevant definition - msvc will not see it. However, it does see
the #define on line 12 of comp
t=1),
> +- the config file is invalid (ret=3),
> +- the config file cannot be written (ret=4),
> - you try to unset an option which does not exist (ret=5),
> - you try to unset/set an option for which multiple lines match (ret=5), or
> - you try to use an invalid regexp (ret=6).
>
On 26/04/16 20:18, Stefan Beller wrote:
> On Tue, Apr 26, 2016 at 12:11 PM, Ramsay Jones
> wrote:
>>
>>
>> On 26/04/16 19:10, Stefan Beller wrote:
>>> The possible reasons for exiting are now ordered by the exit code value.
>>> While at it, rewrite
public symbol. (I would also re-order the function definitions,
so that setup_curl_trace() comes after curl_trace(), but that is a
minor point).
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More
p', since I can't debug it. :(
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ssys 0m0.154s
>
The corresponding times for me were:
(master) (with the series)
real 0m9.760s real 0m5.744s
user 0m0.531s user 0m0.656s
sys 0m5.726s sys 0m3.520s
So, yes, a noticeable improvement! :)
HTH
ATB,
Ramsay Jone
On 21/10/15 17:05, Torsten Bögershausen wrote:
> On 21.10.15 16:37, Ramsay Jones wrote:
>> Hi Junio,
>>
>> While testing the next branch today, I had a test failure, viz:
>>
>> $ tail ntest-out-fail
>> Test Summary Report
>> -
On 21/10/15 18:50, David Turner wrote:
> On Wed, 2015-10-21 at 18:05 +0200, Torsten Bögershausen wrote:
>> On 21.10.15 16:37, Ramsay Jones wrote:
>>> Hi Junio,
>>>
>>> While testing the next branch today, I had a test failure, viz:
>>>
>>>
b/Documentation/git-clone.txt
> @@ -216,9 +216,10 @@ objects from the source repository into a pack in the
> cloned repository.
> The result is Git repository can be separated from working
> tree.
>
> --j::
> ---jobs::
> +-j ::
> +--jobs ::
> The number of
On 29/10/15 15:51, Stefan Beller wrote:
> On Thu, Oct 29, 2015 at 6:19 AM, Ramsay Jones
> wrote:
>
>> Hmm, is there a way to _not_ fetch in parallel (override the
>> config) from the command line for a given command?
>>
>> ATB,
>> Ramsay Jones
>
>
oincidence rather than it being particularly related to the
>> function those tests are actually testing.
>
> Looks like lib-proto-disable.sh's fake SSH doesn't strip double leading
> /'es from the path. Try this patch:
>
> diff --git a/t/t5813-proto-disable-ssh.sh
On 07/11/15 21:21, Ramsay Jones wrote:
>
>
> On 07/11/15 21:02, Dennis Kaarsemaker wrote:
>> On za, 2015-11-07 at 19:20 +, Adam Dinwoodie wrote:
>>> On Sat, Nov 07, 2015 at 01:45:27PM -0500, Jeff King wrote:
>>>> On Sat, Nov 07, 2015 at 12
On 07/11/15 23:32, Dennis Kaarsemaker wrote:
> On za, 2015-11-07 at 23:05 +0000, Ramsay Jones wrote:
>>
>> On 07/11/15 21:21, Ramsay Jones wrote:
>>>
>>>
>>> On 07/11/15 21:02, Dennis Kaarsemaker wrote:
>>>> On za, 2015-11-07 at 19:20 +,
that bug, I hadn't given any thought to whether
cygwin (let alone git) supported the UNC notation. At that time, I did
spend a little time trying to determine if it worked, but for some
reason I just couldn't get a network share configured properly.
It kept on giving me 'permission den
derstand, is_branch() is already declared in refs.h, see line 67.
This is true in master, next and pu now appears to have two declarations.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
d the remainder of the
patch and noticed that the 'internal' header #included the
'public' interface header.
Unfortunately, this still feels wrong to me! I would rather that
the internal header _not_ include the public header (so, include
them _both_ when necessary). Just my opin
it integer. This results in a couple
of printf format warnings.
In order to suppress the warnings, change the format specifier to use
the PRIuMAX macro and cast the off_t argument to uintmax_t. (See also
the http_opt_request_remainder() function, which uses the same
solution).
Signed-off-by: Ra
On 11/11/15 01:22, Eric Sunshine wrote:
> On Tue, Nov 10, 2015 at 7:23 PM, Ramsay Jones
> wrote:
>> Commit f8117f55 ("http: use off_t to store partial file size",
>> 02-11-2015) changed the type of some variables from long to off_t.
>> The 32-bit build,
On 11/11/15 02:00, Stefan Beller wrote:
> On Tue, Nov 10, 2015 at 5:22 PM, Eric Sunshine
> wrote:
>> On Tue, Nov 10, 2015 at 7:23 PM, Ramsay Jones
>> wrote:
>>> Commit f8117f55 ("http: use off_t to store partial file size",
>>> 02-11-2015) changed
On 11/11/15 20:31, Eric Sunshine wrote:
> On Wed, Nov 11, 2015 at 12:47 PM, Ramsay Jones
> wrote:
>> On 11/11/15 01:22, Eric Sunshine wrote:
>>> On Tue, Nov 10, 2015 at 7:23 PM, Ramsay Jones
>>> wrote:
>>> My machine is 64-bit, though, so perhaps it
uintmax_t. (See also
the http_opt_request_remainder() function, which uses the same
solution).
Signed-off-by: Ramsay Jones
---
http.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/http.c b/http.c
index 42f29ce..2532976 100644
--- a/http.c
+++ b/http.c
@@ -1617
"%ld", and print
> the lower part of long_long_var.
> And will not pull a long long from stack, but a long, resulting i all kinds
> of confusion
>
> So whenever a long long is printed, I can warmly recommend to use
>
> PRId64
Indeed.
ATB,
Ramsay Jones
--
To unsub
On 13/11/15 08:57, Eric Sunshine wrote:
> On Fri, Nov 13, 2015 at 3:46 AM, Lars Schneider
> wrote:
>> On 11 Nov 2015, at 18:49, Ramsay Jones wrote:
>>> On 11/11/15 02:00, Stefan Beller wrote:
>>>> On Tue, Nov 10, 2015 at 5:22 PM, Eric Sunshine
>>>&
mparing the exit code, rather
than the string = operator.
Signed-off-by: Ramsay Jones
---
Hi Lars,
This patch is on top of the pu branch, but it relates to the two
patches on your 'ls/test-must-fail-sigpipe' branch. Could you
please squash the relevant parts of this patch into your patches.
S
is classic bikeshedding on the naming
of things and I am, in general, hopeless at naming things ... :-D ]
I don't think you need to include 'text' in the name of the
line ending descriptors - if its not binary then its some
form of text. So, maybe something like:
binary
n
On 24/11/15 21:08, Jeff King wrote:
> On Tue, Nov 24, 2015 at 03:59:24PM +0000, Ramsay Jones wrote:
>
>> After commit 710eb805 ("implement test_might_fail using a refactored
>> test_must_fail", 19-11-2015) several tests now unexpectedly pass:
>
> Thanks. I
Signed-off-by: Ramsay Jones
---
Hi Torsten,
If you need to re-roll your 'tb/ls-files-eol' patch, could you
please squash this into the patch.
Thanks.
ATB,
Ramsay Jones
convert.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/convert.c b/convert.c
index c99adc
Signed-off-by: Ramsay Jones
---
Hi Michael,
If you need to re-roll the patches in your 'mr/ff-refs' branch,
could you please squash parts of this patch into the relevant
patches from your branch.
Thanks.
Also, I note that gcc complains about the two calls to chdir().
(warning
Signed-off-by: Ramsay Jones
---
Hi Jeff,
Can we squash this into your fixup?
ATB,
Ramsay Jones
t/test-lib-functions.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
index 85aeaf9..2bb639e 100644
--- a/t/test-lib
t;. This removes
> redundancies in test-lib-function.sh.
>
> You can pass multiple arguments divided by comma (e.g.
> "test_must_fail ok=success,something")
>
> Signed-off-by: Junio C Hamano
> Signed-off-by: Jeff King
>
Signed-off-by: Ramsay Jones
---
Hi Karthik,
If you need to re-roll the patches in your 'kn/ref-filter-atom-parsing'
branch, could you please squash the relevant parts of this patch into
yours.
Thanks!
ATB,
Ramsay Jones
ref-filter.c | 10 +-
1 file changed, 5 insert
Signed-off-by: Ramsay Jones
---
Hi David,
If you need to re-roll your 'dt/refs-backend-lmdb' branch, could
you please squash the relevant parts of this patch into yours.
[yes, I didn't reference the movement of the external declaration
in the commit message! :-D ]
Thanks!
AT
Signed-off-by: Ramsay Jones
---
Hi Christian,
If you need to re-roll your 'cc/untracked' branch, could you
please squash the relevant parts of this into your patches.
Thanks!
Also, you may what to consider removing the emulation of uname()
on MinGW, since this is no longer requ
o", or core.autocrlf != false.
> ++
> +"eolinfo" is either "" (when the the info is not available"), or one of
> "binary",
> +"text-no-eol", "text-lf", "text-crlf" or "text-crlf-lf".
Again, I think this list reads better as: binary, none, lf, crlf and mixed.
If you prefer to have 'text' in there somewhere, how about:
binary, text-none, text-lf, text-crlf, text-mixed.
:-D
(I promise not the mention it again!)
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signed-off-by: Ramsay Jones
---
Hi Christian,
If you need to re-roll your 'cc/untracked' branch, could you
please squash this into your patches.
You seem to have only half applied my last fixup patch! ;-)
(I'm guessing that you had already renamed the function
locally before I
ody have an idea here ?
>
> I'm unable to reproduce these failures on Mac.
>
This test failed during a short window (due to commit 2bd811ec) and
has already been fixed in commit 3a74ea38 ("notes: allow merging
from arbitrary references", 29-12-2015).
ATB,
Ramsay Jones
--
T
Hi Torsten,
On 01/01/16 15:36, Torsten Bögershausen wrote:
> The (last) test case
> 'conflict markers contain CRLF when core.eol=crlf'
>
> does not work as expected under Mac OS: "wc -l" is not portable and the line
> test $(sed -n "/\.txt\r$/p" output.txt | wc -l) = 3
> fails.
Hmm, I have never
On 01/01/16 17:49, Torsten Bögershausen wrote:
> On 2016-01-01 18.14, Ramsay Jones wrote:
>> Hi Torsten,
>>
>> On 01/01/16 15:36, Torsten Bögershausen wrote:
>>> The (last) test case
>>> 'conflict markers contain CRLF when core.eol=crlf'
>>&
isables access to Cygwin's executable attribute,
> which Windows filesystems do not have at all.
>
> I wonder if this is still relevant these days (Cc'ed Ramsay for
> input).
Ah, no, the 'tricks we have to play with lstat' mentioned in that
commit message are long gone! ;-) If you remove that conditional,
then the test passes just fine.
ATB,
Ramsay Jones
gt; + argv_array_clear(&argv);
> -+ return -1;
> ++ return error(_("could not check out original"
> ++ " HEAD '%s'. Try 'git bisect"
> ++ "reset '."), branch.buf);
... this 'branch.buf' will refer to the empty 'slopbuf', since
the call to 'strbuf_release(&branch)' now precedes this call
to error().
ATB,
Ramsay Jones
Signed-off-by: Ramsay Jones
---
Hi Derrick,
If you need to re-roll your 'ds/push-sparse-tree-walk' branch, could
you please squash this into the relevant patch [commit 9949aaeef4
("revision: implement sparse algorithm", 2018-12-14)].
This commit caused both 'sparse
Signed-off-by: Ramsay Jones
---
Hi Alban,
If you need to re-roll your 'ag/sequencer-reduce-rewriting-todo' branch,
could you please squash this into the relevant patch [commit 45f215c912
("rebase-interactive: use todo_list_write_to_file() in edit_todo_list()",
2018-12-2
Signed-off-by: Ramsay Jones
---
Hi Alban,
If you need to re-roll your 'ag/sequencer-reduce-rewriting-todo' branch,
could you please squash this into the relevant patch [commit c27b32f0ec4
("sequencer: refactor check_todo_list() to work on a todo_list",
2018-12-29)].
[Bot
rameters,
before the declaration of 'struct repository'. Move the struct
declaration to the top of the file.
Signed-off-by: Ramsay Jones
---
Hi Duy,
If you need to re-roll your 'nd/config-move-to' branch, could you please
squash this into the relevant patch (commit 8f7c7f).
Signed-off-by: Ramsay Jones
---
Hi Duy,
If you need to re-roll your 'nd/the-index-final' branch, could you
please squash this into the relevant patch (commit 4478671442,
"cache.h: flip NO_THE_INDEX_COMPATIBILITY_MACROS switch", 2019-01-12).
[the warning is caused by th
On 17/01/2019 10:06, Duy Nguyen wrote:
> On Thu, Jan 17, 2019 at 8:21 AM Ramsay Jones
> wrote:
>>
>>
>> Signed-off-by: Ramsay Jones
>> ---
>>
>> Hi Duy,
>>
>> If you need to re-roll your 'nd/the-index-final' branch, could you
> strbuf.o - strbuf_vinsertf
$
BTW, if my memory serves (and it may not), the symbols you
refer to came directly into 'master' (via 'maint') as a
result of security updates - so I would never have seen
them in 'pu' or 'next'. They are, indeed, currently noted
in the 'master' branch:
$ grep is_ntfs_ sc
path.o - is_ntfs_dotgitattributes
path.o - is_ntfs_dotgitignore
$ grep is_hfs_ sc
utf8.o - is_hfs_dotgitattributes
utf8.o - is_hfs_dotgitignore
$
ATB,
Ramsay Jones
On 22/01/2019 07:23, Jeff King wrote:
> On Fri, Jan 18, 2019 at 01:41:08AM +0000, Ramsay Jones wrote:
>
>> I don't do this "from time to time", but *every* build on all
>> platforms! :-D
>>
>> As I have mentioned before, I run the script on 'ma
workflow (pasting the report into
> Thunderbird and sending) than with the content itself.
Have you read Doucmentation/git-format-patch.txt (Thunderbird>
Approach #2 (configuration) - approx. line 487)?
ATB,
Ramsay Jones
Signed-off-by: Ramsay Jones
---
Hi Johannes,
If you need to re-roll your 'js/vsts-ci' branch, could you please
squash this into the relevant patch (commit af7747e7c7 ("tests: optionally
write results as JUnit-style .xml", 2019-01-23)).
Thanks!
ATB,
Ramsay Jones
t/help
Signed-off-by: Ramsay Jones
---
Hi Jeff,
If you need to re-roll your 'jh/trace2' branch, could you please
squash this into the relevant patches (sorry, I didn't look to
see which patches need to be modified).
Thanks!
ATB,
Ramsay Jones
trace2/tr2_tgt.h | 4
trace2/tr2_
On 28/01/2019 16:10, Johannes Schindelin wrote:
> Hi Ramsay,
>
> On Sat, 26 Jan 2019, Ramsay Jones wrote:
>
>>
>> Signed-off-by: Ramsay Jones
>> ---
>>
>> Hi Johannes,
>>
>> If you need to re-roll your 'js/vsts-ci' branch,
On 28/01/2019 22:34, Johannes Schindelin wrote:
> Hi Ramsay,
>
> On Mon, 28 Jan 2019, Ramsay Jones wrote:
>
>> Hmm, I've never built an Ubuntu package before, so I don't know
>> exactly what would be required (spec file etc.) to create a PPA.
>> But I
On 29/01/2019 01:52, Luc Van Oostenryck wrote:
> On Mon, Jan 28, 2019 at 08:13:03PM +0000, Ramsay Jones wrote:
>
> Hi
>
>> The dependencies for the 'sparse' package includes: libc6 (>= 2.14),
>> libllvm4.0 (>= 1:4.0~), libxml2 (>= 2.7.4), perl:any
&g
b19c3bf..1c385e076e 100644
--- a/change-table.h
+++ b/change-table.h
@@ -50,10 +50,10 @@ struct change_head {
* That is the ref was deleted since the time this struct was created.
Such
* entries should be ignored.
*/
- int abandoned:1,
- hidden:1,
- remote:1,
- deleted:1;
+ unsigned int abandoned:1,
+ hidden:1,
+ remote:1,
+ deleted:1;
};
/*
-- >8 --
[Note: this diff was against the v3 series].
ATB,
Ramsay Jones
.c
$ echo $?
0
$
$ SPARSE_FLAGS=-Wsparse-error make pack-revindex.sp
SP pack-revindex.c
$ echo $?
0
$
Now, we should be able to run the sparse Makefile target in a CI job, and
still find all sparse errors and warnings (now marked as errors also),
using something like this:
$
t-specific rules in the Makefile (effectively
making them useless). In addition, we initialise the SPARSE_FLAGS
to the default (empty) value using a conditional assignment (?=).
This allows the SPARSE_FLAGS to be set from the environment as
well as from the command-line.
Signed-off-by: Ra
On 01/02/2019 21:46, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> In order to enable greater user customisation of the SPARSE_FLAGS
>> variable, we introduce a new SP_EXTRA_FLAGS variable to use for
>> target specific settings. Without using the new variable, set
On 02/02/2019 00:41, SZEDER Gábor wrote:
> On Fri, Feb 01, 2019 at 09:01:20PM +0000, Ramsay Jones wrote:
[snip]
>> At the moment, on Linux, the sp-out file is free from any sparse errors
>> or warnings. So are next and pu:
>>
>> $ grep error sp-out
>>
On 01/02/2019 22:40, Luc Van Oostenryck wrote:
> On Fri, Feb 01, 2019 at 09:01:20PM +0000, Ramsay Jones wrote:
>>
>> I suspect that the Makefile sparse target is not easy to use in a CI
>> job, since the 'sparse' program (via cgcc -no-compile) does not exit
>
On 03/02/2019 12:12, SZEDER Gábor wrote:
> On Sun, Feb 03, 2019 at 01:49:37AM +0000, Ramsay Jones wrote:
>> On 02/02/2019 00:41, SZEDER Gábor wrote:
>>> On Fri, Feb 01, 2019 at 09:01:20PM +, Ramsay Jones wrote:
>>>> At the moment, on Linux, the sp-out file
On 04/02/2019 18:12, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>>> Thanks for a detailed and clear explanation here and in the cover
>>> letter. I agree with the motivation and most of the things I see in
>>> this patch, but one thing that stands out
On 30/01/2019 12:29, Jeff Hostetler wrote:
>
>
> On 1/26/2019 4:07 PM, Ramsay Jones wrote:
>>
>> Signed-off-by: Ramsay Jones
>> ---
>>
>> Hi Jeff,
>>
>> If you need to re-roll your 'jh/trace2' branch, could you please
>> sq
On 04/02/2019 20:15, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> On 04/02/2019 18:12, Junio C Hamano wrote:
>>> Ramsay Jones writes:
>>>
>>>>> Thanks for a detailed and clear explanation here and in the cover
>>>>> letter.
ndex.sp
SP pack-revindex.c
$ echo $?
0
$
$ SPARSE_FLAGS=-Wsparse-error make pack-revindex.sp
SP pack-revindex.c
$ echo $?
0
$
Now, we should be able to run the sparse Makefile target in a CI job, and
still find all sparse errors and warnings (now marked as err
. Since 'sparse' does not currently
support the MinGW platform, nobody on that platform can be relying
on this setting today. Remove this use of the SPARSE_FLAGS variable.
Signed-off-by: Ramsay Jones
---
config.mak.uname | 1 -
1 file changed, 1 deletion(-)
diff --git a/config.m
onditional assignment (?=). This allows SPARSE_FLAGS
to be set from the environment as well as from the command-line.
Signed-off-by: Ramsay Jones
---
Makefile | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/Makefile b/Makefile
index 6e8d017e8e..fcb7575e1b 10
Signed-off-by: Ramsay Jones
---
Hi Christian,
If you need to re-roll your 'cc/multi-promisor' branch, could you
please squash this into the relevant patch (commit e52d417b57
("promisor-remote: implement promisor_remote_get_direct()", 2019-04-01)).
[I had a deja-vu mome
On 05/04/2019 00:22, Jeff King wrote:
> There's no such argument as "--unordered"; it's spelled "--unsorted".
Err, isn't this back-to-front? (i.e. cat-file has the _option_
"--unordered" but not "--unsorted").
I suspect that I am not reading that right! :-D
ATB,
Ramsay Jones
ject_crc;
> +int do_check_packed_object_crc;
... removing this 'extern' on an int variable sends 'sparse'
into a frenzy of warnings! :-D
[You didn't use a global s/extern// by any chance?]
ATB,
Ramsay Jones
d44b5af6e3292c837ceda003f9 0 b
100644 a296d0bb611188cabb256919f36bc30117cca005 0 c
100644 a296d0bb611188cabb256919f36bc30117cca005 0 c
$
Er, ... well, I obviously don't have a clue how it is supposed
to work. This just looks broken to me. :(
> So the patch itself looks good to me (though I agree that Eric's
> suggestion to de-dup inside "make" is better still).
Agreed.
ATB,
Ramsay Jones
only
> one small merge conflict.
... not forgetting the second hunk of [1], of course. ;-)
[1]
https://public-inbox.org/git/5f0c12d5-6714-1516-3579-33d839ad7...@ramsayjones.plus.com/
ATB,
Ramsay Jones
_NONEG, NULL, 0, diff_opt_output },
Note that the 'option type' is given as OPTION_CALLBACK, not
as OPTION_LOWLEVEL_CALLBACK. Is this intended?
ATB,
Ramsay Jones
[1] Yes, the reason my branch is long running is because
we keep changing the same files! We have both defined new
OPT_() macros, some with the same name ... ;-)
On 22/05/2019 01:11, Duy Nguyen wrote:
> On Wed, May 22, 2019 at 2:56 AM Ramsay Jones
> wrote:
>>
>> Hi Duy,
>>
>> I am in the middle of rebasing a long running branch onto
>> current master (v2.22.0-rc1) and noticed something odd with
>> commit af
e
merge to 'next' went without problem, and 'pu' only required a fixup
to the builtin/commit patch).
[The 'warn-v2.21' branch shows the previous version of the series.]
What do you think?
Thanks!
ATB,
Ramsay Jones
Ramsay Jones (52):
parse-options: reformat th
On 24/05/2019 23:30, Ævar Arnfjörð Bjarmason wrote:
>
> On Fri, May 24 2019, Ramsay Jones wrote:
>
>> [No, I won't be sending 52 patches to the list!]
>> [...]
>> This series does not fix any problems or add any new features, so it
>> is not important (
uld be cleaned up or simplified. If we want to
> shut up the warning completely (so we can pay attention to it), we'll
> then have to annotate probably a couple hundred spots, and keep those
> annotations up to date. But I feel better doing that knowing that it's
> shown real-world value.
OK, I will drop this branch then.
Thanks all.
ATB,
Ramsay Jones
ot;git commit-graph write [--object-dir ] [--append|--split]
> [--reachable|--stdin-packs|--stdin-commits]"),
> + N_("git commit-graph write [--object-dir ] [--append|--split]
> [--reachable|--stdin-packs|--stdin-commits] "),
> NULL
> };
>
> @@ -135,6 +135,7 @@ static int graph_read(int argc, const char **argv)
> }
>
> extern int read_replace_refs;
> +struct split_commit_graph_opts split_opts;
This 'split_opts' variable needs to be marked 'static'.
Thanks.
ATB,
Ramsay Jones
; compat/obstack.c:331:5:expected void ( *[addressable] [toplevel]
obstack_alloc_failed_handler )( ... )
> compat/obstack.c:331:5: got void ( [noreturn] * )( ... )
$
So, yes you did catch all "using plain integer as NULL pointer"
warnings! :-D
Thanks.
ATB,
Ramsay Jones
On 14/06/2019 21:30, Ramsay Jones wrote:
>
>
> On 14/06/2019 11:00, SZEDER Gábor wrote:
>> Update 'compat/obstack.{c,h}' from upstream, because they already use
>> 'size_t' instead of 'long' in places that might eventually end up as
>>
On 20/06/2019 08:41, Jeff King wrote:
> There are no callers left of lookup_object() that aren't just passing us
s/lookup_object/create_object/
ATB,
Ramsay Jones
Signed-off-by: Ramsay Jones
---
Hi Duy,
If you need to re-roll your 'nd/index-dump-in-json' branch, could
you please squash this into the relevant patch (commit 53f1666b3a,
'split-index.c: dump "link" extension as json', 2019-06-19).
Thanks!
ATB,
Ramsay Jones
g something, but the above is usually
sufficient for my uses. (Having said that, I have not
had the need to debug extensions [yet!]).
ATB,
Ramsay Jones
Signed-off-by: Ramsay Jones
---
Hi Ævar,
If you need to re-roll your 'ab/test-env' branch, could you please
squash this into the relevant patch (commit b4f207f339, "env--helper:
new undocumented builtin wrapping git_env_*()", 2019-06-21).
Thanks!
ATB,
Ramsay Jones
b
Signed-off-by: Ramsay Jones
---
Hi Christian,
If you need to re-roll your 'cc/multi-promisor' branch, could you please
squash this into the relevant patch (commit 9e27beaa23, "promisor-remote:
implement promisor_remote_get_direct()", 2019-06-25).
[No, this is not the sam
Signed-off-by: Ramsay Jones
---
Hi Junio,
It seems Ævar didn't have a need to re-roll his patches [1], before
the 'ab/test-env' branch was merged to next. This version of the
patch is based on current 'next'.
Thanks!
ATB,
Ramsay Jones
[1]
https://public-inbox.o
Signed-off-by: Ramsay Jones
---
Hi Thomas,
If you need to re-roll your 'tg/range-diff-output-update' branch, could
you please squash (parts) of this into the relevant patches.
The first hunk fixes a couple of 'hdr-check' warnings:
$ diff nhcout phcout | head
4a5,1
124 ++-
> t/t3206/history.export | 84 ++-
> 7 files changed, 409 insertions(+), 163 deletions(-)
Yes, the patch I just sent related to the previous version of
this series. However, I believe it still applies to this version
(looking at the range-diff below
rs. The default behavior respects the
> + `reset.quiet` config option, or `--no-quiet` if that is not set.
Sorry, I can't quite parse this; -q,--quiet and --no-quiet on the
command line (should) trump whatever rest.quiet is set to in the
configuration. Is that not the case?
ATB,
Ramsa
ions can be used to override any configured
default.
Hmm, I am not sure that is any better! :-D
Also, note that the --no-option is often described separately to
the --option (in a separate paragraph). I don't know if that would
help here.
[The default behaviour is _not_ set by the con
through the exact sequence in your paragraph when writing
> my other message. That's probably a good sign that we should probably
> not pursue this further unless we see the use case come up again a few
> more times (and if we do, then consider "config" the least-bad place to
> do it).
I was thinking:
$ git var -e GIT_WHATEVER_ENV
[-e for environment].
... but that is really no different than git-config. ;-)
ATB,
Ramsay Jones
> report and leave further refinements to incremental updates as
> needed?
Yeah, the first version gave me a 'huh?' moment (hence the
comment), the last version was better and, as you can see,
I am no great shakes at wordsmith-ing documentation! ;-)
Thanks!
ATB,
Ramsay Jones
Hmm, sorry, I don't see how this patch has anything to do
with the other two patches! ;-)
Also, I have a patch to fix up the 'commit-reach.h' header
(it was part of my original series, just had to update the
commit message), which adds these very #includes and forward
declarations when _using_ the commit-slab.
I haven't tried applying your patches yet, which may answer
my questions, so I am a little puzzled.
ATB,
Ramsay Jones
On 25/10/2018 19:54, Ramsay Jones wrote:
>
>
> On 25/10/2018 12:04, Carlo Marcelo Arenas Belón wrote:
>> struct commmit needs to be defined before commit-slab can generate
>> working code, object_id should be at least known through a forward
>> declaration
>>
201 - 300 of 1047 matches
Mail list logo
