On 25/10/2018 12:04, Carlo Marcelo Arenas Belón wrote:
> struct commmit needs to be defined before commit-slab can generate
> working code, object_id should be at least known through a forward
> declaration
>
> Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com>
> ---
> commit-slab-impl.h | 2 ++
> commit-slab.h | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/commit-slab-impl.h b/commit-slab-impl.h
> index e352c2f8c1..db7cf3f19b 100644
> --- a/commit-slab-impl.h
> +++ b/commit-slab-impl.h
> @@ -1,6 +1,8 @@
> #ifndef COMMIT_SLAB_IMPL_H
> #define COMMIT_SLAB_IMPL_H
>
> +#include "commit.h"
> +
> #define implement_static_commit_slab(slabname, elemtype) \
> implement_commit_slab(slabname, elemtype, MAYBE_UNUSED static)
>
> diff --git a/commit-slab.h b/commit-slab.h
> index 69bf0c807c..722252de61 100644
> --- a/commit-slab.h
> +++ b/commit-slab.h
> @@ -1,6 +1,8 @@
> #ifndef COMMIT_SLAB_H
> #define COMMIT_SLAB_H
>
> +struct object_id;
> +
> #include "commit-slab-decl.h"
> #include "commit-slab-impl.h"
>
>
Hmm, sorry, I don't see how this patch has anything to do
with the other two patches! ;-)
Also, I have a patch to fix up the 'commit-reach.h' header
(it was part of my original series, just had to update the
commit message), which adds these very #includes and forward
declarations when _using_ the commit-slab.
I haven't tried applying your patches yet, which may answer
my questions, so I am a little puzzled.
ATB,
Ramsay Jones
