ranch: patch-series-2
Build #195
[1]: https://public-inbox.org/git/20170807211900.15001-6-pc44...@gmail.com/
[2]: https://public-inbox.org/git/20170807211900.15001-7-pc44...@gmail.com/
[3]: https://public-inbox.org/git/20171006132415.2876-4-pc44...@gmail.com/
Prathamesh Chavan (2):
submodule:
c_submodule_cb() and print_default_remote().
The function print_default_remote() is introduced for getting
the default remote as stdout.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 192 +
: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 153
git-submodule.sh| 55 +---
2 files changed, 154 insertions(+), 54 deletions(-)
diff --git a/builtin/submodule
On Wed, Jan 10, 2018 at 2:54 AM, Junio C Hamano wrote:
> Prathamesh Chavan writes:
>
>> The same mechanism is used even for porting this submodule
>> subcommand, as used in the ported subcommands till now.
>> The function cmd_deinit in split up after porting into four
>
public-inbox.org/git/xmqq7esq4tf6@gitster.mtv.corp.google.com/
Prathamesh Chavan (2):
submodule: port submodule subcommand 'sync' from shell to C
submodule: port submodule subcommand 'deinit' from shell to C
builtin/submodule--helper.c | 342 ++
c_submodule_cb() and print_default_remote().
The function print_default_remote() is introduced for getting
the default remote as stdout.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 195 +
: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 147
git-submodule.sh| 55 +
2 files changed, 148 insertions(+), 54 deletions(-)
diff --git a/builtin/submodule
ad of die_errno.
As before you can find this series at:
https://github.com/pratham-pc/git/commits/patch-series-2
And its build report is available at:
https://travis-ci.org/pratham-pc/git/builds/
Branch: patch-series-2
Build #197
Prathamesh Chavan (2):
submodule: port submodule subcommand 's
: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 147
git-submodule.sh| 55 +
2 files changed, 148 insertions(+), 54 deletions(-)
diff --git a/builtin/submodule
c_submodule_cb() and print_default_remote().
The function print_default_remote() is introduced for getting
the default remote as stdout.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 193 +
"--super-prefix displaypath",
and other required arguments to the structure and then appending the
input of submodule-foreach to the argument's array.
Signed-off-by: Prathamesh Chavan
---
The build report of this patch is available at:
https://travis-ci.org/pratham-pc/git/build
uot;--super-prefix displaypath",
to the args argv_array structure. Other required arguments and the
input of submodule-foreach is also appended to this argv_array.
Signed-off-by: Prathamesh Chavan
---
In this new version of patch following changes have been added:
module_list_compute is used
Hey everyone,
I am Prathamesh Chavan, an undergraduate student from the department
of Computer Science and Engineering, at Indian Institue of Technology,
Kharagpur. I applied for Google Summer of Code 2017 and my project
"Incremental rewrite of git-submodules" has been selected.
This pr
are used in
tests in t7407.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
In this new version of patch, following changes were added:
foreach_submodule was renamed to runcommand_in_submodule
We module_foreach into two parts, such that, module
Additional test cases added to the submodule-foreach test suite
to check the submodule foreach --recursive behavior from a
subdirectory as this was missing from the test suite.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
t/t7407-submodule
SUMMARY OF MY PROJECT:
Git submodule subcommands are currently implemented by using shell script
'git-submodule.sh'. There are several reasons why we'll prefer not to
use the shell script. My project intends to convert the subcommands into
C code, thus making them builtins. This will increase Git'
ur child_process are introduced, each successive
child process running only when previous has no stdout. The order of these
four git-describe commands is maintained the same as it was in the function
set_name_rev() before porting.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-b
a separate
child_process and running it inside the submodule.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
A new function, get_submodule_displaypath is also introduced for getting
the displaypath of the submodule while taking care of its prefix and
s
Additional test cases added to the submodule-foreach test suite
to check the submodule foreach --recursive behavior from a
subdirectory as this was missing from the test suite.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
It was observed that
both are used in
tests in t7407.
Helped-by: Brandon Williams
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
This series of patch is based on gitster/jk/bug-to-abort for untilizing its
BUG() macro.
In this new version of patch, a new function
ge
SUMMARY OF MY PROJECT:
Git submodule subcommands are currently implemented by using shell script
'git-submodule.sh'. There are several reasons why we'll prefer not to
use the shell script. My project intends to convert the subcommands into
C code, thus making them builtins. This will increase Git'
ctory.
This patch aims for its correction.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
This series of patch is based on gitster/jk/bug-to-abort for untilizing its
BUG() macro.
The observation made was as follows:
For a project - super containin
both are used in
tests in t7407.
Helped-by: Brandon Williams
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
These series of patches passes the complete test suite.
Its build report is available at:
https://travis-ci.org/pratham-pc/git/builds
Branch: s
Additional test cases added to the submodule-foreach test suite
to check the submodule foreach --recursive behavior from a
subdirectory as this was missing from the test suite.
Helped-by: Brandon Williams
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
SUMMARY OF MY PROJECT:
Git submodule subcommands are currently implemented by using shell script
'git-submodule.sh'. There are several reasons why we'll prefer not to
use the shell script. My project intends to convert the subcommands into
C code, thus making them builtins. This will increase Git'
tored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
In this new version of, we avoid exporting the $path variable to
the environment, but instead prefix the with it.
In this way, we avoid the issue it creates with the env variable
$PATH in windows.
Other than that, additionally the case
ed-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
git-submodule.sh | 2 +-
t/t7407-submodule-foreach.sh | 33 +
2 files changed, 34 insertions(+), 1 deletion(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index c0d0e9a4c..ea6f56337 100755
On Sat, Jun 3, 2017 at 7:43 AM, Stefan Beller wrote:
> On Fri, Jun 2, 2017 at 4:24 AM, Prathamesh Chavan wrote:
>> This aims to make git-submodule foreach a builtin. This is the very
>> first step taken in this direction. Hence, 'foreach' is ported to
>> submodule
eller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 67 +
git-submodule.sh| 16 ++-
2 files changed, 69 insertions(+), 14 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 566a5b6
ve flag by creating a separate child_process
and running it inside the submodule. The function print_status handles the
printing of submodule's status.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
In this new version of patch, function print_statu
org/git/20170602112428.11131-2-pc44...@gmail.com/
[4]: https://public-inbox.org/git/20170605202529.22959-1-pc44...@gmail.com/
[5]: https://public-inbox.org/git/20170605202529.22959-2-pc44...@gmail.com/
Thanks,
Prathamesh Chavan
implementing it in dir.c to
remove this code duplication.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Junio C Hamano
Signed-off-by: Prathamesh Chavan
---
In future, I intend to use this function in builtin/submodule--helper.c
as well, hence this change was introduced
n to debug them and discuss the patch
for further improvisions this week.
[1]:
https://docs.google.com/document/d/1krxVLooWl--75Pot3dazhfygR3wCUUWZWzTXtK1L-xU/
Thanks,
Prathamesh Chavan
king on improvising this patch as it was
recently debugged and posted for discussion.
[1]:
https://docs.google.com/document/d/1krxVLooWl--75Pot3dazhfygR3wCUUWZWzTXtK1L-xU/
Thanks,
Prathamesh Chavan
implementing it in dir.c to
remove this code duplication.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Junio C Hamano
Signed-off-by: Prathamesh Chavan
Signed-off-by: Junio C Hamano
---
The complete build report of this is available at:
https://travis-ci.org/pratham-pc
eller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 69 +
git-submodule.sh| 16 ++-
2 files changed, 71 insertions(+), 14 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index f7adca9
e--helper
subcommand for getting the default remote as stdout.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 180
git-submodule.sh| 56 +-
odule.
print_status is also introduced for handling the output of
the subcommand and also to reduce the code size.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 152 ++
: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 140
git-submodule.sh| 55 +
2 files changed, 141 insertions(+), 54 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule
-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 69 -
1 file changed, 50 insertions(+), 19 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 8cc648d85..f7adca95b 100644
--- a/builtin/submodule--helper.c
still scope of improvision and discussion
I'll also be focussing on improving this patch.
[1]:
https://docs.google.com/document/d/1krxVLooWl--75Pot3dazhfygR3wCUUWZWzTXtK1L-xU/
Thanks,
Prathamesh Chavan
of
generating the value for path variable(as it was in the shell script)
Helped-by: Brandon Williams
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
This patch suggestes the current status of the foreach patch.
Work is still needed on this patch f
: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 140
git-submodule.sh| 55 +
2 files changed, 141 insertions(+), 54 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule
eller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 69 +
git-submodule.sh| 16 ++-
2 files changed, 71 insertions(+), 14 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 5180659
Introduce function for_each_submodule_list for using it
in the later patches, related to porting submodule
subcommands from shell to C.
This new function is also used in ported submodule subcommand
init.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
e--helper
subcommand for getting the default remote as stdout.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 178
git-submodule.sh| 56 +-
odule.
print_status is also introduced for handling the output of
the subcommand and also to reduce the code size.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 152 ++
On Tue, Jun 20, 2017 at 5:31 AM, Andrew Ardill wrote:
> On 20 June 2017 at 07:41, Prathamesh Chavan wrote:
>
>>But as communicating between child_process is still an issue
>>and so there was no simple was to current carry out the
>>porting. And hence, a ha
flight and I applaud you for it if that is why
> you based it on 'next'. But the right way to do it would be to
> build your topic on 'master', and then in addition to testing the
> topic by itself, also make a trial merge of your topic into 'next'
> and test the result as well.
>
Thanks for making me aware about this as well. And will be following this
before sending out the updated patch-series.
Thanks,
Prathamesh Chavan
n its list. The function submodule_status() is responsible
for generating the status each submodule it is called for, and
then calls print_status().
Finally, the function print_status() handles the printing of submodule's
status.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-b
Introduce function for_each_submodule_list() and
replace a loop in module_init() with a call to it.
The new function will also be used in other parts of the
system in later patches.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin
print_default_remote().
The function print_default_remote() is introduced for getting
the default remote as stdout.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 177 ++
Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 69 +
git-submodule.sh| 16 ++-
2 files changed, 71 insertions(+), 14 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin
Beller
Signed-off-by: Prathamesh Chavan
---
The patch series is updated, and is based on 'master' branch.
This patch series contains updates patches about
Introduction of the function: get_submodule_displaypath()
(This patch wasn't posted in the last update by mistake)
Introduction
Apart from this, there still lie two submodule subcommands: 'add' and
'update' unported.
I'll try to completed as much as work related to porting but will
also, focus on improving the code completed so that it becomes good
for merging.
[1]:
https://docs.google.com/document/d/1krxVLooWl--75Pot3dazhfygR3wCUUWZWzTXtK1L-xU/
Thanks,
Prathamesh Chavan
Introduce function for_each_submodule_list() and
replace a loop in module_init() with a call to it.
The new function will also be used in other parts of the
system in later patches.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin
print_default_remote().
The function print_default_remote() is introduced for getting
the default remote as stdout.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 181 ++
Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
As suggested the unnecessary enum present was removed.
builtin/submodule--helper.c | 63 +
git-submodule.sh| 16 ++--
2 files changed, 65 insertions(+), 14 deletions
n its list. The function submodule_status() is responsible
for generating the status each submodule it is called for, and
then calls print_status().
Finally, the function print_status() handles the printing of submodule's
status.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-b
Beller
Signed-off-by: Prathamesh Chavan
---
This series of patches are build over the 'mater' branch.
Complete build report is available at:
https://travis-ci.org/pratham-pc/git/builds
Branch: setnamerev
Build #119
builtin/submodule--helper.c | 33 ++---
1 fi
t any hacks.
[1]:
https://docs.google.com/document/d/1krxVLooWl--75Pot3dazhfygR3wCUUWZWzTXtK1L-xU/
Thanks,
Prathamesh Chavan
Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 6abdad329..7af4de09b 100644
--- a/builtin/submodule
Introduce function for_each_submodule_list() and
replace a loop in module_init() with a call to it.
The new function will also be used in other parts of the
system in later patches.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin
n its list. The function submodule_status() is responsible
for generating the status each submodule it is called for, and
then calls print_status().
Finally, the function print_status() handles the printing of submodule's
status.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-b
alling the print_submodule_summary() function.
Finally, the print_submodule_summary() takes care of generating
and printing the summary for each submodule.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
This is the first version of submodule-summary posted on t
: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 143
git-submodule.sh| 55 +
2 files changed, 144 insertions(+), 54 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin
Change the scope of function count_lines for allowing the function
to be reused in other parts of the code as well.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
diff.c | 2 +-
diff.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff
print_default_remote().
The function print_default_remote() is introduced for getting
the default remote as stdout.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 181 ++
Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 63 +
git-submodule.sh| 16 ++--
2 files changed, 65 insertions(+), 14 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin
Introduce function for_each_submodule_list() and
replace a loop in module_init() with a call to it.
The new function will also be used in other parts of the
system in later patches.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin
Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 6abdad329..7af4de09b 100644
--- a/builtin/submodule
Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 63 +
git-submodule.sh| 16 ++--
2 files changed, 65 insertions(+), 14 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin
n its list. The function submodule_status() is responsible
for generating the status each submodule it is called for, and
then calls print_status().
Finally, the function print_status() handles the printing of submodule's
status.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-b
print_default_remote().
The function print_default_remote() is introduced for getting
the default remote as stdout.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 179 ++
task. With a human on
the keyboard the feedback loop is short and the changed behavior can be
adapted to quickly unlike some automation that can break silently.
Discussed-with: Ramsay Jones
Signed-off-by: Prathamesh Chavan
Signed-off-by: Stefan Beller
---
git-submodule.sh | 1 -
make the 'path' variable available and
document it as a deprecated synonym of 'sm_path'.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
Documentation/git-submodule.txt | 10 ++
1 file changed, 6 insertions(+), 4 deletions
It does not contain the topmost superproject as the author assumed,
but the direct superproject, such that $toplevel/$sm_path is the
actual absolute path of the submodule.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
Documentation/git
It was observed that the variable '$displaypath' was accessible but
undocumented. Hence, document it.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
Documentation/git-submodule.txt | 6 --
t/t7407-submodule-foreach.
uot;--super-prefix displaypath",
to the args argv_array structure. Other required arguments and the
input of submodule-foreach is also appended to this argv_array.
Helped-by: Brandon Williams
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
buil
ies-3
Build #202
Prathamesh Chavan (5):
submodule foreach: correct '$path' in nested submodules from a
subdirectory
submodule foreach: document '$sm_path' instead of '$path'
submodule foreach: clarify the '$toplevel' variable documentation
submo
task. With a human on
the keyboard the feedback loop is short and the changed behavior can be
adapted to quickly unlike some automation that can break silently.
Discussed-with: Ramsay Jones
Signed-off-by: Prathamesh Chavan
Signed-off-by: Stefan Beller
---
git-submodule.sh | 1 -
It was observed that the variable '$displaypath' was accessible but
undocumented. Hence, document it.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
Documentation/git-submodule.txt | 6 --
t/t7407-submodule-foreach.
It does not contain the topmost superproject as the author assumed,
but the direct superproject, such that $toplevel/$sm_path is the
actual absolute path of the submodule.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
Documentation/git
ies-3
Build #202
Prathamesh Chavan (5):
submodule foreach: correct '$path' in nested submodules from a
subdirectory
submodule foreach: document '$sm_path' instead of '$path'
submodule foreach: clarify the '$toplevel' variable documentation
submo
make the 'path' variable available and
document it as a deprecated synonym of 'sm_path'.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
Documentation/git-submodule.txt | 10 ++
1 file changed, 6 insertions(+), 4 deletions
uot;--super-prefix displaypath",
to the args argv_array structure. Other required arguments and the
input of submodule-foreach is also appended to this argv_array.
Helped-by: Brandon Williams
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
buil
Since due to some reason, the previous patch-series list was
unavailable on the mailing list, I have re-posted the series.
It is available at:
https://public-inbox.org/git/20180202045745.5076-1-pc44...@gmail.com/
Thanks,
Prathamesh Chavan
On Tue, Mar 7, 2017 at 3:52 PM, Vedant Bassi wrote:
> Hi,
>
> I would like to participate in GSoC 2017 and I have chosen the Use
> unsigned integral type for collection of bits , idea from the Micro
> projects list.
>
> I request the help of the community for clarifying a few questions that I
> h
Hi,
I'm Prathamesh Chavan. As a part of my micropraoject I have been working on
"Avoid pipes for git related commands in test suites". I tried sending the
patch, but it got blocked since the mail contained more than 100 000
characters.
Hence I'll like to attach the link to m
Hi,
I'm Prathamesh Chavan. As a part of my micropraoject I have been working on
"Avoid pipes for git related commands in test suites". I tried sending the
patch, but it got blocked since the mail contained more than 100 000
characters.
Hence, I have made the required changes in bra
On Wed, Mar 8, 2017 at 11:33 AM, Jeff King wrote:
> On Tue, Mar 07, 2017 at 12:52:49PM -0800, Stefan Beller wrote:
>
>> On Tue, Mar 7, 2017 at 12:39 PM, Johannes Sixt wrote:
>>
>> > Welcome to the Git community!
>>
>> >
>> > Actually, being a *micro* project, it should stay so. Not doing all of t
The exit code of the upstream of a pipe is ignored thus we should avoid
using it. By writing out the output of the git command to a file, we
can test the exit codes of both the commands.
Signed-off-by: Prathamesh
---
t/t2027-worktree-list.sh | 14 +++---
1 file changed, 7 insertions(+),
But when I read the function carefully, it only removes the trash files created
when test_failure is equal to zero. But as far as I know, I can see the files
being removed even when a test_failure is non-zero for some test script.
On Thu, Mar 9, 2017 at 3:08 AM, Prathamesh Chavan wrote
PM, Jon Loeliger wrote:
> So, like, Prathamesh Chavan said:
>> The exit code of the upstream of a pipe is ignored thus we should avoid
>> using it. By writing out the output of the git command to a file, we
>> can test the exit codes of both the commands.
>>
&
, Prathamesh Chavan wrote:
> On Wed, Mar 8, 2017 at 11:33 AM, Jeff King wrote:
>> On Tue, Mar 07, 2017 at 12:52:49PM -0800, Stefan Beller wrote:
>>
>>> On Tue, Mar 7, 2017 at 12:39 PM, Johannes Sixt wrote:
>>>
>>> > Welcome to the Git community!
>>>
&g
On Thu, Mar 9, 2017 at 1:38 PM, Christian Couder
wrote:
> On Wed, Mar 8, 2017 at 4:13 PM, Prathamesh Chavan wrote:
>> The exit code of the upstream of a pipe is ignored thus we should avoid
>> using it.
>
> You might want to say more specifically that we should avoid piping
The exit code of the upstream of a pipe is ignored thus we should avoid
using it. By writing out the output of the git command to a file, we
can test the exit codes of both the commands.
Signed-off-by: Prathamesh
---
t/t2027-worktree-list.sh | 14 +++---
1 file changed, 7 insertions(+),
Whenever a git command is present in the upstream of a pipe, its failure
gets masked by piping and hence it should be avoided for testing the
upstream git command. By writing out the output of the git command to
a file, we can test the exit codes of both the commands as a failure exit
code in any c
From: Prathamesh
Whenever a git command is present in the upstream of a pipe, its failure
gets masked by piping and hence it should be avoided for testing the
upstream git command. By writing out the output of the git command to
a file, we can test the exit codes of both the commands as a failure
From: Prathamesh
Whenever a git command is present in the upstream of a pipe, its failure
gets masked by piping and hence it should be avoided for testing the
upstream git command. By writing out the output of the git command to
a file, we can test the exit codes of both the commands as a failure
1 - 100 of 217 matches
Mail list logo
