"Morian Sonnet via GitGitGadget" wrote:
I fixed the problem with the test case. Please take another look.
> From: Morian Sonnet
>
> Calling
>
> git submodule foreach --recursive git reset --hard
>
> leads to an error stating that the option --hard is
Johannes Schindelin wrote:
Hello Johannes,
thank your for the review. Sorry for the spam, I messed up with the
replytoall command.
> Hi Morian,
>
> On Tue, 18 Jun 2019, Morian Sonnet wrote:
>
> > "Morian Sonnet via GitGitGadget" wrote:
> >
> > > Ca
unknown option is
complained about now, as the argument parsing is not properly ended by
the double dash.
This commit fixes the problem by adding the double dash in front of the
subcommand during the recursion.
Signed-off-by: Morian Sonnet
---
builtin/submodule--helper.c | 1 +
t/t7407
here comes the next version.
> Johannes Schindelin wrote:
>
> Hi Morian,
>
> On Sat, 22 Jun 2019, Morian Sonnet wrote:
>
> > Johannes Schindelin wrote:
> >
> > > On Tue, 18 Jun 2019, Morian Sonnet wrote:
> > >
> > > > "
Using the right testing git now.
unknown option is
complained about now, as the argument parsing is not properly ended by
the double dash.
This commit fixes the problem by adding the double dash in front of the
subcommand during the recursion.
Signed-off-by: Morian Sonnet
---
builtin/submodule--helper.c | 1 +
t/t7407
em starts to arise only recently, as the
> > PARSE_OPT_KEEP_UNKNOWN flag for the argument parsing of git submodule
> > foreach was removed in commit a282f5a906. Hence, the unknown option is
> > complained about now, as the argument parsing is not properly ended
unknown option is
complained about now, as the argument parsing is not properly ended by
the double dash.
This commit fixes the problem by adding the double dash in front of the
subcommand during the recursion.
Signed-off-by: Morian Sonnet
---
builtin/submodule--helper.c | 1 +
t/t7407-submodule
During the usage of git in Buildkite we noted that git fails upon calling
git submodule foreach --recursive git reset --hardafter updating git version
to 2.22.0.
This is due to a problem with the recursive calling of git submodule--helper
itself, which is fixed in the patch below.
Morian
From: Morian Sonnet
Calling
git submodule foreach --recursive git reset --hard
leads to an error stating that the option --hard is unknown to
submodule--helper.
Reasons:
. Above call is internally translated into
git submodule--helper foreach --recursive -- git reset --hard
. After
From: Morian Sonnet
Calling
git submodule foreach --recursive git reset --hard
leads to an error stating that the option --hard is unknown to
submodule--helper.
Reasons:
. Above call is internally translated into
git submodule--helper foreach --recursive -- git reset --hard
. After
During the usage of git in Buildkite we noted that git fails upon calling
git submodule foreach --recursive git reset --hardafter updating git version
to 2.22.0.
This is due to a problem with the recursive calling of git submodule--helper
itself, which is fixed in the patch below.
Morian
12 matches
Mail list logo