Re: [PATCH v2 1/1] submodule foreach: fix recursion of options

2019-06-18 Thread Morian Sonnet
"Morian Sonnet via GitGitGadget" wrote: I fixed the problem with the test case. Please take another look. > From: Morian Sonnet > > Calling > > git submodule foreach --recursive git reset --hard > > leads to an error stating that the option --hard is

Re: [PATCH v2 1/1] submodule foreach: fix recursion of options

2019-06-22 Thread Morian Sonnet
Johannes Schindelin wrote: Hello Johannes, thank your for the review. Sorry for the spam, I messed up with the replytoall command. > Hi Morian, > > On Tue, 18 Jun 2019, Morian Sonnet wrote: > > > "Morian Sonnet via GitGitGadget" wrote: > > > > > Ca

[PATCH] submodule foreach: fix recursion of options

2019-06-24 Thread Morian Sonnet
unknown option is complained about now, as the argument parsing is not properly ended by the double dash. This commit fixes the problem by adding the double dash in front of the subcommand during the recursion. Signed-off-by: Morian Sonnet --- builtin/submodule--helper.c | 1 + t/t7407

submodule foreach: fix recursion of options

2019-06-24 Thread Morian Sonnet
here comes the next version. > Johannes Schindelin wrote: > > Hi Morian, > > On Sat, 22 Jun 2019, Morian Sonnet wrote: > > > Johannes Schindelin wrote: > > > > > On Tue, 18 Jun 2019, Morian Sonnet wrote: > > > > > > > "

submodule foreach: fix recursion of options

2019-06-24 Thread Morian Sonnet
Using the right testing git now.

[PATCH] submodule foreach: fix recursion of options

2019-06-24 Thread Morian Sonnet
unknown option is complained about now, as the argument parsing is not properly ended by the double dash. This commit fixes the problem by adding the double dash in front of the subcommand during the recursion. Signed-off-by: Morian Sonnet --- builtin/submodule--helper.c | 1 + t/t7407

submodule foreach: fix recursion of options

2019-06-24 Thread Morian Sonnet
em starts to arise only recently, as the > > PARSE_OPT_KEEP_UNKNOWN flag for the argument parsing of git submodule > > foreach was removed in commit a282f5a906. Hence, the unknown option is > > complained about now, as the argument parsing is not properly ended

[PATCH] submodule foreach: fix recursion of options

2019-06-24 Thread Morian Sonnet
unknown option is complained about now, as the argument parsing is not properly ended by the double dash. This commit fixes the problem by adding the double dash in front of the subcommand during the recursion. Signed-off-by: Morian Sonnet --- builtin/submodule--helper.c | 1 + t/t7407-submodule

[PATCH 0/1] submodule foreach: fix recursion of options

2019-06-12 Thread Morian Sonnet via GitGitGadget
During the usage of git in Buildkite we noted that git fails upon calling git submodule foreach --recursive git reset --hardafter updating git version to 2.22.0. This is due to a problem with the recursive calling of git submodule--helper itself, which is fixed in the patch below. Morian

[PATCH 1/1] submodule foreach: fix recursion of options

2019-06-12 Thread Morian Sonnet via GitGitGadget
From: Morian Sonnet Calling git submodule foreach --recursive git reset --hard leads to an error stating that the option --hard is unknown to submodule--helper. Reasons: . Above call is internally translated into git submodule--helper foreach --recursive -- git reset --hard . After

[PATCH v2 1/1] submodule foreach: fix recursion of options

2019-06-12 Thread Morian Sonnet via GitGitGadget
From: Morian Sonnet Calling git submodule foreach --recursive git reset --hard leads to an error stating that the option --hard is unknown to submodule--helper. Reasons: . Above call is internally translated into git submodule--helper foreach --recursive -- git reset --hard . After

[PATCH v2 0/1] submodule foreach: fix recursion of options

2019-06-12 Thread Morian Sonnet via GitGitGadget
During the usage of git in Buildkite we noted that git fails upon calling git submodule foreach --recursive git reset --hardafter updating git version to 2.22.0. This is due to a problem with the recursive calling of git submodule--helper itself, which is fixed in the patch below. Morian