Re: [GSoC][PATCH v4 3/7] dir-iterator: add flags parameter to dir_iterator_begin

2019-03-29 Thread Matheus Tavares Bernardino
On Thu, Mar 28, 2019 at 7:19 PM Thomas Gummerer wrote: > > On 03/22, Matheus Tavares wrote: > > Add the possibility of giving flags to dir_iterator_begin to initialize > > a dir-iterator with special options. > > > > Currently possible flags are DIR_ITERATOR_PEDANTIC, which makes > > dir_iterator_

Re: [GSoC][PATCH v4 1/7] clone: test for our behavior on odd objects/* content

2019-03-29 Thread Matheus Tavares Bernardino
On Thu, Mar 28, 2019 at 6:49 PM Thomas Gummerer wrote: > > On 03/22, Matheus Tavares wrote: > > From: Ævar Arnfjörð Bjarmason > > > > Add tests for what happens when we perform a local clone on a repo > > containing odd files at .git/object directory, such as symlinks to other > > dirs, or unknow

Re: [GSoC][PATCH v4 2/7] clone: better handle symlinked files at .git/objects/

2019-03-29 Thread Matheus Tavares Bernardino
On Thu, Mar 28, 2019 at 7:10 PM Thomas Gummerer wrote: > > On 03/22, Matheus Tavares wrote: > > There is currently an odd behaviour when locally clonning a repository > > with symlinks at .git/objects: using --no-hardlinks all symlinks are > > dereferenced but without it Git will try to hardlink t

Re: [GSoC][PATCH v4 1/7] clone: test for our behavior on odd objects/* content

2019-03-29 Thread Matheus Tavares Bernardino
On Fri, Mar 29, 2019 at 4:32 PM Thomas Gummerer wrote: > > On 03/29, Matheus Tavares Bernardino wrote: > > On Thu, Mar 28, 2019 at 6:49 PM Thomas Gummerer > > wrote: > > > When sending someone elses patch in a slightly modified version, it > > > may also be u

Re: [GSoC][PATCH v4 2/7] clone: better handle symlinked files at .git/objects/

2019-03-29 Thread Matheus Tavares Bernardino
On Fri, Mar 29, 2019 at 5:05 PM Thomas Gummerer wrote: > > On 03/29, Matheus Tavares Bernardino wrote: > > On Thu, Mar 28, 2019 at 7:10 PM Thomas Gummerer > > wrote: > > > I notice that we are currently not using 'linkat()' anywhere else in > >

Re: [GSoC][PATCH v4 2/7] clone: better handle symlinked files at .git/objects/

2019-03-31 Thread Matheus Tavares Bernardino
On Sat, Mar 30, 2019 at 4:27 PM Thomas Gummerer wrote: > > On 03/30, Matheus Tavares Bernardino wrote: > > On Fri, Mar 29, 2019 at 5:05 PM Thomas Gummerer > > wrote: > > > > > > On 03/29, Matheus Tavares Bernardino wrote: > > > > Ok, what if inste

Re: [GSoC][PATCH v5 2/7] clone: better handle symlinked files at .git/objects/

2019-03-31 Thread Matheus Tavares Bernardino
On Sun, Mar 31, 2019 at 2:40 PM Thomas Gummerer wrote: > > On 03/30, Matheus Tavares wrote: > > There is currently an odd behaviour when locally cloning a repository > > with symlinks at .git/objects: using --no-hardlinks all symlinks are > > dereferenced but without it, Git will try to hardlink t

Re: [GSoC][PATCH v5 0/7] clone: dir-iterator refactoring with tests

2019-04-01 Thread Matheus Tavares Bernardino
On Sun, Mar 31, 2019 at 3:16 PM Thomas Gummerer wrote: > > On 03/30, Matheus Tavares wrote: > > This patchset contains: > > - a replacement of explicit recursive dir iteration at > > copy_or_link_directory for the dir-iterator API; > > - some refactoring and behaviour changes at local clone, mai

Re: Make the git codebase thread-safe

2019-04-02 Thread Matheus Tavares Bernardino
On Mon, Apr 1, 2019 at 10:07 PM Duy Nguyen wrote: > > On Tue, Apr 2, 2019 at 7:52 AM Matheus Tavares > wrote: > > I downloaded chromium to give it a try and got (on a machine with i7 and > > SSD, running Manjaro Linux): > > > > - 17s on blame for a file with long history[2] > > - 2m on blame for

Re: Questions on GSoC 2019 Ideas

2019-04-03 Thread Matheus Tavares Bernardino
Hi, I've been studying the codebase and looking for older emails in the ML that discussed what I want to propose as my GSoC project. In particular, I found a thread about slow git commands on chromium, so I reached them out at chromium's ML to ask if it's still an issue. I got the following answer

Re: Questions on GSoC 2019 Ideas

2019-04-05 Thread Matheus Tavares Bernardino
On Thu, Apr 4, 2019 at 4:56 AM Christian Couder wrote: > > Hi, > > On Thu, Apr 4, 2019 at 3:15 AM Matheus Tavares Bernardino > wrote: > > > > I've been studying the codebase and looking for older emails in the ML > > that discussed what I want to propose as

[GSoC][RFC] Proposal: Make pack access code thread-safe

2019-04-07 Thread Matheus Tavares Bernardino
Thanks, Matheus Tavares === Making pack access code thread-safe April, 2019 #Contact Info Name Matheus Tavares Bernardino Timezone GMT-3 Email matheus.bernard...@usp.br IRC Nick matheustavares on #git-devel Telefone [...] Postal address [...] Github https://github.com/Matheu

Re: [GSoC][RFC] Proposal: Make pack access code thread-safe

2019-04-08 Thread Matheus Tavares Bernardino
On Mon, Apr 8, 2019 at 12:32 AM Duy Nguyen wrote: > > On Mon, Apr 8, 2019 at 8:23 AM Duy Nguyen wrote: > > > > On Mon, Apr 8, 2019 at 5:52 AM Christian Couder > > wrote: > > > > Git has a very optimized mechanism to compactly store > > > > objects (blobs, trees, commits, etc.) in packfiles[2]. T

Re: [GSoC][RFC] Proposal: Make pack access code thread-safe

2019-04-08 Thread Matheus Tavares Bernardino
On Mon, Apr 8, 2019 at 3:58 AM Christian Couder wrote: > > On Mon, Apr 8, 2019 at 5:32 AM Duy Nguyen wrote: > > > > On Mon, Apr 8, 2019 at 8:23 AM Duy Nguyen wrote: > > > > > > On Mon, Apr 8, 2019 at 5:52 AM Christian Couder > > > wrote: > > > > > Git has a very optimized mechanism to compactly

Re: [GSoC][RFC] Proposal: Make pack access code thread-safe

2019-04-08 Thread Matheus Tavares Bernardino
On Sun, Apr 7, 2019 at 7:52 PM Christian Couder wrote: > > Hi Matheus > > On Sun, Apr 7, 2019 at 10:48 PM Matheus Tavares Bernardino > wrote: > > > > This is my proposal for GSoC with the subject "Make pack access code > > thread-safe". > > Thank

Re: [GSoC][RFC] Proposal: Make pack access code thread-safe

2019-04-08 Thread Matheus Tavares Bernardino
On Mon, Apr 8, 2019 at 6:26 AM Philip Oakley wrote: > > On 08/04/2019 02:23, Duy Nguyen wrote: > > On Mon, Apr 8, 2019 at 5:52 AM Christian Couder > > wrote: > >>> Git has a very optimized mechanism to compactly store > >>> objects (blobs, trees, commits, etc.) in packfiles[2]. These files are >

Re: [GSoC][RFC] Proposal: Make pack access code thread-safe

2019-04-08 Thread Matheus Tavares Bernardino
On Mon, Apr 8, 2019 at 4:19 PM Philip Oakley wrote: > > Hi Matheus > > On 08/04/2019 18:04, Matheus Tavares Bernardino wrote: > >> Another "32-bit problem" should also be expressly considered during the > >> GSoC work because of the MS Windows definitio

Re: [GSoC][PATCH v5 3/7] dir-iterator: add flags parameter to dir_iterator_begin

2019-04-10 Thread Matheus Tavares Bernardino
Hi, Thomas Sorry for the late reply, but now that I submitted my GSoC proposal I can finally come back to this series. On Sun, Mar 31, 2019 at 3:12 PM Thomas Gummerer wrote: > > On 03/30, Matheus Tavares wrote: > > Add the possibility of giving flags to dir_iterator_begin to initialize > > a dir

Re: [GSoC][PATCH v5 3/7] dir-iterator: add flags parameter to dir_iterator_begin

2019-04-23 Thread Matheus Tavares Bernardino
On Thu, Apr 11, 2019 at 6:09 PM Thomas Gummerer wrote: > > On 04/10, Matheus Tavares Bernardino wrote: > > > > diff --git a/dir-iterator.h b/dir-iterator.h > > > > index 970793d07a..93646c3bea 100644 > > > > --- a/dir-iterator.h > > > > +++ b/

Re: [GSoC][PATCH v5 3/7] dir-iterator: add flags parameter to dir_iterator_begin

2019-04-25 Thread Matheus Tavares Bernardino
On Wed, Apr 24, 2019 at 3:36 PM Thomas Gummerer wrote: > > On 04/23, Matheus Tavares Bernardino wrote: > > On Thu, Apr 11, 2019 at 6:09 PM Thomas Gummerer > > wrote: > > > > > > On 04/10, Matheus Tavares Bernardino wrote: > > > >

Re: [GSoC] Some #leftoverbits for anyone looking for little projects

2019-05-20 Thread Matheus Tavares Bernardino
On Mon, May 20, 2019 at 8:49 PM Ævar Arnfjörð Bjarmason wrote: > > > On Mon, May 20 2019, Matheus Tavares wrote: > > > Hi, Ævar > > > >> Give "rebase -i" some option so when you "reword" the patch is > >> included in the message. > >> > >> I keep going to the shell because I have no idea what chan

[GSoC] How to protect cached_objects

2019-05-23 Thread Matheus Tavares Bernardino
Hi, everyone As one of my first tasks in GSoC, I'm looking to protect the global states at sha1-file.c for future parallelizations. Currently, I'm analyzing how to deal with the cached_objects array, which is a small set of in-memory objects that read_object_file() is able to return although they

Re: [GSoC] How to protect cached_objects

2019-05-25 Thread Matheus Tavares Bernardino
On Fri, May 24, 2019 at 3:13 AM Jeff King wrote: > > On Thu, May 23, 2019 at 01:51:47PM -0300, Matheus Tavares Bernardino wrote: > > > As one of my first tasks in GSoC, I'm looking to protect the global > > states at sha1-file.c for future parallelizations. Currently

Re: [GSoC] How to protect cached_objects

2019-05-25 Thread Matheus Tavares Bernardino
On Fri, May 24, 2019 at 6:55 AM Duy Nguyen wrote: > > On Thu, May 23, 2019 at 11:51 PM Matheus Tavares Bernardino > wrote: > > > > > Hi, everyone > > > > As one of my first tasks in GSoC, I'm looking to protect the global > > states at sha1-fil

Re: [GSoC] Some #leftoverbits for anyone looking for little projects

2019-05-28 Thread Matheus Tavares Bernardino
On Tue, May 28, 2019 at 7:37 AM Johannes Schindelin wrote: > > Hi Matheus, > > On Mon, 20 May 2019, Matheus Tavares wrote: > > > > Give "rebase -i" some option so when you "reword" the patch is > > > included in the message. > > > > > > I keep going to the shell because I have no idea what change

[GSoC][RFC] New approach: improve threading at git-grep

2019-06-10 Thread Matheus Tavares Bernardino
Hi, everyone I've been working on making the pack access code thread safe, as my GSoC project[1]. I was working directly at sha1-file.c global states targeting, in the far distance, to parallelize git-blame. But my mentors and I decided to take a different path, as a better way to continuous valid

Re: [GSoC][PATCH v7 00/10] clone: dir-iterator refactoring with tests

2019-06-18 Thread Matheus Tavares Bernardino
On Tue, Jun 18, 2019 at 8:28 PM Matheus Tavares wrote: > > This patchset contains: > - tests to the dir-iterator API; > - dir-iterator refactoring to make its state machine simpler > and feature adding with tests; > - a replacement of explicit recursive dir iteration at > copy_or_link_director

Re: [GSoC][PATCH v7 00/10] clone: dir-iterator refactoring with tests

2019-06-21 Thread Matheus Tavares Bernardino
On Thu, Jun 20, 2019 at 5:18 PM Junio C Hamano wrote: > > Matheus Tavares writes: > > > Daniel Ferreira (1): > > dir-iterator: add tests for dir-iterator API > > > > Matheus Tavares (8): > > clone: better handle symlinked files at .git/objects/ > > dir-iterator: use warning_errno when possi

Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-06-25 Thread Matheus Tavares Bernardino
On Tue, Jun 25, 2019 at 3:00 PM Junio C Hamano wrote: > > Matheus Tavares writes: > > This hunk, which claims to have 25 lines in the postimage ... > > > @@ -44,6 +45,25 @@ > > * dir_iterator_advance() again. > > */ > > > > +/* > > + * Flags for dir_iterator_begin: > > + * > > + * - DIR_ITERA

Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-06-27 Thread Matheus Tavares Bernardino
On Wed, Jun 26, 2019 at 3:04 PM Junio C Hamano wrote: > > Johannes Schindelin writes: > > > Hi Matheus, > > > > On Tue, 18 Jun 2019, Matheus Tavares wrote: > > > >>[...] > >> +/* > >> + * Look for a recursive symlink at iter->base.path pointing to any > >> directory on > >> + * the previous stac

Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-06-27 Thread Matheus Tavares Bernardino
On Thu, Jun 27, 2019 at 3:47 PM Johannes Schindelin wrote: > > Hi Matheus, > > On Thu, 27 Jun 2019, Matheus Tavares Bernardino wrote: > > > On Wed, Jun 26, 2019 at 3:04 PM Junio C Hamano wrote: > > > > > > Johannes Schindelin writes: > > > > &g

Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-06-28 Thread Matheus Tavares Bernardino
On Fri, Jun 28, 2019 at 9:50 AM Johannes Schindelin wrote: > > Hi Matheus, > > On Thu, 27 Jun 2019, Matheus Tavares Bernardino wrote: > > > On Thu, Jun 27, 2019 at 3:47 PM Johannes Schindelin > > wrote: > > > > > > On Thu, 27 Jun 2019, Matheus Tavare

[GSoC] My project blog

2019-07-02 Thread Matheus Tavares Bernardino
Hi, everyone I've been posting about the progress of my GSoC project at https://matheustavares.gitlab.io/gsoc/ I should have sent the link earlier but, please, let me know if you have any comments on my previous posts. You can read my latest update here: https://matheustavares.gitlab.io/posts/wee

Re: mt/dir-iterator-updates, was Re: What's cooking in git.git (Jul 2019, #01; Wed, 3)

2019-07-04 Thread Matheus Tavares Bernardino
Hi, Dscho On Thu, Jul 4, 2019 at 7:02 AM Johannes Schindelin wrote: > > Hi Junio, > > On Wed, 3 Jul 2019, Junio C Hamano wrote: > > > * mt/dir-iterator-updates (2019-06-25) 10 commits [...] > > Is this ready for 'next'? > > No. It still breaks many dozens of test cases on Windows (if not more) >

Re: mt/dir-iterator-updates, was Re: What's cooking in git.git (Jul 2019, #01; Wed, 3)

2019-07-05 Thread Matheus Tavares Bernardino
On Thu, Jul 4, 2019 at 6:30 PM Johannes Schindelin wrote: > > Hi Matheus, > > On Thu, 4 Jul 2019, Matheus Tavares Bernardino wrote: > > > > I wanted to take a look at the failures to see if I could help, [...] > > Could you point me to the right place, please? [.

Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-07-08 Thread Matheus Tavares Bernardino
Thanks for the review. I'll address those issues in v8. Best, Matheus On Wed, Jul 3, 2019 at 5:57 AM SZEDER Gábor wrote: > > > diff --git a/t/t0066-dir-iterator.sh b/t/t0066-dir-iterator.sh > > index c739ed7911..8f996a31fa 100755 > > --- a/t/t0066-dir-iterator.sh > > +++ b/t/t0066-dir-iterator.

Re: mt/dir-iterator-updates, was Re: What's cooking in git.git (Jul 2019, #01; Wed, 3)

2019-07-08 Thread Matheus Tavares Bernardino
On Fri, Jul 5, 2019 at 3:17 PM Johannes Schindelin wrote: > > Hi Matheus, > > On Fri, 5 Jul 2019, Matheus Tavares Bernardino wrote: > > > > So, should I send a fixup patch removing find_recursive_symlinks() or > > reroll the series? There's also the option

Re: Weird behavior with git grep --recurse-submodules

2019-07-09 Thread Matheus Tavares Bernardino
On Mon, Jul 8, 2019 at 5:22 AM Daniel Zaoui wrote: > > Hi guys, Hi, Daniel > I work with submodules and use git grep a lot. > > I noted that when it is invoked used with --recurse-submodules, the result is > not as expected for the submodules. I get submodules results as if no files > were mod

Re: What's cooking in git.git (Jul 2019, #02; Tue, 9)

2019-07-10 Thread Matheus Tavares Bernardino
On Wed, Jul 10, 2019 at 3:58 PM Junio C Hamano wrote: > > Johannes Schindelin writes: > > > Hi Junio, > > > > On Tue, 9 Jul 2019, Junio C Hamano wrote: > > > >> * mt/dir-iterator-updates (2019-06-25) 10 commits > >> - clone: replace strcmp by fspathcmp > >> - clone: use dir-iterator to avoid ex

Re: [GSoC][PATCH v8 00/10] clone: dir-iterator refactoring with tests

2019-07-11 Thread Matheus Tavares Bernardino
On Thu, Jul 11, 2019 at 8:56 AM Johannes Schindelin wrote: > > Hi Matheus, > > On Wed, 10 Jul 2019, Matheus Tavares wrote: > > > - a replacement of explicit recursive dir iteration at > > copy_or_link_directory for the dir-iterator API; > > As far as I can see, it was not replaced, but just drop

Re: [GSoC] My project blog

2019-07-14 Thread Matheus Tavares Bernardino
Hi, everyone I just posted a new update about my GSoC project here: https://matheustavares.gitlab.io/posts/week-8-a-working-parallel-inflation Please, feel free to leave any comments. I've finally solved the race condition problem and now we have a working parallel inflation :) But there's still s

Re: [GSoC] My project blog

2019-07-14 Thread Matheus Tavares Bernardino
On Sun, Jul 14, 2019 at 8:00 AM Christian Couder wrote: > > Hi Matheus, > > On Sun, Jul 14, 2019 at 9:38 AM Matheus Tavares Bernardino > wrote: > > > > I just posted a new update about my GSoC project here: > > https://matheustavares.gitlab.io/posts/week-8-a-work

Re: [GSoC] My project blog

2019-07-22 Thread Matheus Tavares Bernardino
Hi, everyone Unfortunately, not quite much to report this week :( I'm attending DebConf until July 28th but I'm trying to conciliate that with the work on my project. You can see my brief report of last week here: https://matheustavares.gitlab.io/posts/week-9-an-rfc-on-parallel-inflation As alway

Re: Weird behavior with git grep --recurse-submodules

2019-07-29 Thread Matheus Tavares Bernardino
On Tue, Jul 16, 2019 at 3:09 PM Daniel Zaoui wrote: > > Hi Matheus, Hi, Daniel I'm sorry, your last message went to my spam folder for some reason :( > Thank you for your response. > > I really hope the change Brandon made is not a project decision. At least, it > does seem to me like a bug. >

Re: [GSoC] My project blog

2019-07-29 Thread Matheus Tavares Bernardino
Hi, everyone I just posted an update about my project here: https://matheustavares.gitlab.io/posts/week-10-a-bug-in-git-grep-submodules This one is focused on a patch to correct a bug at git-grep --recurse-submodules and some tests for the parallel inflation patchset. Please, feel free to leave an

Re: [ANNOUNCE] Git v2.23.0-rc0 - Initial test failures on NonStop

2019-07-30 Thread Matheus Tavares Bernardino
Hi, Junio and Randall On Tue, Jul 30, 2019 at 2:31 PM Junio C Hamano wrote: > > "Randall S. Becker" writes: > > > t0066: dir-iterator > > > > Subtest 4 depends on a non-portable error code. ENOENT is not guaranteed ... > > Subtest 5 also depends on a non-portable error code. ENOTDIR is not gua..

Re: [GSoC][PATCH] grep: fix worktree case in submodules

2019-07-30 Thread Matheus Tavares Bernardino
On Tue, Jul 30, 2019 at 5:04 PM Junio C Hamano wrote: > > Matheus Tavares writes: > > > @@ -475,7 +475,7 @@ static int grep_submodule(struct grep_opt *opt, > > strbuf_release(&base); > > free(data); > > } else { > > - hit = grep_cache(&subopt, pathspe

Re: [GSoC][PATCH] grep: fix worktree case in submodules

2019-07-31 Thread Matheus Tavares Bernardino
On Wed, Jul 31, 2019 at 12:57 PM Junio C Hamano wrote: > > Christian Couder writes: > > > On Tue, Jul 30, 2019 at 10:04 PM Junio C Hamano wrote: > >> > >> Matheus Tavares writes: > > > >> > @@ -598,7 +599,8 @@ static int grep_tree(struct grep_opt *opt, const > >> > struct pathspec *pathspec, >

Re: [GSoC] My project blog

2019-08-05 Thread Matheus Tavares Bernardino
Hi, Here's my report from last week: https://matheustavares.gitlab.io/posts/week-11-wip-grep-protecting-textconv-and-submodules I'm working to protect the operations I left behind on the first version of the patchset[1]. And for that, I used a lot of the code Duy provided[2] me as an example in th

[GSoC] Microproject on git-credential-cache

2019-02-11 Thread Matheus Tavares Bernardino
Hi, everyone I've been contributing to the Linux Kernel for the past semester and I'm now looking to take my first steps in the git community. I'm also interested in GSoC 2019. I started looking at https://git.github.io/SoC-2019-Microprojects/ and one that got my attention was "Move ~/.git-creden

Re: [GSoC] Microproject on git-credential-cache

2019-02-11 Thread Matheus Tavares Bernardino
On Mon, Feb 11, 2019 at 10:00 PM Jeff King wrote: > > On Mon, Feb 11, 2019 at 09:45:21PM -0200, Matheus Tavares Bernardino wrote: > > > I've been contributing to the Linux Kernel for the past semester and > > I'm now looking to take my first steps in the git commun

Re: [GSoC] Microproject on git-credential-cache

2019-02-11 Thread Matheus Tavares Bernardino
On Mon, Feb 11, 2019 at 10:09 PM Christian Couder wrote: > > Hi, > > On Tue, Feb 12, 2019 at 12:48 AM Matheus Tavares Bernardino > wrote: > > > > Hi, everyone > > > > I've been contributing to the Linux Kernel for the past semester and > >

Re: [GSoC][RFC PATCH] clone: use dir-iterator to avoid explicit dir traversal

2019-02-14 Thread Matheus Tavares Bernardino
On Thu, Feb 14, 2019 at 7:16 PM Christian Couder wrote: > > On Thu, Feb 14, 2019 at 1:16 PM Matheus Tavares > wrote: > > > > Replace usage of opendir/readdir/closedir API to traverse directories > > recursively, at copy_or_link_directory function, by the dir-iterator > > API. > > > > Signed-off-b

Re: [GSoC][PATCH 2/2] clone: use dir-iterator to avoid explicit dir traversal

2019-02-18 Thread Matheus Tavares Bernardino
On Sat, Feb 16, 2019 at 12:38 PM Thomas Gummerer wrote: > > On 02/15, Matheus Tavares wrote: > > Replace usage of opendir/readdir/closedir API to traverse directories > > recursively, at copy_or_link_directory function, by the dir-iterator > > API. > > > > Signed-off-by: Matheus Tavares > > --- >

Re: [GSoC][PATCH 1/2] clone: extract function from copy_or_link_directory

2019-02-18 Thread Matheus Tavares Bernardino
On Sat, Feb 16, 2019 at 4:23 AM Christian Couder wrote: > > On Fri, Feb 15, 2019 at 5:39 PM Matheus Tavares > wrote: > > > > Extract dir creation code snippet from copy_or_link_directory to its own > > function named mkdir_if_missing. This change will help removing > > copy_or_link_directory's ex

Re: [GSoC][PATCH 2/2] clone: use dir-iterator to avoid explicit dir traversal

2019-02-19 Thread Matheus Tavares Bernardino
On Mon, Feb 18, 2019 at 8:35 PM Thomas Gummerer wrote: > > > > > You are right. I didn't know the differences from lstat and stat. And > > reflecting on this now, I realize that the problem is even deeper: > > copy_or_link_directory follows symlinks but dir-iterator don't, so I > > cannot use dir-

Re: [GSoC][PATCH 2/2] clone: use dir-iterator to avoid explicit dir traversal

2019-02-20 Thread Matheus Tavares Bernardino
Ok, I think I'm almost there and I should be able to send a v2 on the weekend. But again, a few questions arose while I'm coding v2. Please, see inline. On Tue, Feb 19, 2019 at 8:45 PM Thomas Gummerer wrote: > > On 02/19, Matheus Tavares Bernardino wrote: > >

Re: [GSoC][PATCH 0/3] clone: convert explicit dir traversal to dir-iterator

2019-02-23 Thread Matheus Tavares Bernardino
On Sat, Feb 23, 2019 at 4:03 PM Matheus Tavares wrote: > > Add pedantic option to dir_iterator_begin at dir-iterator.c and convert > explicit recursive directory traversal at copy_or_link_directory > (builtin/clone.c) to the dir-iterator API. > > This is my microproject for GSoC 2019. Idea taken f

Re: [GSoC][PATCH 0/3] clone: convert explicit dir traversal to dir-iterator

2019-02-24 Thread Matheus Tavares Bernardino
On Sat, Feb 23, 2019 at 6:59 PM Thomas Gummerer wrote: > > On 02/23, Matheus Tavares wrote: > > Add pedantic option to dir_iterator_begin at dir-iterator.c and convert > > explicit recursive directory traversal at copy_or_link_directory > > (builtin/clone.c) to the dir-iterator API. > > Thanks for

Re: [GSoC][PATCH 1/3] dir-iterator: add pedantic option to dir_iterator_begin

2019-02-24 Thread Matheus Tavares Bernardino
On Sun, Feb 24, 2019 at 5:35 AM Christian Couder wrote: > > On Sat, Feb 23, 2019 at 10:37 PM Thomas Gummerer wrote: > > > > On 02/23, Matheus Tavares wrote: > > > Add the pedantic option to dir-iterator's initialization function, > > > dir_iterator_begin. When this option is set to true, > > > di

Re: [GSoC][PATCH 3/3] clone: use dir-iterator to avoid explicit dir traversal

2019-02-24 Thread Matheus Tavares Bernardino
On Sat, Feb 23, 2019 at 6:48 PM Thomas Gummerer wrote: > > On 02/23, Matheus Tavares wrote: > > --- > > Changes in v2: > > - Improved patch message > > - Removed a now unused variable > > s/variable/parameter/ I believe? Yes, you are right! > > + while ((iter_status = dir_iterator_advance(

Re: [GSoC][PATCH 3/3] clone: use dir-iterator to avoid explicit dir traversal

2019-02-24 Thread Matheus Tavares Bernardino
Hi, Christian and Ævar First of all, thanks for the fast and attentive reviews. I am a little confused about what I should do next. How should I proceed with this series? By what was said, I understood that the series: 1) Is indeed an improvement under --local, because it won't deference symlink

Re: [WIP RFC PATCH 2/7] dir-iterator: use stat() instead of lstat()

2019-02-25 Thread Matheus Tavares Bernardino
On Mon, Feb 25, 2019 at 9:26 PM Ævar Arnfjörð Bjarmason wrote: > > This is surely a horrible idea, but all tests pass with this (not that > I trust them much). Doing this for later WIP use in clone.c. > > Signed-off-by: Ævar Arnfjörð Bjarmason > --- > dir-iterator.c | 2 +- > 1 file changed, 1 i

Re: [WIP RFC PATCH 5/7] clone: use dir-iterator to avoid explicit dir traversal

2019-02-25 Thread Matheus Tavares Bernardino
On Mon, Feb 25, 2019 at 9:26 PM Ævar Arnfjörð Bjarmason wrote: > > From: Matheus Tavares > > Replace usage of opendir/readdir/closedir API to traverse directories > recursively, at copy_or_link_directory function, by the dir-iterator > API. This simplifies the code and avoid recursive calls to >

Re: [RFC PATCH v3 0/5] clone: dir iterator refactoring with tests

2019-02-26 Thread Matheus Tavares Bernardino
Hi, Ævar Thank you for helping me out on this series and, especially, for the tests part. Now that we've come to a consensus on what the overall series' "shape" should be, can I refine what's still needed and resubmit it, in the upcoming days, as a patch set with the test included? Best, Matheus

Re: [WIP RFC PATCH v2 1/5] dir-iterator: add flags parameter to dir_iterator_begin

2019-02-27 Thread Matheus Tavares Bernardino
On Tue, Feb 26, 2019 at 9:02 AM Duy Nguyen wrote: > > On Tue, Feb 26, 2019 at 12:18 PM Matheus Tavares > wrote: > > int dir_iterator_advance(struct dir_iterator *dir_iterator) > > { > > struct dir_iterator_int *iter = > > (struct dir_iterator_int *)dir_iterator; > > +

Re: [WIP RFC PATCH v2 4/5] clone: extract function from copy_or_link_directory

2019-02-27 Thread Matheus Tavares Bernardino
On Tue, Feb 26, 2019 at 9:18 AM Duy Nguyen wrote: > > On Tue, Feb 26, 2019 at 12:18 PM Matheus Tavares > wrote: > > > > Extract dir creation code snippet from copy_or_link_directory to its own > > function named mkdir_if_missing. This change will help removing > > copy_or_link_directory's explici

Re: [WIP RFC PATCH v2 5/5] clone: use dir-iterator to avoid explicit dir traversal

2019-02-27 Thread Matheus Tavares Bernardino
On Tue, Feb 26, 2019 at 9:32 AM Duy Nguyen wrote: > > On Tue, Feb 26, 2019 at 12:18 PM Matheus Tavares > wrote: > > > > Replace usage of opendir/readdir/closedir API to traverse directories > > recursively, at copy_or_link_directory function, by the dir-iterator > > API. This simplifies the code

Re: [WIP RFC PATCH v2 4/5] clone: extract function from copy_or_link_directory

2019-02-27 Thread Matheus Tavares Bernardino
On Wed, Feb 27, 2019 at 7:45 PM Thomas Gummerer wrote: > > On 02/27, Matheus Tavares Bernardino wrote: > > On Tue, Feb 26, 2019 at 9:18 AM Duy Nguyen wrote: > > > > > > On Tue, Feb 26, 2019 at 12:18 PM Matheus Tavares > > > wrote: > > &

Re: [RFC PATCH v3 1/5] clone: test for our behavior on odd objects/* content

2019-02-28 Thread Matheus Tavares Bernardino
Hi, Ævar I'm finishing the required changes in this series to send a v4, but when submitting to travis ci, I got some errors on the t5604-clone-reference test: https://travis-ci.org/MatheusBernardino/git/builds/57587 Do you have any idea why? Best, Matheus Tavares On Tue, Feb 26, 2019 at 9:

Questions on GSoC 2019 Ideas

2019-02-28 Thread Matheus Tavares Bernardino
Hi, everyone I've been in the mailing list for a couple weeks now, mainly working on my gsoc micro-project[1] and in other patches that derived from it. I also have been contributing to the Linux Kernel for half an year, but am now mainly just supporting other students here at USP. I have read th

Re: Questions on GSoC 2019 Ideas

2019-03-05 Thread Matheus Tavares Bernardino
First of all, I must apologize for not replying during these last days. I'm traveling and I rarely get a connection here. But I'll be back March 11th. On Sun, Mar 3, 2019 at 4:18 AM Christian Couder wrote: > > On Sat, Mar 2, 2019 at 4:09 PM Thomas Gummerer wrote: > > > > I'm a bit wary of a too

Re: Questions on GSoC 2019 Ideas

2019-03-05 Thread Matheus Tavares Bernardino
This exercise of estimating a good spot to gain performance with parallelism at git seems more difficult than I thought, firstly. Also, I'm not that familiar yet with git packing (neither with the sections of it that could benefit from parallelism). So could anyone point me some good references on

Re: Questions on GSoC 2019 Ideas

2019-03-11 Thread Matheus Tavares Bernardino
On Wed, Mar 6, 2019 at 7:17 AM Duy Nguyen wrote: > > On Wed, Mar 6, 2019 at 6:47 AM Matheus Tavares Bernardino > wrote: > > > > This exercise of estimating a good spot to gain performance with > > parallelism at git seems more difficult than I thought, firstly. Also

Re: [GSoC][PATCH v4 1/7] clone: test for our behavior on odd objects/* content

2019-03-24 Thread Matheus Tavares Bernardino
On Fri, Mar 22, 2019 at 8:22 PM Matheus Tavares wrote: > > From: Ævar Arnfjörð Bjarmason > > Add tests for what happens when we perform a local clone on a repo > containing odd files at .git/object directory, such as symlinks to other > dirs, or unknown files. > > I'm bending over backwards here

Re: [GSoC][PATCH v4 1/7] clone: test for our behavior on odd objects/* content

2019-03-26 Thread Matheus Tavares Bernardino
On Sun, Mar 24, 2019 at 5:56 PM SZEDER Gábor wrote: > > On Fri, Mar 22, 2019 at 08:22:31PM -0300, Matheus Tavares wrote: > > From: Ævar Arnfjörð Bjarmason > > > > Add tests for what happens when we perform a local clone on a repo > > containing odd files at .git/object directory, such as symlinks

Re: [GSoC] My project blog

2019-08-08 Thread Matheus Tavares Bernardino
On Tue, Aug 6, 2019 at 4:16 AM Christian Couder wrote: > > Hi Matheus, > > On Tue, Aug 6, 2019 at 4:54 AM Matheus Tavares Bernardino > wrote: > > > > Here's my report from last week: > > https://matheustavares.gitlab.io/posts/week-11-wip-grep-protecting-tex

Re: [GSoC] My project blog

2019-08-12 Thread Matheus Tavares Bernardino
Hi, everyone I just posted a new update on my project: https://matheustavares.gitlab.io/posts/simplified-version-of-parallel-inflation This week I sent a simplified version of the series I was working on last week (which would still take some time to finish). And I'm working to improve it with su

Re: What's cooking in git.git (Aug 2019, #04; Wed, 14)

2019-08-14 Thread Matheus Tavares Bernardino
Hi, Junio On Wed, Aug 14, 2019 at 6:27 PM Junio C Hamano wrote: > [...] > * mt/grep-submodules-working-tree (2019-07-30) 1 commit > (merged to 'next' on 2019-08-02 at e1a46a195f) > + grep: fix worktree case in submodules There is a new version of this patch here[1], addressing the comments yo

Re: What's cooking in git.git (Aug 2019, #04; Wed, 14)

2019-08-15 Thread Matheus Tavares Bernardino
On Thu, Aug 15, 2019 at 1:57 PM Junio C Hamano wrote: > > Carlo Arenas writes: > > > On Wed, Aug 14, 2019 at 4:58 PM Matheus Tavares Bernardino > > wrote: > >> > >> On Wed, Aug 14, 2019 at 6:27 PM Junio C Hamano wrote: > >> > > >> [

Re: [GSoC] My project blog

2019-08-19 Thread Matheus Tavares Bernardino
Hi, everyone I just posted the penultimate report on my project: https://matheustavares.gitlab.io/posts/going-for-a-too-big-step This week I’ve been working on a v2 of threaded git-grep w/ parallel inflation, to allow threads when grepping submodules. I also tried some more optimizations along the

Re: [GSoC] My project blog

2019-08-20 Thread Matheus Tavares Bernardino
On Tue, Aug 20, 2019 at 9:16 AM Christian Couder wrote: > > Hi Matheus, > > On Tue, Aug 20, 2019 at 1:28 PM Olga Telezhnaya > wrote: > > > > вт, 20 авг. 2019 г. в 07:59, Matheus Tavares Bernardino > > : > > > > > > I just poste

Re: [GSoC] My project blog

2019-08-26 Thread Matheus Tavares Bernardino
Hi, everyone Just wanted to share with you the final report on my GSoC project: https://matheustavares.gitlab.io/posts/gsoc-final-report I plan to continue the project (as it isn't finished yet) and keep contributing with whatever I can :) Thank you all for the support during this SoC! Best, Mat

Re: How to build to debug with gdb?

2019-08-27 Thread Matheus Tavares Bernardino
On Tue, Aug 27, 2019 at 1:27 PM Giuseppe Crino' wrote: > > Hello, to debug some issues I built and installed git via > > $ make prefix=/usr/local DEVELOPER=1 CFLAGS="-O0 -g" > $ sudo make install > $ git --version # git version 2.23.0.40.g4d8aada92f Hmm, could it be perhaps that CFLAGS is being o

Re: [PATCH 1/2] config: allow config_with_options() to handle any repo

2019-08-27 Thread Matheus Tavares Bernardino
Hi, Duy On Tue, Aug 27, 2019 at 6:26 AM Duy Nguyen wrote: > > On Tue, Aug 27, 2019 at 6:57 AM Matheus Tavares > wrote: > > > > Currently, config_with_options() relies on the global the_repository > > when it has to configure from a blob. > > Not really reading the patch, but my last experience w

Re: [PATCH 1/2] config: allow config_with_options() to handle any repo

2019-08-28 Thread Matheus Tavares Bernardino
On Tue, Aug 27, 2019 at 8:46 PM Matheus Tavares Bernardino wrote: > > Hi, Duy > > On Tue, Aug 27, 2019 at 6:26 AM Duy Nguyen wrote: > > > > On Tue, Aug 27, 2019 at 6:57 AM Matheus Tavares > > wrote: > > > > > > Currently, config_with_options() r

Re: [PATCH 1/2] config: allow config_with_options() to handle any repo

2019-08-29 Thread Matheus Tavares Bernardino
On Thu, Aug 29, 2019 at 11:00 AM Jeff King wrote: > > On Thu, Aug 29, 2019 at 04:31:34PM +0700, Duy Nguyen wrote: > > > > If so, how could we get R there? I mean, we could pass it through this > > > chain, but the chain already passes a "struct config_options", which > > > carries the "commondir"

[RFC] Post/tutorial for newcomers

2019-09-02 Thread Matheus Tavares Bernardino
Hi, everyone I've been writing a blog post based on what I learned during GSoC to help other students here at FLUSP[1] start contributing as well. In the meantime `Documentation/MyFirstContribution.txt` was released, so I've pointed my interested colleagues to it. But since I was already pretty c

Re: [RFC] Post/tutorial for newcomers

2019-09-03 Thread Matheus Tavares Bernardino
On Tue, Sep 3, 2019 at 4:49 AM Olga Telezhnaya wrote: > > вт, 3 сент. 2019 г. в 05:32, Matheus Tavares Bernardino > : > > > > Here is the end result: > > https://matheustavares.gitlab.io/posts/first-steps-contributing-to-git > > If you have any comments or sugges

Re: [RFC] Post/tutorial for newcomers

2019-09-03 Thread Matheus Tavares Bernardino
added to the "Contributing to Git" section. > Thanks, > Pedro > > > Matheus Tavares Bernardino escreveu no dia > terça, 3/09/2019 à(s) 03:34: > > > > Hi, everyone > > > > I've been writing a blog post based on what I learned during GSoC to &

Re: What's cooking in git.git (Sep 2019, #01; Sat, 7)

2019-09-10 Thread Matheus Tavares Bernardino
Hi, Junio On Sat, Sep 7, 2019 at 2:27 PM Junio C Hamano wrote: > > * mt/threaded-grep-in-object-store (2019-08-13) 4 commits > - grep: re-enable threads in some non-worktree cases > - grep: disable grep_read_mutex when possible > - grep: allow locks to be enabled individually > - object-store

Re: [RFC PATCH 0/3] grep: don't add subrepos to in-memory alternates

2019-09-18 Thread Matheus Tavares Bernardino
On Wed, Sep 18, 2019 at 4:55 PM Junio C Hamano wrote: > > Matheus Tavares writes: > [...] > > - textconv cache is written to the_repository's object database even for > > submodules. Should it perhaps be written to submodules' odb instead? > > You mention "is written", but that is what happens

Re: [RFC PATCH 0/3] grep: don't add subrepos to in-memory alternates

2019-09-21 Thread Matheus Tavares Bernardino
On Fri, Sep 20, 2019 at 1:26 PM Junio C Hamano wrote: > > Matheus Tavares Bernardino writes: > > > Hmm, I may have gotten a little confused here. Are you talking > > about the attributes stack (which contains .gitattributes and > > info/attributes)? If so, isn'

Re: [RFC PATCH 0/3] grep: don't add subrepos to in-memory alternates

2019-09-27 Thread Matheus Tavares Bernardino
On Sat, Sep 28, 2019 at 12:24 AM Junio C Hamano wrote: > > Matheus Tavares Bernardino writes: > > > Right, this would be the best way of doing it. However, I think this > > is not how it's currently implemented. I if correctly understood the &

git-grep in sparse checkout

2019-10-01 Thread Matheus Tavares Bernardino
Hi, During Git Summit it was mentioned that git-grep searches outside sparsity pattern which is not aligned with user expectation. I took a quick look at it and it seems the reason is builtin/grep.c:grep_cache() (which also greps worktree) will grep the object store when a given index entry has th

Re: git-grep in sparse checkout

2019-10-01 Thread Matheus Tavares Bernardino
On Tue, Oct 1, 2019 at 3:29 PM Derrick Stolee wrote: > > On 10/1/2019 9:06 AM, Matheus Tavares Bernardino wrote: > > Hi, > > > > During Git Summit it was mentioned that git-grep searches outside > > sparsity pattern which is not aligned with user expectation. I took

Re: [RFC WIP PATCH 1/3] tag: factor out tag reading from write_tag_body()

2019-10-08 Thread Matheus Tavares Bernardino
On Tue, Oct 8, 2019 at 3:47 PM Lucas Oshiro wrote: > > Improve code readability by moving tag reading to a new function called > get_tag_body, which will be used in the implementation of the git tag > --amend functionality. This function is also used in your third patch, to fix git-tag's --no-edi

Re: [RFC WIP PATCH 2/3] tag: factor out prepare tag template code

2019-10-08 Thread Matheus Tavares Bernardino
On Tue, Oct 8, 2019 at 3:47 PM Lucas Oshiro wrote: > > Improve code readability by moving tag body reading to a new function called > get_tag_body. This function will be used in the following patches to fix the > --no-edit flag. This seems to be accidentally duplicated from patch 1/3. > Enhance

Re: [RFC WIP PATCH 3/3] tag: add full support for --edit and --no-edit

2019-10-09 Thread Matheus Tavares Bernardino
On Tue, Oct 8, 2019 at 3:47 PM Lucas Oshiro wrote: > > git tag --edit and --no-edit flags are not currently fully supported. > This patch fixes the functionality that allows the editor to be opened > on demand. > > Co-authored-by: Bárbara Fernandes > Signed-off-by: Lucas Oshiro > Signed-off-by:

[GSoC] Follow-up post

2019-10-21 Thread Matheus Tavares Bernardino
Hi, everyone I wrote a small follow-up post to talk about the conclusion of my GSoC project. I believe the main remaining tasks are now finally complete :) If you would be interested in taking a look, the post is at https://matheustavares.gitlab.io/posts/gsoc-follow-ups Thanks, Matheus

  1   2   >