[GSoC][PATCH v4 2/5] t0000: avoid using pipes

n for counting the lines in the output. These simplifications will be made in subsequent commits. Signed-off-by: Jonathan Chang --- t/t-basic.sh | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/t/t-basic.sh b/t/t-basic.sh index 53821

[GSoC][PATCH v4 4/5] t0000: use test_cmp instead of "test" builtin

Signed-off-by: Jonathan Chang --- t/t-basic.sh | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/t/t-basic.sh b/t/t-basic.sh index 3de13daabe..49923c5ff1 100755 --- a/t/t-basic.sh +++ b/t/t-basic.sh @@ -1118,16 +1118,18 @@ P=$(test_oid root

[GSoC][PATCH v4 0/5] Avoid using pipes

/ [v3]: https://public-inbox.org/git/cover.1552835153.git.ttjt...@gmail.com/ [1]: https://public-inbox.org/git/87imwha1o3@evledraar.gmail.com/ [2]: https://public-inbox.org/git/20190317200609.ga1...@hank.intra.tgummerer.com/ Jonathan Chang (5): t: fix indentation t: avoid using

[GSoC][PATCH v4 1/5] t0000: fix indentation

Fix indentation of a line containing a pipeline to reduce the noise when refactoring the pipeline in a subsequent commit. This has been wrong since the refactoring done in 1b5b2b641a ("t: modernise style", 2012-03-02), but carries no meaning. Signed-off-by: Jonathan Chang --

[GSoC][PATCH v4 5/5] t0000: make use of the test_must_be_empty function

Signed-off-by: Jonathan Chang --- t/t-basic.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t-basic.sh b/t/t-basic.sh index 49923c5ff1..0cb69a89de 100755 --- a/t/t-basic.sh +++ b/t/t-basic.sh @@ -51,7 +51,7 @@ test_expect_success 'verify tha

[GSoC][PATCH v4 3/5] t0000: use test_line_count instead of wc -l

Signed-off-by: Jonathan Chang --- t/t-basic.sh | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/t/t-basic.sh b/t/t-basic.sh index 47666b013e..3de13daabe 100755 --- a/t/t-basic.sh +++ b/t/t-basic.sh @@ -1136,8 +1136,8 @@ test_expect_success 

Re: [GSoC][PATCH v4 4/5] t0000: use test_cmp instead of "test" builtin

On Sun, Mar 31, 2019 at 3:38 AM Thomas Gummerer wrote: > > On 03/30, Jonathan Chang wrote: > > Signed-off-by: Jonathan Chang > > --- > > t/t-basic.sh | 14 -- > > 1 file changed, 8 insertions(+), 6 deletions(-) > > > > diff --git a/t/t

[GSoC][PATCH] tests: avoid using pipes

using it. By writing out the output of the git command to a file, we can test the exit codes of both the commands. Signed-off-by: Jonathan Chang --- t/t-basic.sh | 28 ++-- t/t0003-attributes.sh | 13 - t/t0022-crlf-rename.sh | 6 +++--- 3 files c

[GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error

discards git's exit code and may mask a crash. Signed-off-by: Jonathan Chang diff --git a/t/t-basic.sh b/t/t-basic.sh index b6566003dd..53821f5817 100755 --- a/t/t-basic.sh +++ b/t/t-basic.sh @@ -1132,7 +1132,7 @@ test_expect_success 'git commit-t

[GSoC][PATCH v2 2/5] t0000-basic: avoid using pipes

The exit code of the upstream in a pipe is ignored thus we should avoid using it. By writing out the output of the git command to a file, we can test the exit codes of both the commands. Signed-off-by: Jonathan Chang diff --git a/t/t-basic.sh b/t/t-basic.sh index 53821f5817..47666b013e

[GSoC][PATCH v2 3/5] t0003-attributes: avoid using pipes

The exit code of the upstream in a pipe is ignored thus we should avoid using it. By writing out the output of the git command to a file, we can test the exit codes of both the commands. Signed-off-by: Jonathan Chang diff --git a/t/t0003-attributes.sh b/t/t0003-attributes.sh index 71e63d8b50

[GSoC][PATCH v2 4/5] t0022-crlf-rename: avoid using pipes

The exit code of the upstream in a pipe is ignored thus we should avoid using it. By writing out the output of the git command to a file, we can test the exit codes of both the commands. Signed-off-by: Jonathan Chang diff --git a/t/t0022-crlf-rename.sh b/t/t0022-crlf-rename.sh index 7af3fbcc7b

[GSoC][PATCH v2 5/5] t0000-basic: use test_line_count instead of wc -l

Signed-off-by: Jonathan Chang diff --git a/t/t-basic.sh b/t/t-basic.sh index 47666b013e..aa25694b45 100755 --- a/t/t-basic.sh +++ b/t/t-basic.sh @@ -1136,8 +1136,8 @@ test_expect_success 'git commit-tree omits duplicated parent in a commit' ' parent

Fwd: [GSoC][PATCH] tests: avoid using pipes

Sorry, I forgot to Cc, again. -- Forwarded message - From: ttjtftx Date: Tue, Mar 12, 2019 at 12:32 AM Subject: Re: [GSoC][PATCH] tests: avoid using pipes To: Christian Couder On Sun, Mar 10, 2019 at 11:05 PM Christian Couder wrote: > > On Sun, Mar 10, 2019 at 9:28 AM ttjtftx

Re: [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error

On Mon, Mar 11, 2019 at 1:59 AM Thomas Gummerer wrote: > > On 03/10, Jonathan Chang wrote: > > Hi, > > > > Thanks for the reviews. > > > > Here are the changes in the second version: > > - bug fixes > > - add preparatory patch > &g

Re: [GSoC][PATCH v2 3/5] t0003-attributes: avoid using pipes

On Sun, Mar 10, 2019 at 6:13 PM Eric Sunshine wrote: > > On Sun, Mar 10, 2019 at 4:09 AM Jonathan Chang wrote: > > The exit code of the upstream in a pipe is ignored thus we should avoid > > using it. By writing out the output of the git command to a file, we can > > tes

[GSoC][PATCH v3 1/3] t0000: fix indentation

Fix indentation of a line containing a pipeline to reduce the noise when refactoring the pipeline in a subsequent commit. This has been wrong since the refactoring done in 1b5b2b641a ("t: modernise style", 2012-03-02), but carries no meaning. Signed-off-by: Jonathan Chang --

[GSoC][PATCH v3 2/3] t0000: avoid using pipes

The exit code of the upstream in a pipe is ignored thus we should avoid using it. By writing out the output of the git command to a file, we can test the exit codes of both the commands. Signed-off-by: Jonathan Chang --- t/t-basic.sh | 28 ++-- 1 file changed, 14

[GSoC][PATCH v3 3/3] t0000: use test_line_count instead of wc -l

Signed-off-by: Jonathan Chang --- t/t-basic.sh | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/t/t-basic.sh b/t/t-basic.sh index 47666b013e..3de13daabe 100755 --- a/t/t-basic.sh +++ b/t/t-basic.sh @@ -1136,8 +1136,8 @@ test_expect_success 

[GSoC][PATCH v3 0/3] Avoid using pipes

csmzrqfrlxoo5ke1uonuxmnyhikr-e6gaq_n6vx3+s...@mail.gmail.com/ Jonathan Chang (3): t: fix indentation t: avoid using pipes t: use test_line_count instead of wc -l t/t-basic.sh | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) Range-diff aga

Re: [GSoC][PATCH v3 2/3] t0000: avoid using pipes

On Mon, Mar 18, 2019 at 12:47 AM Ævar Arnfjörð Bjarmason wrote: > > > On Sun, Mar 17 2019, Jonathan Chang wrote: > > > The exit code of the upstream in a pipe is ignored thus we should avoid > > using it. By writing out the output of the git command to a file, we can &g