I added 2 additional patches that modernize style, based on discussion in [1]. Also added description in commit message as suggested in [2].
[v1]: https://public-inbox.org/git/20190309154555.33407-1-ttjt...@gmail.com/ [v2]: https://public-inbox.org/git/20190310080739.63984-1-ttjt...@gmail.com/ [v3]: https://public-inbox.org/git/cover.1552835153.git.ttjt...@gmail.com/ [1]: https://public-inbox.org/git/87imwha1o3....@evledraar.gmail.com/ [2]: https://public-inbox.org/git/20190317200609.ga1...@hank.intra.tgummerer.com/ Jonathan Chang (5): t0000: fix indentation t0000: avoid using pipes t0000: use test_line_count instead of wc -l t0000: use test_cmp instead of "test" builtin t0000: make use of the test_must_be_empty function t/t0000-basic.sh | 41 +++++++++++++++++++++-------------------- 1 file changed, 21 insertions(+), 20 deletions(-) Range-diff against v3: 1: 768bf373d0 = 1: 86146182b7 t0000: fix indentation 2: 8ee5e073a2 ! 2: 1ca1168f91 t0000: avoid using pipes @@ -6,6 +6,10 @@ using it. By writing out the output of the git command to a file, we can test the exit codes of both the commands. + This commit doesn't make any additional simplifications, such as using + the test_line_count function for counting the lines in the output. These + simplifications will be made in subsequent commits. + Signed-off-by: Jonathan Chang <ttjt...@gmail.com> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh 3: 68590a40d7 = 3: 28986ed000 t0000: use test_line_count instead of wc -l -: ---------- > 4: 731463ed98 t0000: use test_cmp instead of "test" builtin -: ---------- > 5: 53f58a4f89 t0000: make use of the test_must_be_empty function -- 2.21.0
