Re: [PATCH 0/8] Add 'ls-files --json' to dump the index in json

On Fri, Jun 21, 2019 at 8:16 PM Johannes Schindelin wrote: > > I think your warning in the manpage that this is for debugging is fine, > > as it does not put us on the hook for maintaining the feature nor its > > format forever. We might want to call it "--debug=json" or something, > > though, in

Re: [PATCH 0/8] Add 'ls-files --json' to dump the index in json

On Sat, Jun 22, 2019 at 6:31 AM brian m. carlson wrote: > > On 2019-06-19 at 09:58:50, Nguyễn Thái Ngọc Duy wrote: > > This is probably just my itch. Every time I have to do something with > > the index, I need to add a little bit code here, a little bit there to > > get a better "view" of the ind

Re: [PATCH 13/14] completion: add default options

On Sat, Jun 22, 2019 at 5:31 AM Felipe Contreras wrote: > > Versions of Git older than v2.17 don't know about > --git-completion-helper, so provide some defaults for them. > > Also, some commands fail if there's no Git repository available. > > Signed-off-by: Felipe Contreras > --- > contrib/com

Re: [PATCH] l10n: localizable upload progress messages

On Sat, Jun 22, 2019 at 2:18 AM Junio C Hamano wrote: > > Dimitriy Ryazantcev writes: > > > Signed-off-by: Dimitriy Ryazantcev > > --- > > progress.c | 3 ++- > > strbuf.c | 8 > > 2 files changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/progress.c b/progress.c > > index

Re: [PATCH v3] l10n: localizable upload progress messages

On Sat, Jun 22, 2019 at 4:37 PM Dimitriy Ryazantcev wrote: > diff --git a/strbuf.c b/strbuf.c > index 0e18b259ce..0a3ebc3749 100644 > --- a/strbuf.c > +++ b/strbuf.c > @@ -814,20 +814,28 @@ void strbuf_addstr_urlencode(struct strbuf *sb, const > char *s, > void strbuf_humanise_bytes(struct strbu

Re: [PATCH 0/8] Add 'ls-files --json' to dump the index in json

On Mon, Jun 24, 2019 at 4:32 PM Johannes Schindelin wrote: > > Hi Duy, > > On Fri, 21 Jun 2019, Duy Nguyen wrote: > > > On Fri, Jun 21, 2019 at 8:16 PM Johannes Schindelin > > wrote: > > > > > > I think your warning in the manpage that this is for deb

Re: [PATCH 1/8] ls-files: add --json to dump the index

On Wed, Jun 19, 2019 at 8:03 PM Derrick Stolee wrote: > > - show_files(the_repository, &dir); > > - > > - if (show_resolve_undo) > > - show_ru_info(the_repository->index); > > + if (!show_json) { > > + show_files(the_repository, &dir); > > + > > + if

Re: [PATCH 6/6] Use the right 'struct repository' instead of the_repository

On Mon, Jun 24, 2019 at 9:24 PM Derrick Stolee wrote: > > On 6/24/2019 5:55 AM, Nguyễn Thái Ngọc Duy wrote: > > There are a couple of places where 'struct repository' is already passed > > around, but the_repository is still used. Use the right repo. > > > > Signed-off-by: Nguyễn Thái Ngọc Duy >

Re: [PATCH 3/6] tree-walk.c: remove the_repo from get_tree_entry()

On Mon, Jun 24, 2019 at 9:20 PM Derrick Stolee wrote: > > On 6/24/2019 5:55 AM, Nguyễn Thái Ngọc Duy wrote: > > Signed-off-by: Nguyễn Thái Ngọc Duy > > --- > > archive.c | 4 +++- > > blame.c| 4 ++-- > > builtin/rm.c | 2 +- > > builtin/update-index.c |

Re: [PATCH] rm: add --intent-to-add, to be used with --cached

On Mon, Jun 24, 2019 at 5:52 PM Johannes Schindelin wrote: > > Hi Duy, > > On Sat, 22 Jun 2019, Nguyễn Thái Ngọc Duy wrote: > > > An index entry serves two purposes: to keep the content to be committed, > > and to mark that the same path on worktree is tracked. When > > > > git rm --cached foo

Re: [PATCH 13/14] completion: add default options

On Tue, Jun 25, 2019 at 8:38 AM Felipe Contreras wrote: > > On Mon, Jun 24, 2019 at 12:22 PM Junio C Hamano wrote: > > > > Duy Nguyen writes: > > > > > On Sat, Jun 22, 2019 at 5:31 AM Felipe Contreras > > > wrote: > > >> > > >&

Re: [PATCH v2 00/10] Add 'ls-files --debug-json' to dump the index in json

On Tue, Jun 25, 2019 at 1:00 AM Johannes Schindelin wrote: > > - extension location is printed, in case you need to decode the > > extension by yourself (previously only the size is printed) > > - all extensions are printed in the same order they appear in the file > > (previously eoie and ieo

Re: [PATCH v2 01/10] ls-files: add --json to dump the index

On Tue, Jun 25, 2019 at 2:15 AM Jeff Hostetler wrote: > > @@ -202,6 +202,28 @@ void jw_object_null(struct json_writer *jw, const char > > *key) > > strbuf_addstr(&jw->json, "null"); > > } > > > > +void jw_object_filemode(struct json_writer *jw, const char *key, mode_t > > mode) > > +{ >

Re: [PATCH v2 05/10] split-index.c: dump "link" extension as json

On Tue, Jun 25, 2019 at 3:06 AM Jeff Hostetler wrote: > I'm curious how big these EWAHs will be in practice and > how useful an array of integers will be (especially as the > pretty format will be one integer per line). Perhaps it > would helpful to have an extended example in one of the > tests.

Re: [PATCH] submodule foreach: fix recursion of options

On Tue, Jun 25, 2019 at 5:02 AM Morian Sonnet wrote: > > Calling > > git submodule foreach --recursive -- > > leads to an error stating that the option -- is unknown to > submodule--helper. That is of course only, when is not a valid > option for git submodule foreach. > > The reason for thi

Re: specifying revision - how to enforce matching a tag/branch-name or revision only

On Fri, Jun 21, 2019 at 10:16 PM Junio C Hamano wrote: > > Kyle Meyer writes: > > >> git rev-parse "${BRANCH_NAME}" || git rev-parse > >> "refs/remotes/${UPSTREAM}/${BRANCH_NAME}" > >> > >> Unfortunately somebody used the branch name "add-gcc10" and `git > >> rev-parse` which didn't exist on o

Re: [PATCH v2 00/10] Add 'ls-files --debug-json' to dump the index in json

On Tue, Jun 25, 2019 at 6:27 PM Johannes Schindelin wrote: > > Hi Duy, > > On Tue, 25 Jun 2019, Duy Nguyen wrote: > > > On Tue, Jun 25, 2019 at 1:00 AM Johannes Schindelin > > wrote: > > > > - extension location is printed, in case you need to dec

Re: [PATCH/RFC] get_oid: new extended SHA-1 syntax to control resolution process

On Thu, Jun 27, 2019 at 1:51 AM Junio C Hamano wrote: > > - @{literal} only accepts full ref. No turning "master" into > > "refs/heads/master". > > This is already doable by saying "refs/heads/master", isn't it? Any > ambiguous ones like a branch or a tag whose name is 'refs/heads/master' > (i.

Re: [PATCH 0/4] Some more on top of nd/switch-and-restore

On Thu, Jun 27, 2019 at 2:58 AM Junio C Hamano wrote: > > Nguyễn Thái Ngọc Duy writes: > > > This is small refinements (except 4/4). > > What's the status of these? Small test fixup needed. I should be able to do it later today. > As another low-prio topic interferes > with the code touched by

Re: [PATCH 0/4] Some more on top of nd/switch-and-restore

On Thu, Jun 27, 2019 at 9:53 AM Duy Nguyen wrote: > > On Thu, Jun 27, 2019 at 2:58 AM Junio C Hamano wrote: > > > > Nguyễn Thái Ngọc Duy writes: > > > > > This is small refinements (except 4/4). > > > > What's the status of these? > >

Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

On Thu, Jun 27, 2019 at 1:04 AM Junio C Hamano wrote: > > Johannes Schindelin writes: > > > Hi Matheus, > > > > On Tue, 18 Jun 2019, Matheus Tavares wrote: > > > >>[...] > >> +/* > >> + * Look for a recursive symlink at iter->base.path pointing to any > >> directory on > >> + * the previous stac

Re: fprintf_ln() is slow

On Thu, Jun 27, 2019 at 1:00 PM Jeff King wrote: > > On Thu, Jun 27, 2019 at 01:25:15AM -0400, Jeff King wrote: > > > Taylor and I noticed a slowdown in p1451 between v2.20.1 and v2.21.0. I > > was surprised to find that it bisects to bbb15c5193 (fsck: reduce word > > legos to help i18n, 2018-11-1

Re: [PATCH v2 05/10] split-index.c: dump "link" extension as json

On Tue, Jun 25, 2019 at 7:40 PM Derrick Stolee wrote: > > On 6/25/2019 6:29 AM, Duy Nguyen wrote: > > On Tue, Jun 25, 2019 at 3:06 AM Jeff Hostetler > > wrote: > >> I'm curious how big these EWAHs will be in practice and > >> how useful an arr

Re: fprintf_ln() is slow

On Thu, Jun 27, 2019 at 7:18 PM Ævar Arnfjörð Bjarmason wrote: > Why shouldn't we just move back to plain fprintf() with "\n"? Your > 9a0a30aa4b ("strbuf: convenience format functions with \n automatically > appended", 2012-04-23) doesn't explain why this is a convenience for > translators. > > Wh

Re: [PATCH 1/6] sha1-file.c: remove the_repo from read_object_with_reference()

On Thu, Jun 27, 2019 at 7:54 PM Johannes Schindelin wrote: > > Hi Duy, > > On Mon, 24 Jun 2019, Nguyễn Thái Ngọc Duy wrote: > > > diff --git a/builtin/grep.c b/builtin/grep.c > > index 580fd38f41..85da7ee542 100644 > > --- a/builtin/grep.c > > +++ b/builtin/grep.c > > @@ -458,7 +458,8 @@ static in

Re: [PATCH v2 05/10] split-index.c: dump "link" extension as json

On Thu, Jun 27, 2019 at 8:42 PM Derrick Stolee wrote: > > On 6/27/2019 9:24 AM, Jeff Hostetler wrote: > > On 6/27/2019 6:48 AM, Duy Nguyen wrote: > >> On Tue, Jun 25, 2019 at 7:40 PM Derrick Stolee wrote: > >>> > >>> On 6/25/2019 6:29 AM, Duy Nguyen

Re: Git Test Coverage Report (Thurs. June 27)

On Fri, Jun 28, 2019 at 12:35 AM Derrick Stolee wrote: > > dir.c > > 3b2385cf 2840) static void jw_object_untracked_cache_dir(struct json_writer > > *jw, > > 3b2385cf 2845) jw_object_bool(jw, "valid", ucd->valid); > > 3b2385cf 2846) jw_object_bool(jw, "check-only", ucd->check_only); > > 3b2385cf

Re: [PATCH/RFC] get_oid: new extended SHA-1 syntax to control resolution process

On Sun, Jun 30, 2019 at 4:30 PM Jakub Narebski wrote: > > Bikeshed painting ahead. > > Nguyễn Thái Ngọc Duy writes: > [...] > > The problem is we try every possible way to resolve a rev. Let's have > > some annotation to express that we only want to resolve a rev in a > > certain way: > > > > - @

Re: [PATCH v6 07/27] checkout: inform the user when removing branch state

On Tue, Jul 02, 2019 at 10:06:11AM +0200, SZEDER Gábor wrote: > On Fri, Mar 29, 2019 at 05:38:59PM +0700, Nguyễn Thái Ngọc Duy wrote: > > After a successful switch, if a merge, cherry-pick or revert is ongoing, > > it is canceled. This behavior has been with us from the very early > > beginning, so

Re: [PATCH v3 1/3] repo-settings: create core.featureAdoptionRate setting

On Mon, Jul 1, 2019 at 10:32 PM Derrick Stolee via GitGitGadget wrote: > @@ -601,3 +602,22 @@ core.abbrev:: > in your repository, which hopefully is enough for > abbreviated object names to stay unique for some time. > The minimum length is 4. > + > +core.featureAdoptionRat

Re: [PATCH v2 1/3] repo-settings: create core.featureAdoptionRate setting

On Tue, Jul 2, 2019 at 5:47 PM Ævar Arnfjörð Bjarmason wrote: > > > On Wed, Jun 19 2019, Derrick Stolee via GitGitGadget wrote: > > > core.commitGraph:: > > If true, then git will read the commit-graph file (if it exists) > > - to parse the graph structure of commits. Defaults to false.

Re: [PATCH v2 05/10] split-index.c: dump "link" extension as json

On Fri, Jul 5, 2019 at 3:01 AM SZEDER Gábor wrote: > > On Mon, Jun 24, 2019 at 08:02:21PM +0700, Nguyễn Thái Ngọc Duy wrote: > > diff --git a/t/t3011-ls-files-json.sh b/t/t3011-ls-files-json.sh > > index 082fe8e966..dbb572ce9d 100755 > > --- a/t/t3011-ls-files-json.sh > > +++ b/t/t3011-ls-files-js

Re: [PATCH v6 07/27] checkout: inform the user when removing branch state

On Wed, Jul 3, 2019 at 12:51 AM Junio C Hamano wrote: > > Duy Nguyen writes: > > > I agree, this is not "canceling". I think this series causes conflicts > > with pw/clean-sequencer-state-upon-final-commit and the warning is > > accidentally enabled (partl

Re: What's cooking in git.git (Jul 2019, #07; Mon, 29)

On Tue, Jul 30, 2019 at 4:49 AM Junio C Hamano wrote: > * nd/index-dump-in-json (2019-06-26) 11 commits > - SQUASH??? > - t3008: use the new SINGLE_CPU prereq > - read-cache.c: dump "IEOT" extension as json > - read-cache.c: dump "EOIE" extension as json > - resolve-undo.c: dump "REUC" extens

Re: [PATCH] read-cache: use of memory after it is freed

On Sat, Oct 20, 2018 at 9:33 AM Carlo Marcelo Arenas Belón wrote: > > introduced with c46c406ae1e (trace.h: support nested performance tracing) > on Aug 18, 2018 but not affecting maint > > Signed-off-by: Carlo Marcelo Arenas Belón > --- > read-cache.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH 00/59] Split config.txt

On Sat, Oct 20, 2018 at 9:25 PM Ævar Arnfjörð Bjarmason wrote: > And sometimes like in the case of git-gc(1) we have gc.* config > documented in two places with different prose that needs to be updated > in two places in a CONFIGURATION section. This series allows us to just > unify the two and do

Re: [PATCH] completion: use __gitcomp_builtin for format-patch

On Mon, Oct 22, 2018 at 12:17 PM SZEDER Gábor wrote: > > On Sun, Oct 21, 2018 at 10:41:02AM +0200, Nguyễn Thái Ngọc Duy wrote: > > This helps format-patch gain completion for a couple new options, > > notably --range-diff. > > > > Signed-off-by: Nguyễn Thái Ngọc Duy > > --- > > Of course it will

Re: [PATCH v4 2/2] worktree: add per-worktree config files

On Mon, Oct 22, 2018 at 6:54 AM Junio C Hamano wrote: > > Nguyễn Thái Ngọc Duy writes: > > > diff --git a/Documentation/config.txt b/Documentation/config.txt > > index 552827935a..244560a35e 100644 > > --- a/Documentation/config.txt > > +++ b/Documentation/config.txt > > @@ -2,8 +2,9 @@ CONFIGUR

Re: [PATCH] completion: fix __gitcomp_builtin no longer consider extra options

On Mon, Oct 22, 2018 at 5:51 AM Junio C Hamano wrote: > > Nguyễn Thái Ngọc Duy writes: > > > __gitcomp_builtin() has the main completion list provided by > > > > git xxx --git-completion-helper > > > > but the caller can also add extra options that is not provided by > > --git-completion-hel

Re: [PATCH 00/59] Split config.txt

On Sun, Oct 21, 2018 at 1:29 AM Junio C Hamano wrote: > > Ævar Arnfjörð Bjarmason writes: > > > I had a slight bias against this when you started this, since I'm one of > > these odd people who don't mind ~20k line files if the line count isn't > > contributing to inherent complexity, e.g. in the

Re: [PATCH v3 2/3] reset: add new reset.quiet config setting

On Mon, Oct 22, 2018 at 3:38 PM Ben Peart wrote: > > From: Ben Peart > > Add a reset.quiet config setting that sets the default value of the --quiet > flag when running the reset command. This enables users to change the > default behavior to take advantage of the performance advantages of > avo

Re: [PATCH] Poison gettext with the Ook language

On Mon, Oct 22, 2018 at 10:23 PM SZEDER Gábor wrote: > Once upon a time a GETTEXT_POISON build job failed on me, and the > error message: > > error: # GETTEXT POISON # > > was not particularly useful. Ook wouldn't help with that... Oook? > So I came up with the following couple of patches tha

Re: [PATCH 7/8] gettext: introduce GIT_GETTEXT_POISON=scrambled

On Mon, Oct 22, 2018 at 10:23 PM SZEDER Gábor wrote: > [TODO: Fallout? >A 'printf(_("foo: %s"), var);' call includes the contents of >'var' unscrambled in the output. Could that hide the >translation of a string that should not have been translated? >I'm afraid yes

Re: [PATCH] Poison gettext with the Ook language

On Tue, Oct 23, 2018 at 12:17 PM Ævar Arnfjörð Bjarmason wrote: > > > On Tue, Oct 23 2018, Johannes Schindelin wrote: > > > Hi Ævar, > > > > On Mon, 22 Oct 2018, Ævar Arnfjörð Bjarmason wrote: > > > >> So I think the only reason to keep it [GETTEXT_POISON] compile-time is > >> performance, but I d

Re: [PATCH] khash: silence -Wunused-function

On Tue, Oct 23, 2018 at 1:42 PM Carlo Marcelo Arenas Belón wrote: > > after 36da893114 ("config.mak.dev: enable -Wunused-function", 2018-10-18) > macro generated code should use a similar solution than commit-slab to > silence the compiler. > > Signed-off-by: Carlo Marcelo Arenas Belón > --- > k

Re: [PATCH v3 1/3] reset: don't compute unstaged changes after reset when --quiet

On Tue, Oct 23, 2018 at 1:01 AM Ben Peart wrote: > > > -Original Message- > > From: Johannes Schindelin > > Sent: Monday, October 22, 2018 4:45 PM > > To: Ben Peart > > Cc: git@vger.kernel.org; gits...@pobox.com; Ben Peart > > ; p...@peff.net; sunsh...@sunshineco.com > > Subject: Re: [PA

Re: [PATCH] Poison gettext with the Ook language

On Tue, Oct 23, 2018 at 6:45 PM Ævar Arnfjörð Bjarmason wrote: > >> The effect of what I'm suggesting here, and which my WIP patch in > >> <875zxtd59e@evledraar.gmail.com> implements is that we'd do a > >> one-time getenv() for each process that prints a _() message that we > >> aren't doing n

Re: [PATCH v3 2/3] reset: add new reset.quiet config setting

On Tue, Oct 23, 2018 at 8:47 PM Ben Peart wrote: > > > > On 10/22/2018 10:45 AM, Duy Nguyen wrote: > > On Mon, Oct 22, 2018 at 3:38 PM Ben Peart wrote: > >> > >> From: Ben Peart > >> > >> Add a reset.quiet config setting that sets the d

Re: [PATCH v3 2/3] reset: add new reset.quiet config setting

On Wed, Oct 24, 2018 at 4:56 AM Junio C Hamano wrote: > How we should get there is a different story. I think Duy's series > needs at least another update to move the split pieces into its own > subdirectory of Documentation/, and it is not all that urgent, while > this three-patch series (with t

Re: Translate ProGit v2 into vietnamese

On Wed, Oct 24, 2018 at 2:16 PM rk42_gg wrote: > > Dear Git Developer, > > I have started translating Pro Git v2 book into Vietnamese at > https://github.com/rocket42/progit2-vi Great! > Pls show me how to add it to "*Translations started for*" section in > https://git-scm.com/book/en/v2 This i

Re: bug?: git grep HEAD with exclude in pathspec not taken into account

On Wed, Oct 24, 2018 at 4:55 PM Christophe Bliard wrote: > > Hi, > > I observed an unexpected behavior while using git grep with both git > 2.19.1 and 2.14.3. Here is how to reproduce it: > > > git init > Initialized empty Git repository in /private/tmp/hello/.git/ > > echo foo > fileA > > echo 'f

Re: [PATCH/RFC] thread-utils: better wrapper to avoid #ifdef NO_PTHREADS

On Fri, Oct 26, 2018 at 4:09 PM Ben Peart wrote: > I agree though I'm still curious if there are still no-threaded > platforms taking new versions of git. Perhaps we should do the > depreciation warning you suggested elsewhere and see how much push back > we get. It's unlikely we'd get lucky and

Re: [PATCH 01/10] thread-utils: macros to unconditionally compile pthreads API

On Sat, Oct 27, 2018 at 9:31 AM Jeff King wrote: > > +#define pthread_setspecific(key, data) > > +#define pthread_getspecific(key) NULL > > We expect to be able to store a void pointer here and get it back, which > should work even for a single thread. Do we need something like: > > extern void

Re: [RFC PATCH] index-pack: improve performance on NFS

On Sat, Oct 27, 2018 at 11:34 AM Jeff King wrote: > Taking one step back, the root problem in this thread is that stat() on > non-existing files is slow (which makes has_sha1_file slow). > > One solution there is to cache the results of looking in .git/objects > (or any alternate object store) for

Re: [PATCH 01/10] thread-utils: macros to unconditionally compile pthreads API

On Sat, Oct 27, 2018 at 10:15 AM Jeff King wrote: > > On Sat, Oct 27, 2018 at 09:40:13AM +0200, Duy Nguyen wrote: > > > > We expect to be able to store a void pointer here and get it back, which > > > should work even for a single thread. Do we need something like

Re: bug?: git grep HEAD with exclude in pathspec not taken into account

On Wed, Oct 24, 2018 at 4:55 PM Christophe Bliard wrote: > > Hi, > > I observed an unexpected behavior while using git grep with both git > 2.19.1 and 2.14.3. Quick note. I confirm this is a bug in tree_entry_interesting() perhaps being over-optimistic. It'll take me more time to familiarize myse

Re: [PATCH 00/10] Reduce #ifdef NO_PTHREADS

On Sat, Oct 27, 2018 at 10:13 AM Jeff King wrote: > > On Sat, Oct 27, 2018 at 09:09:53AM +0200, Nguyễn Thái Ngọc Duy wrote: > > > People seemed to support the idea of removing these #ifdef NO_PTHREADS [1] > > so this is a complete series. I left the #ifdef in run-command.c and > > transport-helper

t7405.17 breakage vanishes with GETTEXT_POISON=1

Something fishy is going on but I don't think I'll spend time hunting it down so I post here in case somebody else is interested. It might also indicate a problem with poison gettext, not the test case too. -- Duy

Re: [PATCH] wildmatch: change behavior of "foo**bar" in WM_PATHNAME mode

On Sun, Oct 28, 2018 at 7:25 AM Torsten Bögershausen wrote: > > On Sat, Oct 27, 2018 at 10:48:23AM +0200, Nguyễn Thái Ngọc Duy wrote: > > In WM_PATHNAME mode (or FNM_PATHNAME), '*' does not match '/' and '**' > > can but only in three patterns: > > > > - '**/' matches zero or more leading director

Re: [PATCH] l10n: vi.po: fix typo in pack-objects

I'm not sure if Junio still takes .po patches or only Jiang Xin does. I CC Jiang here just in case. On Thu, Oct 25, 2018 at 3:05 AM Minh Nguyen wrote: > > --- > po/vi.po | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/po/vi.po b/po/vi.po > index bc79319b6..e646825ed 10

Re: [PATCH] wildmatch: change behavior of "foo**bar" in WM_PATHNAME mode

On Mon, Oct 29, 2018 at 2:24 PM Ævar Arnfjörð Bjarmason wrote: > This patch looks good to me, but I think it's a bad state of affairs to > keep changing these semantics and not having something like a > "gitwildmatch" doc were we document this matching syntax. While we don't have a separate docum

Re: [PATCH 06/10] grep: remove #ifdef NO_PTHREADS

On Mon, Oct 29, 2018 at 3:25 PM Jeff King wrote: > But if the problem is simply that we are not quite there yet in the grep > code, I am OK with taking this as the first pass, and knowing that there > is more cleanup to be done later (though that sort of thing is IMHO very > useful in a commit mes

Re: [PATCH 12/12] fsck: mark strings for translation

On Mon, Oct 29, 2018 at 3:09 PM Junio C Hamano wrote: > > SZEDER Gábor writes: > > >> -fprintf(stderr, "%s in %s %s: %s\n", > >> -msg_type, printable_type(obj), describe_object(obj), err); > >> +fprintf_ln(stderr, _("%s in %s %s: %s"), > > > > Are the (f)printf() -> (f)printf_

Re: [PATCH 08/12] remote.c: mark messages for translation

On Mon, Oct 29, 2018 at 8:56 AM Junio C Hamano wrote: > There are other series in flight that touch the same area of code > and in different ways, causing unnecessary conflicts, which does not > help us either X-<. I will of course fix all other comments, but I can hold this off if it's causing t

Re: t7405.17 breakage vanishes with GETTEXT_POISON=1

On Sun, Oct 28, 2018 at 1:15 PM SZEDER Gábor wrote: > > On Sun, Oct 28, 2018 at 06:41:06AM +0100, Duy Nguyen wrote: > > Something fishy is going on but I don't think I'll spend time hunting > > it down so I post here in case somebody else is interested. It might >

Re: [PATCH/WIP 00/19] Kill the_index, final part

On Fri, Oct 19, 2018 at 7:38 PM Stefan Beller wrote: > > On Fri, Oct 19, 2018 at 7:52 AM Nguyễn Thái Ngọc Duy > wrote: > > > > Stefan I see you start removing more references of the_repository in > > another series (haven't really looked at it yet) so this is just heads > > up so we could coordi

Re: [PATCH v3 2/8] Add a place for (not) sharing stuff between worktrees

On Mon, Oct 22, 2018 at 6:28 AM Junio C Hamano wrote: > > When multiple worktrees are used, we need rules to determine if > > something belongs to one worktree or all of them. Instead of keeping > > adding rules when new stuff comes (*), have a generic rule: > > > > - Inside $GIT_DIR, which is per

Re: [PATCH 09/10] read-cache.c: remove #ifdef NO_PTHREADS

On Mon, Oct 29, 2018 at 6:05 PM Ben Peart wrote: > > @@ -2756,8 +2745,11 @@ static int do_write_index(struct index_state > > *istate, struct tempfile *tempfile, > > if (ce_write(&c, newfd, &hdr, sizeof(hdr)) < 0) > > return -1; > > > > -#ifndef NO_PTHREADS > > - nr_threads

Re: [PATCH v2 06/10] preload-index.c: remove #ifdef NO_PTHREADS

On Mon, Oct 29, 2018 at 6:21 PM Ben Peart wrote: > @@ -114,6 +104,9 @@ static void preload_index(struct index_state *index, > threads = index->cache_nr / THREAD_COST; > if ((index->cache_nr > 1) && (threads < 2) && > git_env_bool("GIT_TEST_PRELOAD_INDEX", 0)) > t

Re: [PATCH v2] completion: use builtin completion for format-patch

On Tue, Oct 30, 2018 at 7:39 AM Denton Liu wrote: > > This patch offloads completion functionality for format-patch to > __gitcomp_builtin. In addition to this, send-email was borrowing some > completion options from format-patch so those options are moved into > send-email's completions. > > Sign

Re: [RFC v1] Add virtual file system settings and hook proc

not really a review, just a couple quick notes.. On Tue, Oct 30, 2018 at 9:40 PM Ben Peart wrote: > > From: Ben Peart > > On index load, clear/set the skip worktree bits based on the virtual > file system data. Use virtual file system data to update skip-worktree > bit in unpack-trees. Use virt

Re: ab/* topics

On Thu, Nov 1, 2018 at 3:04 PM Junio C Hamano wrote: > > Ævar Arnfjörð Bjarmason writes: > > > Could you please pick up > > https://public-inbox.org/git/20181024114725.3927-1-ava...@gmail.com/ ? > > It seems to have fallen between the cracks and addressed the feedback on > > v1, and looks good to

Re: [PATCH v2] completion: use builtin completion for format-patch

On Thu, Nov 1, 2018 at 2:42 AM Junio C Hamano wrote: > >> @@ -2080,16 +2071,19 @@ _git_send_email () > >> return > >> ;; > >> --*) > >> - __gitcomp "--annotate --bcc --cc --cc-cmd --chain-reply-to > >> - --compose --confir

Re: [PATCH] doc: move git-cherry to plumbing

On Thu, Oct 11, 2018 at 9:38 PM Daniels Umanovskis wrote: > > Also remove git-cherry from Bash completion because plumbing > commands do not belong there. Er.. why? > > Signed-off-by: Daniels Umanovskis > --- > > Up to discussion whether cherry should be considered plumbing. > I lean towards co

Re: [PATCH v1] add: speed up cmd_add() by utilizing read_cache_preload()

On Fri, Nov 2, 2018 at 2:32 PM Ben Peart wrote: > > From: Ben Peart > > During an "add", a call is made to run_diff_files() which calls > check_remove() for each index-entry. The preload_index() code distributes > some of the costs across multiple threads. Instead of doing this site by site. Ho

Re: Understanding pack format

On Fri, Nov 2, 2018 at 6:26 AM Farhan Khan wrote: > > Hi all, > > I am trying to understand the pack file format and have been reading > the documentation, specifically https://git-scm.com/docs/pack-format > (which is in git's own git repository as > "Documentation/technical/pack-format.txt"). I s

Re: Understanding pack format

On Fri, Nov 2, 2018 at 7:19 AM Junio C Hamano wrote: > > Farhan Khan writes: > > > ...Where is this in the git code? That might > > serve as a good guide. > > There are two major codepaths. One is used at runtime, giving us > random access into the packfile with the help with .idx file. The > o

submodule support in git-bundle

I use git-bundle today and it occurs to me that if I want to use it to transfer part of a history that involves submodule changes, things aren't pretty. Has anybody given thought on how to do binary history transfer that contains changes from submodules? Since .bundle files are basically .pack fil

Re: submodule support in git-bundle

On Fri, Nov 2, 2018 at 6:09 PM Stefan Beller wrote: > > On Fri, Nov 2, 2018 at 9:10 AM Duy Nguyen wrote: > > > > I use git-bundle today and it occurs to me that if I want to use it to > > transfer part of a history that involves submodule changes, things > > ar

Re: [PATCH v1] add: speed up cmd_add() by utilizing read_cache_preload()

On Sat, Nov 3, 2018 at 1:38 AM Junio C Hamano wrote: > > Duy Nguyen writes: > > > On Fri, Nov 2, 2018 at 2:32 PM Ben Peart wrote: > >> > >> From: Ben Peart > >> > >> During an "add", a call is made to run_diff_files() which calls

Re: [PATCH v2] completion: use builtin completion for format-patch

On Fri, Nov 02, 2018 at 08:52:30AM +0900, Junio C Hamano wrote: > Duy Nguyen writes: > > >> > I have no comment about this. In an ideal world, sendemail.perl could > >> > be taught to support --git-completion-helper but I don't think my > >> > litt

Re: [PATCH v2] completion: use builtin completion for format-patch

On Sat, Nov 3, 2018 at 8:59 AM Denton Liu wrote: > > @@ -2081,7 +2077,7 @@ _git_send_email () > > return > > ;; > > --*) > > - __gitcomp "--annotate --bcc --cc --cc-cmd --chain-reply-to > > + __gitcomp_builtin send-email "--annotate --bcc -

Re: [[PATCH v2]] commit: add a commit.allowempty config variable

On Sat, Nov 3, 2018 at 12:55 PM tanushree27 wrote: > > Add commit.allowempty configuration variable as a convenience for those > who always prefer --allow-empty. > > Add tests to check the behavior introduced by this commit. > > This closes https://github.com/git-for-windows/git/issues/1854 > > Si

Re: [PATCH v4] gpg-interface.c: detect and reject multiple signatures on commits

On Sat, Oct 20, 2018 at 9:31 PM Michał Górny wrote: > +test_expect_success GPG 'detect fudged commit with double signature' ' > + sed -e "/gpgsig/,/END PGP/d" forged1 >double-base && > + sed -n -e "/gpgsig/,/END PGP/p" forged1 | \ > + sed -e "s/^gpgsig//;s/^ //" | gpg --d

Re: [PATCH v4] gpg-interface.c: detect and reject multiple signatures on commits

On Sat, Nov 3, 2018 at 4:32 PM Michał Górny wrote: > > Perhaps my gpg is too old? > > > > $ gpg --version > > gpg (GnuPG) 2.1.15 > > libgcrypt 1.7.3 > > Copyright (C) 2016 Free Software Foundation, Inc. > > License GPLv3+: GNU GPL version 3 or later > > > > Thi

Re: [PATCH v4] gpg-interface.c: detect and reject multiple signatures on commits

On Sat, Nov 3, 2018 at 4:32 PM Michał Górny wrote: > Perhaps this is indeed specific to this version of GnuPG. The tests > pass for me with both 1.4.21 and 2.2.10. We don't have 2.1* in Gentoo > anymore. Updated to 2.2.8 and the test is passed. -- Duy

Re: [PATCH] tree-walk.c: fix overoptimistic inclusion in :(exclude) matching

On Sun, Nov 4, 2018 at 7:27 AM Eric Sunshine wrote: > > On Sat, Nov 3, 2018 at 8:25 PM Eric Sunshine wrote: > > On Sat, Nov 3, 2018 at 11:31 AM Nguyễn Thái Ngọc Duy > > wrote: > > > +test_expect_success 't_e_i() exclude case #8' ' > > > + git init case8 && > > > + ( > > > +

Re: [RFC v1] Add virtual file system settings and hook proc

On Wed, Oct 31, 2018 at 9:53 PM Ben Peart wrote: > >> +core.virtualFilesystem:: > >> + If set, the value of this variable is used as a command which > >> + will identify all files and directories that are present in > >> + the working directory. Git will only track and update fi

Re: [PATCH/RFC] sequencer.c: record revert/cherry-pick commit with trailer lines

On Sun, Nov 4, 2018 at 5:45 PM Phillip Wood wrote: > > On 04/11/2018 07:22, Nguyễn Thái Ngọc Duy wrote: > > When a commit is reverted (or cherry-picked with -x) we add an English > > sentence recording that commit id in the new commit message. Make > > these real trailer lines instead so that they

Re: [RFC v1] Add virtual file system settings and hook proc

On Sun, Nov 4, 2018 at 10:01 PM brian m. carlson wrote: > > On Sun, Nov 04, 2018 at 07:34:01AM +0100, Duy Nguyen wrote: > > On Wed, Oct 31, 2018 at 9:53 PM Ben Peart wrote: > > > It's more than a dynamic sparse-checkout because the same list is also > > >

Re: [RFC v1] Add virtual file system settings and hook proc

On Mon, Nov 5, 2018 at 12:40 PM Ævar Arnfjörð Bjarmason wrote: > > > On Sun, Nov 04 2018, Duy Nguyen wrote: > > > On Wed, Oct 31, 2018 at 9:53 PM Ben Peart wrote: > >> >> +core.virtualFilesystem:: > >> >> + If set, the value of this variable

Re: "git checkout" safety feature

On Mon, Nov 5, 2018 at 7:53 AM Jeff King wrote: > > On Mon, Nov 05, 2018 at 07:24:42AM +0100, Matthias Urlichs wrote: > > > Hi, > > > "git checkout " is a feature to overwrite local > > > changes. It is what you use when you make a mess editing the files > > > and want to go back to a known stat

Re: [PATCH/RFC v2] sequencer.c: record revert/cherry-pick commit with trailer lines

On Sun, Nov 4, 2018 at 10:30 PM brian m. carlson wrote: > However, I do have concerns about breaking compatibility with existing > scripts. I wonder if we could add a long alias for git cherry-pick -x, > say "--notate" and have "--notate=text" mean "-x" and "--notate=trailer" > mean this new form

Re: [PATCH/RFC] sequencer.c: record revert/cherry-pick commit with trailer lines

On Mon, Nov 5, 2018 at 1:56 AM Junio C Hamano wrote: > > Nguyễn Thái Ngọc Duy writes: > > > A reverted commit will have a new trailer > > > > Revert: > > Please don't, unless you are keeping the current "the effect of > commit X relative to its parent Y was reverted" writtein in prose, > wh

Re: [PATCH 0/13] parseopt fixes from -Wunused-parameters

On Mon, Nov 5, 2018 at 7:39 AM Jeff King wrote: > > Continuing my exploration of what -Wunused-parameters can show us, here > are some bug-fixes related to parse-options callbacks. > > This is the last of the actual bug-fixes I've found. After this, I have > about 60 patches worth of cleanups (i.e

Re: [PATCH 12/12] fsck: mark strings for translation

On Mon, Oct 29, 2018 at 12:53 PM SZEDER Gábor wrote: > The contents of 'out': > > broken link fromtree be45bbd3809e0829297cefa576e699c134abacfd > (refs/heads/master@{1112912113}:caesar.t) > toblob be45bbd3809e0829297cefa576e699c134abacfd > (refs/heads/master@{1112912113

Re: [PATCH 0/13] parseopt fixes from -Wunused-parameters

On Mon, Nov 5, 2018 at 7:49 PM Jeff King wrote: > > On Mon, Nov 05, 2018 at 05:51:07PM +0100, Duy Nguyen wrote: > > > On Mon, Nov 5, 2018 at 7:39 AM Jeff King wrote: > > > > > > Continuing my exploration of what -Wunused-parameters can show us, here > >

Re: Design of multiple hash support

On Mon, Nov 5, 2018 at 2:02 AM brian m. carlson wrote: > > I'm currently working on getting Git to support multiple hash algorithms > in the same binary (SHA-1 and SHA-256). In order to have a fully > functional binary, we'll need to have some way of indicating to certain > commands (such as init

Re: [PATCH v1] refresh_index: remove unnecessary calls to preload_index()

On Mon, Nov 5, 2018 at 8:30 PM Ben Peart wrote: > > From: Ben Peart > > With refresh_index() learning to utilize preload_index() to speed up its > operation there is no longer any benefit to having the caller preload the > index first. Remove those unneeded calls by calling read_index() instead o

Re: [PATCH] format-patch: respect --stat when explicitly specified

On Tue, Nov 6, 2018 at 11:48 AM Leif Lindholm wrote: > > Commit 43662b23abbd > ("format-patch: keep cover-letter diffstat wrapped in 72 columns") made > format-patch keep the diffstat to within 72 characters. However, it does > this even when --stat is explicitly set on the command line. > > Make

<    9   10   11   12   13   14   15   16   17   18   >