On Mon, Jun 24, 2019 at 9:24 PM Derrick Stolee <sto...@gmail.com> wrote: > > On 6/24/2019 5:55 AM, Nguyễn Thái Ngọc Duy wrote: > > There are a couple of places where 'struct repository' is already passed > > around, but the_repository is still used. Use the right repo. > > > > Signed-off-by: Nguyễn Thái Ngọc Duy <pclo...@gmail.com> > > nit: the subject line doesn't use the standard "area: topic" format
because there's no specific area to this patch. I don't think sticking to a fixed convention for the sake of it is really sensible. > (including > the capitalization of the first word). Perhaps: > > treewide: use the right 'struct repository' instead of the_repository > > The changes here are straight-forward, but how do we check if we are done? At this point, you can't. At some point we should be able to optionally disable the_repository, at least per file [2]. But even then some function calls inside could still hide the_repository and you would need something like [1] to reveal them. The problem with [2] is it will cause a lot of problems when adding new code until most of the code is converted. I will bring that up when the number of the_repository (outside builtin/) goes down below ~50. With all my patches, I think we're at 300. [1] https://gitlab.com/pclouds/git/commit/902a4dbdef6829ca06e12dbf74b0690456733351 [2] https://gitlab.com/pclouds/git/commit/f03f915294210baf038ee72d76ee998d9387028b -- Duy
