Jean-Noël Avila 于2019年2月11日周一 下午2:48写道：
>
> Signed-off-by: Jean-Noël Avila
> ---
> builtin/bisect--helper.c | 4 ++--
> builtin/fetch.c | 2 +-
> builtin/rebase.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
This re-roll is v2 (forgot suffix v2 in subject), and LG
On Thu, Feb 7, 2019 at 10:33 PM Thomas Gummerer wrote:
>
> On 02/07, Johannes Schindelin wrote:
> > On Wed, 6 Feb 2019, Thomas Gummerer wrote:
> > > - implement pushing/poping conflicted state
> > >
> > >This would obviously be the end goal.
> >
> > On second thought, this might actually be s
пн, 11 февр. 2019 г. в 10:46, Christian Couder :
>
> On Mon, Feb 11, 2019 at 6:48 AM Оля Тележная wrote:
> >
> > > It would be nice to have a few more project ideas.
> >
> > I am not sure I have additional ideas for 3-month project for the intern,
> > but
> >
> > > https://git.github.io/SoC-2019-
On 11 février 2019, Jiang Xin wrote:
> Jean-Noël Avila 于2019年2月11日周一 下午2:48写道：
>> Signed-off-by: Jean-Noël Avila
>> ---
>> builtin/bisect--helper.c | 4 ++--
>> builtin/fetch.c | 2 +-
>> builtin/rebase.c | 2 +-
>> 3 files changed, 4 insertions(+), 4 deletions(-)
> This re-rol
On Fri, 8 Feb 2019 09:10:33 +
and...@adoakley.name wrote:
> From: Andrew Oakley
>
> Perforce allows you commit files and directories with the same name,
> so you could have files //depot/foo and //depot/foo/bar both checked
> in. A p4 sync of a repository in this state fails. Deleting one
> 肖建晶 <06271...@bjtu.edu.cn> wrote:
> > hi,
> >git developers. I found a bug when i want to convert webkit to git
> >there are some branch named safari... in webkit svn repo.
> >when i want to convert them to branch in git. a problem happen.
> >
> >if you want to reproduce the pr
Signed-off-by: Nguyễn Thái Ngọc Duy
---
Jiang Xin's typo patch [1] made me quickly go through all multi-line
strings. This is the only bad string I found.
[1]
https://public-inbox.org/git/canyiybgf6oj0k3-k+s0dso-bzz2excvcoyxojtqsbbmhetg...@mail.gmail.com/
imap-send.c | 2 +-
1 file changed,
On Mon, Feb 11, 2019 at 2:09 AM Randall S. Becker
wrote:
>
> Hi All,
>
> I tracked down a breakage in t1404 subtest 52. The line
>
> test_i18ngrep "Unable to create $Q.*packed-refs.lock$Q: File exists" err
The message does not match, does it? Here we grep for "File exists"
but the message you sho
On Mon, Feb 11, 2019 at 9:39 AM Оля Тележная wrote:
>
> пн, 11 февр. 2019 г. в 10:46, Christian Couder :
> >
> > On Mon, Feb 11, 2019 at 6:48 AM Оля Тележная
> > wrote:
> > > > - Unify ref-filter formats with other --pretty formats (which is new)
> > >
> > > I am ready to act as a mentor in thi
Hello.
I have trouble.
https://superuser.com/questions/1252276/cant-type-during-git-clone-putty-connection
On February 11, 2019 4:57, Duy Nguyen wrote:
> On Mon, Feb 11, 2019 at 2:09 AM Randall S. Becker
> wrote:
> >
> > Hi All,
> >
> > I tracked down a breakage in t1404 subtest 52. The line
> >
> > test_i18ngrep "Unable to create $Q.*packed-refs.lock$Q: File exists"
> > err
>
> The message does not
Hi Ævar,
On Fri, Feb 8, 2019 at 10:53 AM Ævar Arnfjörð Bjarmason
wrote:
>
> On Thu, Jan 31 2019, Elijah Newren wrote:
>
> > What's the future? (Core command of git.git? place it in contrib? keep it
> > in a separate repo?) I'm hoping to discuss that at the contributor summit
> > today, but fe
Hi Dscho,
On Fri, Feb 8, 2019 at 12:13 PM Johannes Schindelin
wrote:
>
> Hi Ævar,
>
> On Fri, 8 Feb 2019, Ævar Arnfjörð Bjarmason wrote:
>
> > [...]
> >
> > But perhaps there's ways we can in advance deal with a potential
> > future breaking API change. E.g. some Pythonic way of versioning th
Hi All,
I have localized the hang in t5562 (previous thread) to the
invoke-with-content-length.pl script. At least on NonStop, what happens is
that the perl process hangs waiting for close($out) to complete whether
explicitly or implicitly (if the call is removed). The trace for the perl
process s
SZEDER Gábor writes:
> On Thu, Feb 07, 2019 at 05:33:05PM +0700, Nguyễn Thái Ngọc Duy wrote:
>> Nguyễn Thái Ngọc Duy (21):
>> diff.c: convert --patch-with-raw
>> diff.c: convert --numstat and --shortstat
>> diff.c: convert --dirstat and friends
>> diff.c: convert --check
>> ...
>> dif
"brian m. carlson" writes:
> On Sun, Feb 10, 2019 at 08:04:13AM +, Torsten Bögershausen wrote:
>
>> I think we agree that Git will write UTF-16 always as big endian with BOM,
>> following the tradition of iconv/libiconv.
>> If yes, we can reduce the lines of code/#idefs somewhat, have the kno
Commit d0aaa46fd3 ("commit: move empty message checks to libgit",
2017-11-10) removes the last use of 'sign_off_header' outside of
the "sequencer.c" source file. Remove the extern declaration from
the header file and mark the definition of the symbol with the
static keyword.
Signed-off-by: Ramsa
Signed-off-by: Ramsay Jones
---
Hi Junio,
Another 'old find' (from feb 2017), but this time I don't seem to have
sent this one to the list before. It is possible that I didn't think
it was up to scratch ... dunno. ;-)
ATB,
Ramsay Jones
builtin/prune-packed.c | 5 +
1 file changed, 5 ins
Nguyễn Thái Ngọc Duy writes:
> "What's cooking" mails seem to indicate that the series will be cooked
> in full there then landed on master later. So here's the second part.
Ah, I should have responded to this part.
I think that the part 1 was reviewed and found reasonable, and we
could merge
Nguyễn Thái Ngọc Duy writes:
Nguyễn Thái Ngọc Duy writes:
> This adds value completion for a couple more paramters. To make it
> easier to maintain these hard coded lists, add a comment at the original
> list/code to remind people to update git-completion.bash too.
>
> Signed-off-by: Nguyễn T
> > > +void get_client_protocol_version_advertisement(struct strbuf *advert)
> > > +{
> > > + int i, tmp_nr = nr_allowed_versions;
> > > + enum protocol_version *tmp_allowed_versions, config_version;
> > > + strbuf_reset(advert);
> > > +
> > > + version_registration_locked = 1;
> > > +
> >
Hello Santiago,
I'm running debian Stretch on my machine, and using Eclipse. I'm new in
linux world so I don't know how could I let you know all packages I've
installed in a single screenshot.
However I got the git sources with the following command:
$ git clone git://git.kernel.org/pub/scm/git/gi
Fix infinite loop observed on Windows computing process ancestry. This
should be applied to V6 of "jh/trace2" currently in next.
See: https://github.com/gitgitgadget/git/pull/108
Thanks Jeff
Cc: gitster@pobox.comCc: peff@peff.netCc: jrnie...@gmail.com
Jeff Hostetler (1):
fixup! trace2: collec
From: Jeff Hostetler
Guard against infinite loop while computing the parent process hierarchy.
CreateToolhelp32Snapshot() is used to get a list of all processes on the
system. Each process entry contains the process PID and PPID (alive at the
time of the snapshot). We compute the set of ancest
> On Tue, Feb 05, 2019 at 04:21:22PM -0800, Jonathan Tan wrote:
>
> > In post_rpc(), remote-curl calls credential_fill() if HTTP_REAUTH is
> > returned, but this is not true in proxy_request(). Do this in
> > proxy_request() too.
>
> Can we do this as a general rule? If we look at the code in pos
On Sat, Feb 09, 2019 at 06:05:53PM -0500, Todd Zullinger wrote:
> SZEDER Gábor wrote:
> > Just curious: how did you noticed the missing GPGSM prereq?
>
> I just grep the build output for '# SKIP|skipped:' and then
> filter out those which I expect (thing like MINGW and
> NATIVE_CRLF that aren't li
Roland Hieber writes:
> The output of git-reflog(1) is currently only customisable by calling
> reflog with --pretty=... or overriding the "pretty.oneline" format in
> the config, which is currently the default fallback.
It is correct to point out that "git reflog --pretty=..." is a valid
way to
Use a '!' character to start a non-matching pattern bracket
expression, as specified by POSIX in Shell Command Language section
2.13.1 Patterns Matching a Single Character [1].
I used '^' instead in three places in the previous three commits, to
verify that the arguments of the '--stress=' and '--
On Tue, Feb 05, 2019 at 04:21:15PM -0800, Jonathan Tan wrote:
> Define a GIT_TEST_PROTOCOL_VERSION environment variable meant to be used
> from tests. When set, this ensures protocol.version is at least the
> given value, allowing the entire test suite to be run as if this
> configuration is in pl
On Tue, Feb 05, 2019 at 04:21:16PM -0800, Jonathan Tan wrote:
> Some tests check that fetching an unreachable object fails, but protocol
> v2 allows such fetches. Unset GIT_TEST_PROTOCOL_VERSION so that these
> tests are always run using protocol v0.
I think this is reasonable, but just musing on
Welcome to the community!
Here are some documents that can help you get started:
- INSTALL
- Documentation/CodingGuidelines
- Documentation/howto/maintain-git.txt
- t/README
- Documentation/SubmittingPatches
On Sun, 10 Feb 2019 at 17:52, Fabio Aiuto wrote:
>
> Hallo to the whole git community,
>
On Mon, Feb 11, 2019 at 11:20:54AM -0800, Jonathan Tan wrote:
> > In the case of proxy_request(), we don't know ahead of time whether the
> > request is large or not; we just proxy the data through. And we don't do
> > the probe thing at all. So wouldn't we dropping some data for the
> > follow-up
"Randall S. Becker" writes:
> Hi All,
>
> I found this while trying to track down a hang in t5562 - this isn't the
> fix, but here it is something that could be considered a code-inspection. If
> there have been random unexplained hangs when git runs as a daemon, this
> might be the cause.
>
> Ac
Jean-Noël Avila writes:
> On 11 février 2019, Jiang Xin wrote:
>
>> Jean-Noël Avila 于2019年2月11日周一 下午2:48写道：
>>> Signed-off-by: Jean-Noël Avila
>>> ---
>>> builtin/bisect--helper.c | 4 ++--
>>> builtin/fetch.c | 2 +-
>>> builtin/rebase.c | 2 +-
>>> 3 files changed, 4 inserti
randall.s.bec...@rogers.com writes:
> From: "Randall S. Becker"
>
> The NonStop platform needs this configuration item specified as
> UnfortunatelyYes so that config directory files are correctly processed.
>
> Signed-off-by: Randall S. Becker
> ---
> config.mak.uname | 1 +
> 1 file changed, 1
Duy Nguyen writes:
> On Mon, Feb 11, 2019 at 2:09 AM Randall S. Becker
> wrote:
>>
>> Hi All,
>>
>> I tracked down a breakage in t1404 subtest 52. The line
>>
>> test_i18ngrep "Unable to create $Q.*packed-refs.lock$Q: File exists" err
>
> The message does not match, does it? Here we grep for "Fi
Ramsay Jones writes:
> This has been hanging around for a while. I sent it to the list last
> time in [1], but it seems to have been dropped. (Found while attempting
> to rebase loads of old branches to a newer base!)
Thanks. Will apply.
Hi,
I am trying to use a pre-commit hook to modify files before they are
to be committed. The problem I am running into is that if I use "git
commit --verbose", which I often do so that I can see the diff, the
diff it displays in the editor is the diff before the pre-commit hook
was run rather tha
The setup code uses octal values with printf to generate a BOM for
UTF-16/32 BE/LE. It specifically uses '\777' to emit a 0xff byte. This
relies on the fact that most shells truncate the value above 0o377.
Ash however interprets '\777' as '\77' + a literal '7', resulting in an
invalid BOM.
Fix th
On Mon, Feb 11, 2019 at 01:26:39AM +, brian m. carlson wrote:
> When serializing UTF-16 (and UTF-32), there are three possible ways to
> write the stream. One can write the data with a BOM in either big-endian
> or little-endian format, or one can write the data without a BOM in
> big-endian fo
On February 11, 2019 15:57, Junio C Hamano wrote:
> "Randall S. Becker" writes:
>
> > Hi All,
> >
> > I found this while trying to track down a hang in t5562 - this isn't
> > the fix, but here it is something that could be considered a
> > code-inspection. If there have been random unexplained ha
On February 11, 2019 16:07, Junio C Hamano wrote:
> Duy Nguyen writes:
>
> > On Mon, Feb 11, 2019 at 2:09 AM Randall S. Becker
> > wrote:
> >>
> >> Hi All,
> >>
> >> I tracked down a breakage in t1404 subtest 52. The line
> >>
> >> test_i18ngrep "Unable to create $Q.*packed-refs.lock$Q: File exi
Signed-off-by: Ismael Luceno
---
git-gui.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/git-gui.sh b/git-gui.sh
index 5bc21b878d41..e00d9a345294 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -3788,6 +3788,8 @@ bind $ui_comm <$M1B-Key-KP_Subtract>
{show_less_context;break}
bind $ui_comm
Signed-off-by: Ismael Luceno
---
git-gui.sh | 33 ++---
lib/option.tcl | 16
2 files changed, 38 insertions(+), 11 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index e00d9a345294..01e5462dc70e 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -903,
At the time you see the diff the committing of changes has not yet been
initiated. It's only after you type in the message that the ACTUAL committing
starts and the hook runs.
You can print the diff of what your hook has changed by running "git diff" in
it before adding changes.
12.02.2019, 00
On 02/11, Christian Couder wrote:
> On Thu, Feb 7, 2019 at 10:33 PM Thomas Gummerer wrote:
> >
> > On 02/07, Johannes Schindelin wrote:
> > > On Wed, 6 Feb 2019, Thomas Gummerer wrote:
> > > > - implement pushing/poping conflicted state
> > > >
> > > >This would obviously be the end goal.
> >
SZEDER Gábor writes:
> Use a '!' character to start a non-matching pattern bracket
> expression, as specified by POSIX in Shell Command Language section
> 2.13.1 Patterns Matching a Single Character [1].
>
> I used '^' instead in three places in the previous three commits, to
Ah, thanks for catc
Kevin Daudt writes:
> The setup code uses octal values with printf to generate a BOM for
> UTF-16/32 BE/LE. It specifically uses '\777' to emit a 0xff byte. This
> relies on the fact that most shells truncate the value above 0o377.
>
> Ash however interprets '\777' as '\77' + a literal '7', resul
Пересылаемое сообщение
12.02.2019, 01:54, "Sergey Lukashev" :
Indeed. Sorry, this was how I thought it works.
So the hook runs even if the commit is cancelled. A bit odd.
Then let's have someone else from git list to answer your question.
12.02.2019, 01:11, "Fernando Chorne
"Jeff Hostetler via GitGitGadget" writes:
> From: Jeff Hostetler
>
> Guard against infinite loop while computing the parent process hierarchy.
>
> CreateToolhelp32Snapshot() is used to get a list of all processes on the
> system. Each process entry contains the process PID and PPID (alive at th
On Thu, Feb 7, 2019 at 7:28 AM Junio C Hamano wrote:
>
> * du/branch-show-current (2018-10-26) 1 commit - branch: introduce
> --show-current display option
>
> "git branch" learned a new subcommand "--show-current".
>
> Will merge to 'next'.
>
Did something change? I may have missed it. Until l
Hi, everyone
I've been contributing to the Linux Kernel for the past semester and
I'm now looking to take my first steps in the git community. I'm also
interested in GSoC 2019.
I started looking at https://git.github.io/SoC-2019-Microprojects/ and
one that got my attention was "Move ~/.git-creden
On Mon, Feb 11, 2019 at 08:58:03PM +0100, SZEDER Gábor wrote:
> Use a '!' character to start a non-matching pattern bracket
> expression, as specified by POSIX in Shell Command Language section
> 2.13.1 Patterns Matching a Single Character [1].
Just when I think I know every little gotcha in the
The bug:
git init worktree-test-repo
git --git-dir=worktree-test-repo/.git commit --allow-empty -m "first commit"
git --git-dir=worktree-test-repo/.git branch branch1
git --git-dir=worktree-test-repo/.git branch branch2
mkdir unique-path-1 unique-path-2
cd unique-path-1
git --git-dir=
In 7171d8c15f ("upload-pack: send symbolic ref information as
capability"), we added a symref capability to the pack protocol, but it
was never documented. Adapt the patch notes from that commit and add
them to the capabilities documentation.
Signed-off-by: Josh Steadmon
---
Documentation/techni
On Mon, Feb 11, 2019 at 10:43:06PM +0100, Kevin Daudt wrote:
> With some additional fixes, this indeed does solve the issue for Alpine
> Linux, thanks.
>
> I had to fix the following as well:
>
> iff --git a/t/t0028-working-tree-encoding.sh
> b/t/t0028-working-tree-encoding.sh
> index 8936ba6757
Josh Steadmon wrote:
> In 7171d8c15f ("upload-pack: send symbolic ref information as
> capability"), we added a symref capability to the pack protocol, but it
> was never documented. Adapt the patch notes from that commit and add
> them to the capabilities documentation.
>
> Signed-off-by: Josh St
On Mon, Feb 11, 2019 at 11:18 PM Thomas Gummerer wrote:
>
> On 02/11, Christian Couder wrote:
> > Historically though we have always been very optimistic in what we
> > thought a student could accomplish in a GSoC. And we are very likely
> > to find more ideas for improvements during the GSoC, in
On Mon, Feb 11, 2019 at 09:45:21PM -0200, Matheus Tavares Bernardino wrote:
> I've been contributing to the Linux Kernel for the past semester and
> I'm now looking to take my first steps in the git community. I'm also
> interested in GSoC 2019.
Hi, and welcome!
> I started looking at https://gi
On Mon, Feb 11, 2019 at 03:52:24PM -0800, Josh Steadmon wrote:
> In 7171d8c15f ("upload-pack: send symbolic ref information as
> capability"), we added a symref capability to the pack protocol, but it
> was never documented. Adapt the patch notes from that commit and add
> them to the capabilities
On 2019.02.11 19:05, Jeff King wrote:
> On Mon, Feb 11, 2019 at 03:52:24PM -0800, Josh Steadmon wrote:
>
> > In 7171d8c15f ("upload-pack: send symbolic ref information as
> > capability"), we added a symref capability to the pack protocol, but it
> > was never documented. Adapt the patch notes fro
Hi,
On Tue, Feb 12, 2019 at 12:48 AM Matheus Tavares Bernardino
wrote:
>
> Hi, everyone
>
> I've been contributing to the Linux Kernel for the past semester and
> I'm now looking to take my first steps in the git community. I'm also
> interested in GSoC 2019.
Thanks for your interest in Git!
>
On Mon, Feb 11, 2019 at 10:00 PM Jeff King wrote:
>
> On Mon, Feb 11, 2019 at 09:45:21PM -0200, Matheus Tavares Bernardino wrote:
>
> > I've been contributing to the Linux Kernel for the past semester and
> > I'm now looking to take my first steps in the git community. I'm also
> > interested in G
On Mon, Feb 11, 2019 at 10:09 PM Christian Couder
wrote:
>
> Hi,
>
> On Tue, Feb 12, 2019 at 12:48 AM Matheus Tavares Bernardino
> wrote:
> >
> > Hi, everyone
> >
> > I've been contributing to the Linux Kernel for the past semester and
> > I'm now looking to take my first steps in the git communi
On Mon, Feb 11, 2019 at 01:07:15PM -0800, Junio C Hamano wrote:
> >> test_i18ngrep "Unable to create $Q.*packed-refs.lock$Q: File exists" err
> >
> > The message does not match, does it? Here we grep for "File exists"
> > but the message you showed says "File already exists".
>
> Hmph, this is fr
On Mon, Feb 11, 2019 at 10:42:03PM +0100, Ismael Luceno wrote:
> Signed-off-by: Ismael Luceno
> ---
> git-gui.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/git-gui.sh b/git-gui.sh
> index 5bc21b878d41..e00d9a345294 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -3788,6 +3788,8
On Mon, Feb 11, 2019 at 06:46:26PM -0500, Jeff King wrote:
> On Mon, Feb 11, 2019 at 08:58:03PM +0100, SZEDER Gábor wrote:
>
> > Use a '!' character to start a non-matching pattern bracket
> > expression, as specified by POSIX in Shell Command Language section
> > 2.13.1 Patterns Matching a Single
"brian m. carlson" writes:
>> - cat lf.utf8.raw | iconv -f UTF-8 -t UTF-${i} >lf.utf${i}.raw &&
>> - cat crlf.utf8.raw | iconv -f UTF-8 -t UTF-${i} >crlf.utf${i}.raw &&
>> + cat lf.utf8.raw | eval "write_utf${i}" >lf.utf${i}.raw &&
>> + cat crlf.utf8.raw | eval "write_utf$
On Mon, Feb 11, 2019 at 10:23:25PM -0200, Matheus Tavares Bernardino wrote:
> > > For the microproject "Add configuration options for some commonly used
> > > command-line options", are there some options already known to be good
> > > for adding to configuration file?
> >
> > Hmm. I don't offhand
Jeff King writes:
> Hmm. We care to _some_ degree, since that's the condition we set up for
> making sure that update-ref cannot take the lock. But it would probably
> be fine to just confirm that we failed to take the lock. And there,
> checking for just "Unable to create $Q.*packed-refs.lock" w
On Tue, Feb 12, 2019 at 01:30:18AM +0100, SZEDER Gábor wrote:
> > I learn
> > another one. :) Thanks for fixing this, and for digging up the POSIX
> > reference.
>
> I had to, that 16.04's dash worked, but neither dash in older LTS nor
> newer upstream version did was particularly puzzling. Turn
On Mon, Feb 11, 2019 at 04:32:52PM -0800, Junio C Hamano wrote:
> Jeff King writes:
>
> > Hmm. We care to _some_ degree, since that's the condition we set up for
> > making sure that update-ref cannot take the lock. But it would probably
> > be fine to just confirm that we failed to take the loc
On Sat, Feb 09, 2019 at 09:05:04PM -0500, Eric Sunshine wrote:
> On Sat, Feb 9, 2019 at 1:59 PM wrote:
> > t5318 and t5562 used /dev/zero, which is not portable. This function
> > provides both a fixed block of NUL bytes and an infinite stream of NULs.
> >
> > Signed-off-by: Randall S. Becker
>
On Sun, Feb 10, 2019 at 07:35:38PM +, Ramsay Jones wrote:
> > Now, the 'n-byte type and length' is a variable length encoding of
> > the object type and length. The number of bytes used to encode this
> > data is content dependant. If the top bit of a byte is set, then we
> > need to process t
On Sat, Feb 09, 2019 at 03:06:05PM +0100, SZEDER Gábor wrote:
> On Thu, Feb 07, 2019 at 10:17:44PM -0500, Todd Zullinger wrote:
> > Looking through the build logs for the fedora git packages, I noticed it
> > was missing the GPGSM prereq.
>
> Just curious: how did you noticed the missing GPGSM pr
When serializing UTF-16 (and UTF-32), there are three possible ways to
write the stream. One can write the data with a BOM in either big-endian
or little-endian format, or one can write the data without a BOM in
big-endian format.
Most systems' iconv implementations choose to write it with a BOM i
On Mon, Feb 11, 2019 at 04:31:00PM -0800, Junio C Hamano wrote:
> "brian m. carlson" writes:
>
> >> - cat lf.utf8.raw | iconv -f UTF-8 -t UTF-${i} >lf.utf${i}.raw &&
> >> - cat crlf.utf8.raw | iconv -f UTF-8 -t UTF-${i} >crlf.utf${i}.raw &&
> >> + cat lf.utf8.raw | eval "write_u
On Mon, Feb 11, 2019 at 7:37 PM Jeff King wrote:
> On Sat, Feb 09, 2019 at 09:05:04PM -0500, Eric Sunshine wrote:
> > On Sat, Feb 9, 2019 at 1:59 PM wrote:
> > > +generate_zero_bytes () {
> > > + perl -e 'if ($ARGV[0] == "infinity") {
> >
> > s/perl/"$PERL_PATH"/
>
> This shouldn't be neces
Instead of using a specific invalid hard-coded object ID, produce one
of the appropriate length by using test_oid.
Signed-off-by: brian m. carlson
---
t/lib-submodule-update.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/lib-submodule-update.sh b/t/lib-submodule-updat
Increase the checksum field in struct bitmap_disk_header to be
GIT_MAX_RAWSZ bytes in length and ensure that we hash the proper number
of bytes out when computing the bitmap checksum.
Signed-off-by: brian m. carlson
---
pack-bitmap-write.c | 2 +-
pack-bitmap.c | 2 +-
pack-bitmap.h
This is the sixteenth series of hash function transition patches. This
series contains various fixes, mostly focused around the pack bitmap
code, the HTTP code, the archive code, the index, and parts of our Perl
code.
This is the second to last series required for a "stage 0" Git; that is,
one tha
Use the_hash_algo when parsing instead of GIT_SHA1_HEXSZ so that this
function works with any size hash. Rename the variable forty to
counter, as this is a better name and is independent of the hash size.
Signed-off-by: brian m. carlson
---
builtin/name-rev.c | 14 --
1 file changed
Replace the uses of sha1_to_hex in this function with hash_to_hex to
allow the use of SHA-256 as well. Rename some variables since this code
is no longer limited to SHA-1.
Signed-off-by: brian m. carlson
---
notes.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
Switch from using GIT_SHA1_HEXSZ to GIT_MAX_HEXSZ and the_hash_algo so
that the code works with any hash algorithm.
Signed-off-by: brian m. carlson
---
notes-merge.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/notes-merge.c b/notes-merge.c
index 280aa8e6c1..2fe724f1
Convert struct stored_bitmap to use struct object_id.
Signed-off-by: brian m. carlson
---
pack-bitmap.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/pack-bitmap.c b/pack-bitmap.c
index b53f37243c..c760913cea 100644
--- a/pack-bitmap.c
+++ b/pack-bitmap.c
@@ -18,7 +
Instead of using get_oid_hex and GIT_SHA1_HEXSZ, use parse_oid_hex to
avoid the need for a constant and simplify the code.
Signed-off-by: brian m. carlson
---
builtin/pull.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/builtin/pull.c b/builtin/pull.c
index 701d1473dc.
Instead of using GIT_SHA1_HEXSZ, switch to using the_hash_algo and
parse_oid_hex to parse the lines involved in rebasing notes.
Signed-off-by: brian m. carlson
---
builtin/am.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/builtin/am.c b/builtin/am.c
index 58a2aef2
This member is used to represent the pack checksum of the pack in
question. Expand this member to be GIT_MAX_RAWSZ bytes in length so it
works with longer hashes and rename it to be "hash" instead of "sha1".
This transformation was made with a change to the definition and the
following semantic pa
Replace a hard-coded 40 with a reference to the_hash_algo.
Signed-off-by: brian m. carlson
---
http.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/http.c b/http.c
index a09adc518f..993ddc956a 100644
--- a/http.c
+++ b/http.c
@@ -2065,7 +2065,7 @@ int http_fetch_ref(const c
Instead of using hard-coded 40-based constants, express these values in
terms of the_hash_algo and GIT_MAX_HEXSZ.
Signed-off-by: brian m. carlson
---
merge-recursive.c | 2 +-
submodule.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/merge-recursive.c b/merge-recur
Switch two hard-coded uses of 20 to references to the_hash_algo.
Signed-off-by: brian m. carlson
---
pack-bitmap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pack-bitmap.c b/pack-bitmap.c
index 6d6fa68563..603492c237 100644
--- a/pack-bitmap.c
+++ b/pack-bitmap.c
@@
Switch the lock token code to use the_hash_algo and increase its buffers
to be allocated using GIT_MAX_* constants. Update the parsing of object
paths to use the_hash_algo as well.
Signed-off-by: brian m. carlson
---
http-push.c | 20 ++--
1 file changed, 10 insertions(+), 10 de
Replace the uses of sha1_to_hex in this function with hash_to_hex to
allow the use of SHA-256 as well. Rename a variable since it is no
longer limited to SHA-1.
Signed-off-by: brian m. carlson
---
fast-import.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fast-import.
Instead of using a struct with a flex array member to read and write the
untracked cache extension, use a shorter, fixed-length struct and add
the name and hash data explicitly.
Signed-off-by: brian m. carlson
---
dir.c | 28 ++--
1 file changed, 14 insertions(+), 14 dele
Replace the uses of sha1_to_hex in the pack bitmap code with hash_to_hex
to allow the use of SHA-256 as well. Rename a few variables since they
are no longer limited to SHA-1.
Signed-off-by: brian m. carlson
---
pack-bitmap-write.c | 6 +++---
pack-bitmap.c | 8
2 files changed,
Since sha1_to_hex is limited to SHA-1, switch all remaining uses of it
in this file to hash_to_hex or oid_to_hex. Modify update_remote to take
a pointer to struct object_id, and since we don't modify that parameter
in the function, set it to be const as well.
Signed-off-by: brian m. carlson
---
Gitweb has several hard-coded 40 values throughout it to check for
values that are passed in or acquired from Git. To simplify the code,
introduce a regex variable that matches either exactly 40 or exactly 64
hex characters, and use this variable anywhere we would have previously
hard-coded a 40 i
Instead of using get_oid_hex and adding constants to the result, use
parse_oid_hex to make this code independent of the hash size.
Signed-off-by: brian m. carlson
---
builtin/difftool.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/builtin/difftool.c b/builtin/difftoo
Signed-off-by: brian m. carlson
---
http.c | 10 +-
http.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/http.c b/http.c
index 993ddc956a..458d07fabb 100644
--- a/http.c
+++ b/http.c
@@ -2337,8 +2337,8 @@ static size_t fwrite_sha1_file(char *ptr, size_t eltsize,
Make the tar generation code hash size independent by using
the_hash_algo. Make the tar parsing code compute the header value based
on the hash algorithm in use. Update a variable name and switch to
hash_to_hex.
Signed-off-by: brian m. carlson
---
archive-tar.c | 7 ---
built
1 - 100 of 131 matches
Mail list logo
