On Mon, Feb 11, 2019 at 01:07:15PM -0800, Junio C Hamano wrote: > >> test_i18ngrep "Unable to create $Q.*packed-refs.lock$Q: File exists" err > > > > The message does not match, does it? Here we grep for "File exists" > > but the message you showed says "File already exists". > > Hmph, this is from strerror(), right? > > The question is if we should be using grep to match on strerror() > result in the C locale.
Yeah, I agree that's questionable. And I'm mildly surprised it hasn't been a problem before now. > Do we really care that the reason of the > failure is due to EEXIST for this particular test? Hmm. We care to _some_ degree, since that's the condition we set up for making sure that update-ref cannot take the lock. But it would probably be fine to just confirm that we failed to take the lock. And there, checking for just "Unable to create $Q.*packed-refs.lock" would be sufficient. -Peff
