Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability

2012-10-09 Thread Joachim Schmitz
Junio C Hamano wrote: Junio C Hamano writes: Ben Walton writes: Avoid a GNU-ism in the cp options used by t5400-send-pack. Change -a to -pR. Signed-off-by: Ben Walton --- Thanks, but is "-p" essential for this test to pass, or can we get away with just "-R"? Besides, when you spot a

Re: [PATCH 8/8] Support "**" wildcard in .gitignore and .gitattributes

2012-10-09 Thread Michael Haggerty
I like how this series is going and it's going to be a nice new feature. Some comments... It would be helpful if you would use --subject-prefix='PATCH v3' etc. to help spectators keep track of the different versions of your patch series. On 10/09/2012 05:09 AM, Nguyễn Thái Ngọc Duy wrote:

[PATCH/RFC] svn test: escape peg revision separator using empty peg rev

2012-10-09 Thread Jonathan Nieder
This test script uses "svn cp" to create a branch with an @-sign in its name: svn cp "pr ject/trunk" "pr ject/branches/not-a@{0}reflog" That sets up for later tests that fetch the branch and check that git svn mangles the refname appropriately. Unfortunately, modern svn versions interpre

'git grep needle rev' attempts to access 'rev:.../.gitattributes' in the worktree

2012-10-09 Thread Johannes Sixt
Running 'git grep needle origin/master' on Windows gives numerous warnings of the kind warning: unable to access 'origin/master:Documentation/.gitattributes': Invalid argument It is worrysome that it is attempted to access a file whose name is prefixed by a revision. -- Hannes -- To unsubscribe

Re: git checkout error

2012-10-09 Thread Andreas Schwab
Angelo Borsotti writes: > If they are specified after -b, the command seems to behave as if -b > was not specified, e.g.: > > $ git checkout -b --no-track topic remotes/origin/master -b requires an argument , which you specify as --no-track here. is topic, and the rest is interpreted as . > f

gitweb bug: Existence if hidden repositories is leaked

2012-10-09 Thread Ralf Jung
Hi list, I am using gitweb, git-daemon and gitolite on my Debian Squeeze server. I have some repositories however that I do not want to be available to the public (currently, that is gitolite-admin only). Those repositories do not have a "git-daemon-export-ok" file, and the gitweb config contains

Re: 'git grep needle rev' attempts to access 'rev:.../.gitattributes' in the worktree

2012-10-09 Thread Nguyen Thai Ngoc Duy
On Tue, Oct 9, 2012 at 4:03 PM, Johannes Sixt wrote: > Running 'git grep needle origin/master' on Windows gives numerous warnings > of the kind > > warning: unable to access 'origin/master:Documentation/.gitattributes': > Invalid argument strace confirms it. Stack trace #0 read_attr_from_file (

Re: [PATCH/RFC] svn test: escape peg revision separator using empty peg rev

2012-10-09 Thread Michael J Gruber
Jonathan Nieder venit, vidit, dixit 09.10.2012 10:41: > This test script uses "svn cp" to create a branch with an @-sign in > its name: > > svn cp "pr ject/trunk" "pr ject/branches/not-a@{0}reflog" > > That sets up for later tests that fetch the branch and check that git > svn mangles the r

[PATCH/RFC v2] git svn: work around SVN 1.7 mishandling of svn:special changes

2012-10-09 Thread Jonathan Nieder
Subversion represents symlinks as ordinary files with content starting with "link " and the svn:special property set to "*". Thus a file can switch between being a symlink and a non-symlink simply by toggling its svn:special property, and new checkouts will automatically write a file of the approp

Re: [PATCH/RFC] svn test: escape peg revision separator using empty peg rev

2012-10-09 Thread Jonathan Nieder
Michael J Gruber wrote: > Jonathan Nieder venit, vidit, dixit 09.10.2012 10:41: >> Signed-off-by: Jonathan Nieder > > Tested with Subversion 1.6.18. [...] > I haven't checked other svn versions but this approach looks perfectly > sensible. It makes us test branch names which can't even be created

Re: 'git grep needle rev' attempts to access 'rev:.../.gitattributes' in the worktree

2012-10-09 Thread Nguyen Thai Ngoc Duy
On Tue, Oct 09, 2012 at 04:38:32PM +0700, Nguyen Thai Ngoc Duy wrote: > #5 0x0815e736 in userdiff_find_by_path (path=0x820e7f0 > "HEAD:Documentation/.gitattributes") at userdiff.c:278 > #6 0x081058ca in grep_source_load_driver (gs=0xbfffd978) at grep.c:1504 A bandage patch may look like this. Bu

Re: [PATCH] MALLOC_CHECK: Allow checking to be disabled from config.mak

2012-10-09 Thread Christian Couder
Hi, On Mon, Oct 8, 2012 at 3:19 PM, Elia Pinto wrote: > Ok. I have found. For me this is not a problem any more these days. > Was fixed in glibc 2.8.90-9 2008 > > * Wed Jul 16 2008 Jakub Jelinek 2.8.90-9 > - update from trunk > - fix unbuffered vfprintf if writing to the stream fails (#455360)

Re: 'git grep needle rev' attempts to access 'rev:.../.gitattributes' in the worktree

2012-10-09 Thread Jeff King
On Tue, Oct 09, 2012 at 07:01:44PM +0700, Nguyen Thai Ngoc Duy wrote: > On Tue, Oct 09, 2012 at 04:38:32PM +0700, Nguyen Thai Ngoc Duy wrote: > > #5 0x0815e736 in userdiff_find_by_path (path=0x820e7f0 > > "HEAD:Documentation/.gitattributes") at userdiff.c:278 > > #6 0x081058ca in grep_source_loa

Re: Git ~unusable on slow lines :,'C

2012-10-09 Thread Marcel Partap
>> Bam, the server kicked me off after taking to long to sync my copy. > This is unrelated to git. The HTTP server's configuration is too > impatient. Yes. How does that mean it is unrelated to git? >> - git fetch should show the total amount of data it is about to >> transfer! > It can't, because

[PATCH] configure.ac: Add missing comma to CC_LD_DYNPATH

2012-10-09 Thread Øyvind A . Holm
From: "Øyvind A. Holm" 40bfbde ("build: don't duplicate substitution of make variables", 2012-09-11) breaks make by removing a necessary comma at the end of "CC_LD_DYNPATH=-rpath" in line 414. When executing "./configure --with-zlib=PATH", this resulted in [...] CC xdiff/xhistogram.

Re: Discussion around a --bindtodev option for git-daemon

2012-10-09 Thread Jan Engelhardt
On Wednesday 2012-09-26 18:36, Ronan Bignaux wrote: >I wrote this little patch to add a restrict option to bind only to a >specific network interface. > >I'd not deal with --inetd since there are some bugs in xinetd with ipv6 >( and no more maintener ) , systemd/upstart are also Linux centric and

Re: Git ~unusable on slow lines :,'C

2012-10-09 Thread Shawn Pearce
On Tue, Oct 9, 2012 at 7:06 AM, Marcel Partap wrote: >>> Bam, the server kicked me off after taking to long to sync my copy. >> This is unrelated to git. The HTTP server's configuration is too >> impatient. > Yes. How does that mean it is unrelated to git? It means its out of our control, we cann

[PATCH] configure.ac: Add missing comma to CC_LD_DYNPATH

2012-10-09 Thread Øyvind A . Holm
From: "Øyvind A. Holm" 40bfbde ("build: don't duplicate substitution of make variables", 2012-09-11) breaks make by removing a necessary comma at the end of "CC_LD_DYNPATH=-rpath" in line 414 and 423. When executing "./configure --with-zlib=PATH", this resulted in [...] CC xdiff/xhi

Re: [PATCH nd/attr-match-optim-more 2/2] attr: more matching optimizations from .gitignore

2012-10-09 Thread Junio C Hamano
Junio C Hamano writes: > Johannes Sixt writes: > >> Am 10/9/2012 7:08, schrieb Junio C Hamano: >>> Imagine if we allowed only one attribute per line, instead of >>> multiple attributes on one line. >>> >>> - If you want to unset the attribute, you would write "path -attr". >>> >>> - If y

Re: [PATCH] configure.ac: Add missing comma to CC_LD_DYNPATH

2012-10-09 Thread Øyvind A . Holm
Please discard the first patch, I reckon line 423 also should be changed. Sorry about the noise, Øyvind -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Git ~unusable on slow lines :,'C

2012-10-09 Thread Junio C Hamano
c...@elego.de (Carlos Martín Nieto) writes: > If you want to download it bit by bit, you can tell fetch to download > particular tags. Doing this automatically for this would be working > around a configuration issue for a particular server, which is generally > better fixed in other ways. As par

Re: Bug report

2012-10-09 Thread John Whitney
On 10/7/12 6:52 PM, Jeff King wrote: Yes, but does that really have to be an issue? Is there any technical or practical reason you can think of that the repository shouldn't ignore those CRs? It's significantly less efficient. Right now git only has to do the conversion when updating the index

Re: Git ~unusable on slow lines :,'C

2012-10-09 Thread Marcel Partap
- git fetch should show the total amount of data it is about to transfer! >>> It can't, because it doesn't know. >> The server side doesn't know at how much the objects *it just repacked >> for transfer* weigh in? > Actually it does. Then, please, make it display it. > What value is that

Re: [PATCH] configure.ac: Add missing comma to CC_LD_DYNPATH

2012-10-09 Thread Øyvind A . Holm
On 9 October 2012 19:05, Junio C Hamano wrote: > Øyvind A. Holm writes: > > 40bfbde ("build: don't duplicate substitution of make variables", > > 2012-09-11) breaks make by removing a necessary comma at the end of > > "CC_LD_DYNPATH=-rpath" in line 414 and 423. > > The earlier one is a cut-and-pa

git clone algorithm

2012-10-09 Thread Bogdan Cristea
I have already posted this message on git-us...@googlegroups.com but I have been advised to rather use this list. I know that there is a related thread (http://thread.gmane.org/gmane.comp.version-control.git/207257), but I don't think that this provides an answer to my question (me too I am on

Re: Git ~unusable on slow lines :,'C

2012-10-09 Thread Carlos Martín Nieto
Marcel Partap writes: >>> Bam, the server kicked me off after taking to long to sync my copy. >> This is unrelated to git. The HTTP server's configuration is too >> impatient. > Yes. How does that mean it is unrelated to git? > >>> - git fetch should show the total amount of data it is about to >

username case conflict in git svn clone

2012-10-09 Thread David Balch
Hi, Can anyone help me with a username case conflict in git svn clone? Running `git svn clone svn://svn.example.com/project --no-metadata -A users.txt project` whenusers.txt contains: juser Joe User JUser Joe User returns: Initialized empty Git repository in /var/git/SCE/sce/.git/

Re: git checkout error

2012-10-09 Thread Junio C Hamano
Andreas Schwab writes: > Angelo Borsotti writes: > >> If they are specified after -b, the command seems to behave as if -b >> was not specified, e.g.: >> >> $ git checkout -b --no-track topic remotes/origin/master > > -b requires an argument , which you specify as --no-track > here. is topic,

Re: username case conflict in git svn clone

2012-10-09 Thread Andreas Schwab
David Balch writes: > whenusers.txt contains: > > juser Joe User > > JUser Joe User Reread the manual. Hint: there must be an equal sign. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something comple

Re: [PATCH] submodule: teach "foreach" command a --revision option

2012-10-09 Thread Junio C Hamano
Jay Soffian writes: > On Tue, Oct 9, 2012 at 2:12 AM, Junio C Hamano wrote: >> Junio C Hamano writes: >> >>> Assuming that the above guess is correct (which is a huge >>> assumption, given the lack of clarity in the description), I think >>> the feature might make sense. The example would have

Re: 'git grep needle rev' attempts to access 'rev:.../.gitattributes' in the worktree

2012-10-09 Thread Junio C Hamano
Jeff King writes: > I think we just need to have callers of grep_source_init provide us with > the actual pathname (or NULL, in the case of GREP_SOURCE_BUF). That is > where the information is lost. Yes. I agree that is the right approach. -- To unsubscribe from this list: send the line "unsubs

Re: Bug report

2012-10-09 Thread John Whitney
On 10/9/12 12:17 PM, John Whitney wrote: Thank you very much for your detailed explanations. I suspected that efficiency concerns might be preventing a clean solution. How about this idea... When git stores files, it could include a bit of metadata that tells it whether the file is a binary bl

Inconsistency in specifying commit & path for git diff

2012-10-09 Thread Arthur Etchells
git diff .. and git diff both succeed however git diff :..: fails while git diff : : succeeds OS X 10.7.5 git version 1.7.9.1 Reproduced by another user: http://stackoverflow.com/questions/12805004/git-cherry-pick-creates-blobs-not-commits#comment17319876_12805004 It seems logical to support

[PATCH] Add --unannotate option to git-subtree

2012-10-09 Thread James Nylen
This new option does the reverse of --annotate, which is more useful when contributing back to a library which is also included in the repository for a larger project, and perhaps in other situations as well. Rather than adding a marker to each commit when splitting out the commits back to the sub

Re: upload-pack is slow with lots of refs

2012-10-09 Thread Johannes Sixt
Am 09.10.2012 08:46, schrieb Shawn Pearce: > On Mon, Oct 8, 2012 at 8:05 AM, Johannes Sixt wrote: >> Am 05.10.2012 18:57, schrieb Shawn Pearce: >>> Smart HTTP is not bidirectional. The client can't cut off the server. >> >> Smart HTTP does not need it: you already posted a better solution (I'm >>

Re: Inconsistency in specifying commit & path for git diff

2012-10-09 Thread Andreas Schwab
Arthur Etchells writes: > git diff :..: : represents a tree or blob, but .. requires commits as its end points. (You can dereference a commit to get a tree or blob, but not the other way round.) Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756

Re: upload-pack is slow with lots of refs

2012-10-09 Thread Johannes Sixt
Am 09.10.2012 22:30, schrieb Johannes Sixt: > Am 09.10.2012 08:46, schrieb Shawn Pearce: >> As it turns out we don't really have this problem with git://. Clients >> can bury a v2 request in the extended headers where the host line >> appears today. > > I tried, but it seems that todays git-daemon

Re: [PATCH 4/8] wildmatch: remove static variable force_lower_case

2012-10-09 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > diff --git a/wildmatch.c b/wildmatch.c > index 7b64a6b..2382873 100644 > --- a/wildmatch.c > +++ b/wildmatch.c > @@ -11,8 +11,8 @@ > > #include > #include > -#include > > +#include "cache.h" > #include "wildmatch.h" This is wrong; the includes from the s

Re: Inconsistency in specifying commit & path for git diff

2012-10-09 Thread Junio C Hamano
Arthur Etchells writes: > git diff .. > and > git diff > both succeed > however > git diff :..: > fails while > git diff : : > succeeds > ... > It seems logical to support the '..' syntax in both for consistency. "git diff A..B" is an illogical thing to say in the first place. It only happens

Re: [PATCH] configure.ac: Add missing comma to CC_LD_DYNPATH

2012-10-09 Thread Stefano Lattarini
[Re-sending because I forgot to CC: the list, sorry] On 10/09/2012 06:36 PM, Øyvind A. Holm wrote: > From: "Øyvind A. Holm" > > 40bfbde ("build: don't duplicate substitution of make variables", > 2012-09-11) > Oops, stupid copy and paste error on my part. Sorry. > breaks make by removing a nece

Re: [PATCH] submodule: teach "foreach" command a --revision option

2012-10-09 Thread Jens Lehmann
Am 09.10.2012 20:24, schrieb Junio C Hamano: > Jay Soffian writes: > >> On Tue, Oct 9, 2012 at 2:12 AM, Junio C Hamano wrote: >>> Junio C Hamano writes: >>> Assuming that the above guess is correct (which is a huge assumption, given the lack of clarity in the description), I think >>>

Re: [PATCH 2/2] git-send-email: use locale encoding for compose

2012-10-09 Thread Junio C Hamano
Krzysztof Mazur writes: > The introduction email (--compose option) use UTF-8 as default encoding. > The current locale encoding is much better default value. > > Signed-off-by: Krzysztof Mazur > --- > git-send-email.perl | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > >

Re: [PATCH] submodule: teach "foreach" command a --revision option

2012-10-09 Thread Jay Soffian
On Tue, Oct 9, 2012 at 5:21 PM, Jens Lehmann wrote: > Nothing I can think of right now, the above is a pretty good summary. > My gut feeling is that having "git submodule foreach --revision ..." > recurse through submodules whose work trees are out of sync is pretty > fragile and could easily lead

Re: [PATCH] submodule: teach "foreach" command a --revision option

2012-10-09 Thread Junio C Hamano
Jens Lehmann writes: > Am 09.10.2012 20:24, schrieb Junio C Hamano: > ... >> I think the right approach to implement this "recurse foreach in the >> superproject tree that is not checkout out to the working tree" >> feature should be: >> >> - Advertise it so that it is crystal clear that the co

Re: [PATCH 2/2] git-send-email: use locale encoding for compose

2012-10-09 Thread Krzysztof Mazur
On Tue, Oct 09, 2012 at 02:34:59PM -0700, Junio C Hamano wrote: > Krzysztof Mazur writes: > > > The introduction email (--compose option) use UTF-8 as default encoding. > > The current locale encoding is much better default value. > > > > These two patches make sense in general, but t9001.62 (--

Re: git checkout error

2012-10-09 Thread Angelo Borsotti
Hi Andreas, > > -b requires an argument , which you specify as --no-track > here. is topic, and the rest is interpreted as . > The man page describes --track and --no-track as "options". This is why a reader thinks that they can be specified in any order. It is also very counter-intuitive to thi

Re: git checkout error

2012-10-09 Thread Junio C Hamano
Angelo Borsotti writes: > The man page describes --track and --no-track as "options". But the problem you observed is *not* about --track or --no-track. It is about the "-b " option. You used the -b option that requires an argument, and as that argument, you gave a string "--no-track", as if y

Fwd: potential path traversal issue in v3 with wild repos

2012-10-09 Thread Sitaram Chamarty
oops; forgot to add the git list earlier. -- Forwarded message -- From: Sitaram Chamarty Date: Wed, Oct 10, 2012 at 5:15 AM Subject: potential path traversal issue in v3 with wild repos To: gitolite , gitolite-annou...@googlegroups.com Cc: Stephane Chazelas Hello all, I'm sorr

Re: git clone algorithm

2012-10-09 Thread Sitaram Chamarty
On Tue, Oct 9, 2012 at 10:53 PM, Bogdan Cristea wrote: > I have already posted this message on git-us...@googlegroups.com but I have > been > advised to rather use this list. I know that there is a related thread > (http://thread.gmane.org/gmane.comp.version-control.git/207257), but I don't > thi

git svn clone options

2012-10-09 Thread 乙酸鋰
Hi, I tried git svn clone --stdlayout --branch ABC but svn branches were missing (trunk was present), compared to the result of git svn clone --stdlayout Could you clarify --branch option, is it the same as --branches. I thought git clone has --branch option, so I tried this option for svn. Alos

Re: [PATCH 4/8] wildmatch: remove static variable force_lower_case

2012-10-09 Thread Nguyen Thai Ngoc Duy
On Wed, Oct 10, 2012 at 3:47 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> diff --git a/wildmatch.c b/wildmatch.c >> index 7b64a6b..2382873 100644 >> --- a/wildmatch.c >> +++ b/wildmatch.c >> @@ -11,8 +11,8 @@ >> >> #include >> #include >> -#include >> >> +#include "cache.h"

Re: 'git grep needle rev' attempts to access 'rev:.../.gitattributes' in the worktree

2012-10-09 Thread Nguyen Thai Ngoc Duy
On Wed, Oct 10, 2012 at 1:59 AM, Junio C Hamano wrote: > Jeff King writes: > >> I think we just need to have callers of grep_source_init provide us with >> the actual pathname (or NULL, in the case of GREP_SOURCE_BUF). That is >> where the information is lost. > > Yes. I agree that is the right

Re: [PATCH 4/8] wildmatch: remove static variable force_lower_case

2012-10-09 Thread Junio C Hamano
Nguyen Thai Ngoc Duy writes: > Git's ctype does not seem to be complete for wildmatch's use so > ctype.h is required. But that can be easily fixed later on. Until "later on", I cannot even compile the series. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a mess

Re: 'git grep needle rev' attempts to access 'rev:.../.gitattributes' in the worktree

2012-10-09 Thread Junio C Hamano
Nguyen Thai Ngoc Duy writes: > On Wed, Oct 10, 2012 at 1:59 AM, Junio C Hamano wrote: >> Jeff King writes: >> >>> I think we just need to have callers of grep_source_init provide us with >>> the actual pathname (or NULL, in the case of GREP_SOURCE_BUF). That is >>> where the information is lost

Re: [PATCH 8/8] Support "**" wildcard in .gitignore and .gitattributes

2012-10-09 Thread Nguyen Thai Ngoc Duy
On Tue, Oct 9, 2012 at 2:57 PM, Michael Haggerty wrote: >> + - A trailing "/**" matches everything inside. For example, >> + "abc/**" is equivalent to "`/abc/`". > > It seems odd that you add a leading slash in this example. I assume > that is because of the rule that a pattern containing a sla

Re: 'git grep needle rev' attempts to access 'rev:.../.gitattributes' in the worktree

2012-10-09 Thread Nguyen Thai Ngoc Duy
On Wed, Oct 10, 2012 at 12:33 PM, Junio C Hamano wrote: > Nguyen Thai Ngoc Duy writes: > >> On Wed, Oct 10, 2012 at 1:59 AM, Junio C Hamano wrote: >>> Jeff King writes: >>> I think we just need to have callers of grep_source_init provide us with the actual pathname (or NULL, in the ca

Re: [PATCH 4/8] wildmatch: remove static variable force_lower_case

2012-10-09 Thread Nguyen Thai Ngoc Duy
On Wed, Oct 10, 2012 at 12:31 PM, Junio C Hamano wrote: > Nguyen Thai Ngoc Duy writes: > >> Git's ctype does not seem to be complete for wildmatch's use so >> ctype.h is required. But that can be easily fixed later on. > > Until "later on", I cannot even compile the series. So that's why you not