Junio C Hamano wrote:
Junio C Hamano <gits...@pobox.com> writes:

Ben Walton <bdwal...@gmail.com> writes:

Avoid a GNU-ism in the cp options used by t5400-send-pack.  Change
-a
to -pR.

Signed-off-by: Ben Walton <bdwal...@gmail.com>
---

Thanks, but is "-p" essential for this test to pass, or can we get
away with just "-R"?

Besides, when you spot a potential problem, please ask "git grep"
to catch them all.

   $ git grep "cp -a" t/
   t/t5400-send-pack.sh:   cp -a parent child &&
   t/t5550-http-fetch.sh:  cp -a
   .git"$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
t/t5800-remote-helpers.sh:      cp -a server server2 &&


There's 2 more places in Documentation/git-tutorial.txt. There it looks like we'd want to use 'cp -pR' instead

Bye, Jojo

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to