Re: [PATCH] submodule foreach: fix recursion of options

2019-06-25 Thread Junio C Hamano
Duy Nguyen writes: > On Tue, Jun 25, 2019 at 5:02 AM Morian Sonnet wrote: >> >> Calling >> >> git submodule foreach --recursive -- >> >> leads to an error stating that the option -- is unknown to >> submodule--helper. That is of course only, when is not a valid >> option for git submodule

Re: [PATCH] submodule foreach: fix recursion of options

2019-06-25 Thread Duy Nguyen
On Tue, Jun 25, 2019 at 5:02 AM Morian Sonnet wrote: > > Calling > > git submodule foreach --recursive -- > > leads to an error stating that the option -- is unknown to > submodule--helper. That is of course only, when is not a valid > option for git submodule foreach. > > The reason for thi

[PATCH] submodule foreach: fix recursion of options

2019-06-24 Thread Morian Sonnet
Calling git submodule foreach --recursive -- leads to an error stating that the option -- is unknown to submodule--helper. That is of course only, when is not a valid option for git submodule foreach. The reason for this is, that above call is internally translated into a call to submodule

submodule foreach: fix recursion of options

2019-06-24 Thread Morian Sonnet
Hi Junio, thanks for your comments. I fixed the type in the commit message and adapted my test case to the required shell script style. Best regards, Morian Junio C Hamano writes: > > Calling > > > > git submodule foreach --recursive -- > > > > leads to an error stating that the opti

Re: [PATCH] submodule foreach: fix recursion of options

2019-06-24 Thread Junio C Hamano
Morian Sonnet writes: > Calling > > git submodule foreach --recursive -- > > leads to an error stating that the option -- is unknown to > submodule--helper. That is of course only, when is not a valid > option for git submodule foreach. > > The reason for this is, that above call is interna

Re: [PATCH] submodule foreach: fix recursion of options

2019-06-24 Thread Johannes Schindelin
Hi Morian, On Mon, 24 Jun 2019, Morian Sonnet wrote: > Calling > > git submodule foreach --recursive -- > > leads to an error stating that the option -- is unknown to > submodule--helper. That is of course only, when is not a valid > option for git submodule foreach. > > The reason for this

[PATCH] submodule foreach: fix recursion of options

2019-06-24 Thread Morian Sonnet
Calling git submodule foreach --recursive -- leads to an error stating that the option -- is unknown to submodule--helper. That is of course only, when is not a valid option for git submodule foreach. The reason for this is, that above call is internally translated into a call to submodule

submodule foreach: fix recursion of options

2019-06-24 Thread Morian Sonnet
Using the right testing git now.

submodule foreach: fix recursion of options

2019-06-24 Thread Morian Sonnet
here comes the next version. > Johannes Schindelin wrote: > > Hi Morian, > > On Sat, 22 Jun 2019, Morian Sonnet wrote: > > > Johannes Schindelin wrote: > > > > > On Tue, 18 Jun 2019, Morian Sonnet wrote: > > > > > > > "Morian Sonnet via GitGitGadget" wrote: > > > > > > > > > Calling > > > >

[PATCH] submodule foreach: fix recursion of options

2019-06-24 Thread Morian Sonnet
Calling git submodule foreach --recursive -- leads to an error stating that the option -- is unknown to submodule--helper. That is of course only, when is not a valid option for git submodule foreach. The reason for this is, that above call is internally translated into a call to submodule

Re: [PATCH v2 1/1] submodule foreach: fix recursion of options

2019-06-24 Thread Johannes Schindelin
Hi Morian, On Sat, 22 Jun 2019, Morian Sonnet wrote: > Johannes Schindelin wrote: > > > On Tue, 18 Jun 2019, Morian Sonnet wrote: > > > > > "Morian Sonnet via GitGitGadget" wrote: > > > > > > > Calling > > > > > > > > git submodule foreach --recursive git reset --hard > > > > > > > > leads

Re: [PATCH v2 1/1] submodule foreach: fix recursion of options

2019-06-22 Thread Morian Sonnet
Johannes Schindelin wrote: Hello Johannes, thank your for the review. Sorry for the spam, I messed up with the replytoall command. > Hi Morian, > > On Tue, 18 Jun 2019, Morian Sonnet wrote: > > > "Morian Sonnet via GitGitGadget" wrote: > > > > > Calling > > > > > > git submodule foreach --

Re: [PATCH v2 1/1] submodule foreach: fix recursion of options

2019-06-19 Thread Johannes Schindelin
Hi Morian, On Tue, 18 Jun 2019, Morian Sonnet wrote: > "Morian Sonnet via GitGitGadget" wrote: > > > Calling > > > > git submodule foreach --recursive git reset --hard > > > > leads to an error stating that the option --hard is unknown to > > submodule--helper. > > > > Reasons: > > > > . Abo

Re: [PATCH v2 1/1] submodule foreach: fix recursion of options

2019-06-18 Thread Morian Sonnet
"Morian Sonnet via GitGitGadget" wrote: I fixed the problem with the test case. Please take another look. > From: Morian Sonnet > > Calling > > git submodule foreach --recursive git reset --hard > > leads to an error stating that the option --hard is unknown to > submodule--helper. > > Reas

[PATCH v2 0/1] submodule foreach: fix recursion of options

2019-06-12 Thread Morian Sonnet via GitGitGadget
Sonnet (1): submodule foreach: fix recursion of options builtin/submodule--helper.c | 1 + t/t7407-submodule-foreach.sh | 7 +++ 2 files changed, 8 insertions(+) base-commit: b697d92f56511e804b8ba20ccbe7bdc85dc66810 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-263

[PATCH v2 1/1] submodule foreach: fix recursion of options

2019-06-12 Thread Morian Sonnet via GitGitGadget
From: Morian Sonnet Calling git submodule foreach --recursive git reset --hard leads to an error stating that the option --hard is unknown to submodule--helper. Reasons: . Above call is internally translated into git submodule--helper foreach --recursive -- git reset --hard . After

Re: [PATCH 1/1] submodule foreach: fix recursion of options

2019-06-12 Thread Eric Sunshine
On Wed, Jun 12, 2019 at 2:10 PM Morian Sonnet via GitGitGadget wrote: > [...] > . Add -- before the command to execute, such that now correctly > > git --super-prefix submodule--helper \ > foreach --recursive -- git reset --hard > > is called. > > Signed-off-by: Morian Sonnet > --- >

[PATCH 0/1] submodule foreach: fix recursion of options

2019-06-12 Thread Morian Sonnet via GitGitGadget
Sonnet (1): submodule foreach: fix recursion of options builtin/submodule--helper.c | 1 + t/t7407-submodule-foreach.sh | 5 + 2 files changed, 6 insertions(+) base-commit: b697d92f56511e804b8ba20ccbe7bdc85dc66810 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-263%2Fmomoson

[PATCH 1/1] submodule foreach: fix recursion of options

2019-06-12 Thread Morian Sonnet via GitGitGadget
From: Morian Sonnet Calling git submodule foreach --recursive git reset --hard leads to an error stating that the option --hard is unknown to submodule--helper. Reasons: . Above call is internally translated into git submodule--helper foreach --recursive -- git reset --hard . After