Re: [PATCH] SubmittingPatches: update git-gui maintainer information

2019-10-01 Thread Pratyush Yadav
On 01/10/19 09:46AM, Denton Liu wrote: > Hi Pratyush, > > On Tue, Oct 01, 2019 at 07:44:35PM +0530, Pratyush Yadav wrote: > > Since I have taken over maintainership of git-gui, it is a good idea to > > point new contributors to my fork of the project, so they can see the > > latest version of the

Re: [PATCH] SubmittingPatches: update git-gui maintainer information

2019-10-01 Thread Denton Liu
Hi Pratyush, On Tue, Oct 01, 2019 at 07:44:35PM +0530, Pratyush Yadav wrote: > Since I have taken over maintainership of git-gui, it is a good idea to > point new contributors to my fork of the project, so they can see the > latest version of the project. > > Signed-off-by: Pratyush Yadav Junio

[PATCH] SubmittingPatches: update git-gui maintainer information

2019-10-01 Thread Pratyush Yadav
Since I have taken over maintainership of git-gui, it is a good idea to point new contributors to my fork of the project, so they can see the latest version of the project. Signed-off-by: Pratyush Yadav --- Documentation/SubmittingPatches | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

information

2019-09-24 Thread Meghan Alee Patterson
I have information for you. Get back to me urgently

[PATCH v3 13/15] merge-recursive: track information associated with directory renames

2019-04-05 Thread Elijah Newren
Directory rename detection previously silently applied. In order to allow printing information about paths that changed or printing a conflict notification (and only doing so near other potential conflict messages associated with the paths), save this information inside the rename struct for

[PATCH v2 13/15] merge-recursive: track information associated with directory renames

2019-03-29 Thread Elijah Newren
Directory rename detection previously silently applied. In order to allow printing information about paths that changed or printing a conflict notification (and only doing so near other potential conflict messages associated with the paths), save this information inside the rename struct for

[PATCH v7 03/15] trace2: collect Windows-specific process information

2019-02-22 Thread Jeff Hostetler via GitGitGadget
From: Jeff Hostetler Add platform-specific interface to log information about the current process. On Windows, this interface is used to indicate whether the git process is running under a debugger and list names of the process ancestors. Information for other platforms is left for a future

Re: [PATCH 1/1] fixup! trace2: collect Windows-specific process information

2019-02-15 Thread Jeff Hostetler
On 2/11/2019 6:19 PM, Junio C Hamano wrote: "Jeff Hostetler via GitGitGadget" writes: From: Jeff Hostetler Guard against infinite loop while computing the parent process hierarchy. ... --- compat/win32/trace2_win32_process_info.c | 32 ++-- 1 file changed, 25 inse

Re: [PATCH 1/1] fixup! trace2: collect Windows-specific process information

2019-02-11 Thread Junio C Hamano
"Jeff Hostetler via GitGitGadget" writes: > From: Jeff Hostetler > > Guard against infinite loop while computing the parent process hierarchy. > > CreateToolhelp32Snapshot() is used to get a list of all processes on the > system. Each process entry contains the process PID and PPID (alive at th

[PATCH 1/1] fixup! trace2: collect Windows-specific process information

2019-02-11 Thread Jeff Hostetler via GitGitGadget
From: Jeff Hostetler Guard against infinite loop while computing the parent process hierarchy. CreateToolhelp32Snapshot() is used to get a list of all processes on the system. Each process entry contains the process PID and PPID (alive at the time of the snapshot). We compute the set of ancest

[PATCH 0/1] fixup! trace2: collect Windows-specific process information

2019-02-11 Thread Jeff Hostetler via GitGitGadget
up! trace2: collect Windows-specific process information compat/win32/trace2_win32_process_info.c | 32 ++-- 1 file changed, 25 insertions(+), 7 deletions(-) base-commit: 878e2cd30e1656909c5073043d32fe9d02204daa Published-As: https://github.com/gitgitgadget/git/releases/

[PATCH v6 03/15] trace2: collect Windows-specific process information

2019-02-06 Thread Jeff Hostetler via GitGitGadget
From: Jeff Hostetler Add platform-specific interface to log information about the current process. On Windows, this interface is used to indicate whether the git process is running under a debugger and list names of the process ancestors. Information for other platforms is left for a future

[PATCH v5 03/15] trace2: collect Windows-specific process information

2019-02-01 Thread Jeff Hostetler via GitGitGadget
From: Jeff Hostetler Add platform-specific interface to log information about the current process. On Windows, this interface is used to indicate whether the git process is running under a debugger and list names of the process ancestors. Information for other platforms is left for a future

Re: [PATCH v4 03/14] trace2: collect platform-specific process information

2019-02-01 Thread Jeff Hostetler
On 1/31/2019 6:15 PM, SZEDER Gábor wrote: On Wed, Jan 30, 2019 at 12:56:24PM -0800, Jeff Hostetler via GitGitGadget wrote: Add optional platform-specific code to log information about the current process. On Windows, this includes whether git.exe is running under a debugger and information

Re: [PATCH v4 03/14] trace2: collect platform-specific process information

2019-01-31 Thread SZEDER Gábor
On Wed, Jan 30, 2019 at 12:56:24PM -0800, Jeff Hostetler via GitGitGadget wrote: > Add optional platform-specific code to log information about > the current process. > > On Windows, this includes whether git.exe is running under a > debugger and information about the ancestors

[PATCH v4 03/14] trace2: collect platform-specific process information

2019-01-30 Thread Jeff Hostetler via GitGitGadget
From: Jeff Hostetler Add optional platform-specific code to log information about the current process. On Windows, this includes whether git.exe is running under a debugger and information about the ancestors of the process. The purpose of this information is to help indicate if the process

[PATCH v3 03/14] trace2: collect platform-specific process information

2019-01-30 Thread Jeff Hostetler via GitGitGadget
From: Jeff Hostetler Add optional platform-specific code to log information about the current process. On Windows, this includes whether git.exe is running under a debugger and information about the ancestors of the process. The purpose of this information is to help indicate if the process

[PATCH v2 03/14] trace2: collect platform-specific process information

2019-01-28 Thread Jeff Hostetler via GitGitGadget
From: Jeff Hostetler Add optional platform-specific code to log information about the current process. On Windows, this includes whether git.exe is running under a debugger and information about the ancestors of the process. The purpose of this information is to help indicate if the process

[PATCH 03/14] trace2: collect platform-specific process information

2019-01-22 Thread Jeff Hostetler via GitGitGadget
From: Jeff Hostetler Add optional platform-specific code to log information about the current process. On Windows, this includes whether git.exe is running under a debugger and information about the ancestors of the process. The purpose of this information is to help indicate if the process

Re: [PATCH 3/3] mingw: use domain information for default email

2018-10-16 Thread Johannes Schindelin
Hi Eric, On Mon, 15 Oct 2018, Eric Sunshine wrote: > On Mon, Oct 15, 2018 at 5:47 AM Johannes Schindelin via GitGitGadget > wrote: > > When a user is registered in a Windows domain, it is really easy to > > obtain the email address. So let's do that. > > [...] > > Signed-off-by: Johannes Schinde

Re: [PATCH 3/3] mingw: use domain information for default email

2018-10-15 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > +char *mingw_query_user_email(void) > +{ > + return get_extended_user_info(NameUserPrincipal); > +} > + > ... > > +#ifndef query_user_email > +#define query_user_email() NULL > +#endif The three patches look sensible to me; will queue. You

Re: [PATCH 3/3] mingw: use domain information for default email

2018-10-15 Thread Eric Sunshine
On Mon, Oct 15, 2018 at 5:47 AM Johannes Schindelin via GitGitGadget wrote: > When a user is registered in a Windows domain, it is really easy to > obtain the email address. So let's do that. > [...] > Signed-off-by: Johannes Schindelin > --- > diff --git a/compat/mingw.c b/compat/mingw.c > @@ -1

[PATCH 3/3] mingw: use domain information for default email

2018-10-15 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin When a user is registered in a Windows domain, it is really easy to obtain the email address. So let's do that. Suggested by Lutz Roeder. Signed-off-by: Johannes Schindelin --- compat/mingw.c| 5 + compat/mingw.h| 2 ++ git-compat-util.h | 4 ident.c

[PATCH 4/7] builtin/submodule--helper: store update_clone information in a struct

2018-08-13 Thread Stefan Beller
The information that is printed for update_submodules in 'submodule--helper update-clone' and consumed by 'git submodule update' is stored as a string per submodule. This made sense at the time of 48308681b07 (git submodule update: have a dedicated helper for cloning, 2016-02

[PATCH 4/7] builtin/submodule--helper: store update_clone information in a struct

2018-08-03 Thread Stefan Beller
The information that is printed for update_submodules in 'submodule--helper update-clone' and consumed by 'git submodule update' is stored as a string per submodule. This made sense at the time of 48308681b07 (git submodule update: have a dedicated helper for cloning, 2016-02

Nurses contact information

2018-08-03 Thread Cheryl Strack
Hello there, We have a newly compiled list of Nurses contact information. Contact Information such Name, Company's Name, Phone Number, Fax Number, Job Title, Email address, Complete Mailing Address, SIC code, Company revenue, size, Web address etc. We also have other specialist su

[PATCH 4/6] builtin/submodule--helper: store update_clone information in a struct

2018-07-18 Thread Stefan Beller
The information that is printed for update_submodules in 'submodule--helper update-clone' and consumed by 'git submodule update' is stored as a string per submodule. This made sense at the time of 48308681b07 (git submodule update: have a dedicated helper for cloning, 2016-02

[PATCH v2 4/6] builtin/submodule--helper: store update_clone information in a struct

2018-07-16 Thread Stefan Beller
The information that is printed for update_submodules in 'submodule--helper update-clone' and consumed by 'git submodule update' is stored as a string per submodule. This made sense at the time of 48308681b07 (git submodule update: have a dedicated helper for cloning, 2016-02

Re: [PATCH 4/6] builtin/submodule--helper: store update_clone information in a struct

2018-07-16 Thread Stefan Beller
On Mon, Jul 16, 2018 at 12:37 PM Junio C Hamano wrote: > > Stefan Beller writes: > > > The information that is printed for update_submodules in > > 'submodule--helper update-clone' and consumed by 'git submodule update' > > is stored as a strin

Re: [PATCH 4/6] builtin/submodule--helper: store update_clone information in a struct

2018-07-16 Thread Junio C Hamano
Stefan Beller writes: > The information that is printed for update_submodules in > 'submodule--helper update-clone' and consumed by 'git submodule update' > is stored as a string per submodule. This made sense at the time of > 48308681b07 (git submodule upd

[PATCH 4/6] builtin/submodule--helper: store update_clone information in a struct

2018-07-12 Thread Stefan Beller
The information that is printed for update_submodules in 'submodule--helper update-clone' and consumed by 'git submodule update' is stored as a string per submodule. This made sense at the time of 48308681b07 (git submodule update: have a dedicated helper for cloning, 2016-02

[PATCH v4 05/23] midx: write header information to lockfile

2018-07-12 Thread Derrick Stolee
As we begin writing the multi-pack-index format to disk, start with the basics: the 12-byte header and the 20-byte checksum footer. Start with these basics so we can add the rest of the format in small increments. As we implement the format, we will use a technique to check that our computed offse

[PATCH v3 05/24] midx: write header information to lockfile

2018-07-05 Thread Derrick Stolee
As we begin writing the multi-pack-index format to disk, start with the basics: the 12-byte header and the 20-byte checksum footer. Start with these basics so we can add the rest of the format in small increments. As we implement the format, we will use a technique to check that our computed offse

Re: [PATCH v2 05/24] midx: write header information to lockfile

2018-07-05 Thread Derrick Stolee
On 6/25/2018 3:19 PM, Junio C Hamano wrote: Derrick Stolee writes: +#define MIDX_SIGNATURE 0x4d494458 /* "MIDX" */ +#define MIDX_VERSION 1 +#define MIDX_HASH_VERSION 1 +#define MIDX_HEADER_SIZE 12 + +static char *get_midx_filename(const char *object_dir) +{ + return xstrfmt("%s/pack/mult

I am Mr. Hussein Harmuh from Syria. I got my information while I was searching a trusted person, I have a very profitable business offer for you and I can assure you that you will not regret being par

2018-06-29 Thread Hussein Harmuh
Col. Hussein Kharmusch

Re: [PATCH v2 05/24] midx: write header information to lockfile

2018-06-25 Thread Junio C Hamano
Derrick Stolee writes: > +#define MIDX_SIGNATURE 0x4d494458 /* "MIDX" */ > +#define MIDX_VERSION 1 > +#define MIDX_HASH_VERSION 1 > +#define MIDX_HEADER_SIZE 12 > + > +static char *get_midx_filename(const char *object_dir) > +{ > + return xstrfmt("%s/pack/multi-pack-index", object_dir); > +}

[PATCH v2 05/24] midx: write header information to lockfile

2018-06-25 Thread Derrick Stolee
As we begin writing the multi-pack-index format to disk, start with the basics: the 12-byte header and the 20-byte checksum footer. Start with these basics so we can add the rest of the format in small increments. As we implement the format, we will use a technique to check that our computed offse

Re: [PATCH 05/23] midx: write header information to lockfile

2018-06-19 Thread Derrick Stolee
On 6/19/2018 10:59 AM, Duy Nguyen wrote: On Tue, Jun 19, 2018 at 2:54 PM Derrick Stolee wrote: On 6/12/2018 11:00 AM, Duy Nguyen wrote: On Thu, Jun 7, 2018 at 7:01 PM Derrick Stolee wrote: diff --git a/midx.c b/midx.c index 616af66b13..3e55422a21 100644 --- a/midx.c +++ b/midx.c @@ -1,9 +1,6

Re: [PATCH 05/23] midx: write header information to lockfile

2018-06-19 Thread Duy Nguyen
On Tue, Jun 19, 2018 at 2:54 PM Derrick Stolee wrote: > > On 6/12/2018 11:00 AM, Duy Nguyen wrote: > > On Thu, Jun 7, 2018 at 7:01 PM Derrick Stolee wrote: > >> diff --git a/midx.c b/midx.c > >> index 616af66b13..3e55422a21 100644 > >> --- a/midx.c > >> +++ b/midx.c > >> @@ -1,9 +1,62 @@ > >> #

Re: [PATCH 05/23] midx: write header information to lockfile

2018-06-19 Thread Derrick Stolee
On 6/12/2018 11:00 AM, Duy Nguyen wrote: On Thu, Jun 7, 2018 at 7:01 PM Derrick Stolee wrote: diff --git a/midx.c b/midx.c index 616af66b13..3e55422a21 100644 --- a/midx.c +++ b/midx.c @@ -1,9 +1,62 @@ #include "git-compat-util.h" #include "cache.h" #include "dir.h" +#include "csum-file.h

Re: [PATCH 05/23] midx: write header information to lockfile

2018-06-12 Thread Duy Nguyen
On Thu, Jun 7, 2018 at 7:01 PM Derrick Stolee wrote: > diff --git a/midx.c b/midx.c > index 616af66b13..3e55422a21 100644 > --- a/midx.c > +++ b/midx.c > @@ -1,9 +1,62 @@ > #include "git-compat-util.h" > #include "cache.h" > #include "dir.h" > +#include "csum-file.h" > +#include "lockfile.h" >

Re: [PATCH 05/23] midx: write header information to lockfile

2018-06-07 Thread Duy Nguyen
On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee wrote: > +static char *get_midx_filename(const char *object_dir) > +{ > + struct strbuf midx_name = STRBUF_INIT; > + strbuf_addstr(&midx_name, object_dir); > + strbuf_addstr(&midx_name, "/pack/multi-pack-index"); > + return str

[PATCH 05/23] midx: write header information to lockfile

2018-06-07 Thread Derrick Stolee
As we begin writing the multi-pack-index format to disk, start with the basics: the 12-byte header and the 20-byte checksum footer. Start with these basics so we can add the rest of the format in small increments. As we implement the format, we will use a technique to check that our computed offse

Re: [PATCH v2 02/12] commit-graph: verify file header information

2018-05-20 Thread Jakub Narebski
Derrick Stolee writes: > During a run of 'git commit-graph verify', list the issues with the > header information in the commit-graph file. Some of this information > is inferred from the loaded 'struct commit_graph'. Some header > information is checked

[PATCH 17/19] shallow: migrate shallow information into the object parser

2018-05-17 Thread Stefan Beller
We need to convert the shallow functions all at the same time as we move the data structures they operate on into the repository. Signed-off-by: Stefan Beller --- commit.h | 9 +++-- object.c | 3 +++ object.h | 4 shallow.c | 50 +++---

[PATCH 17/19] shallow: migrate shallow information into the object parser

2018-05-15 Thread Stefan Beller
Signed-off-by: Stefan Beller --- commit.h | 9 +++-- object.c | 3 +++ object.h | 4 shallow.c | 50 -- 4 files changed, 34 insertions(+), 32 deletions(-) diff --git a/commit.h b/commit.h index d04bbed81cf..45114a95b25 100644 --- a/c

Re: [PATCH v2 02/12] commit-graph: verify file header information

2018-05-14 Thread Derrick Stolee
On 5/12/2018 9:35 AM, Martin Ågren wrote: +static int verify_commit_graph_error; + +static void graph_report(const char *fmt, ...) +{ + va_list ap; + struct strbuf sb = STRBUF_INIT; + verify_commit_graph_error = 1; + + va_start(ap, fmt); + strbuf_vaddf(&sb, fmt, ap);

Re: [PATCH v2 02/12] commit-graph: verify file header information

2018-05-12 Thread Martin Ågren
On 11 May 2018 at 23:15, Derrick Stolee wrote: > During a run of 'git commit-graph verify', list the issues with the > header information in the commit-graph file. Some of this information > is inferred from the loaded 'struct commit_graph'. Some header > i

[PATCH v2 02/12] commit-graph: verify file header information

2018-05-11 Thread Derrick Stolee
During a run of 'git commit-graph verify', list the issues with the header information in the commit-graph file. Some of this information is inferred from the loaded 'struct commit_graph'. Some header information is checked as part of load_commit_graph_one(). Signed-of

Re: [PATCH 02/12] commit-graph: verify file header information

2018-05-10 Thread Martin Ågren
On 10 May 2018 at 19:34, Derrick Stolee wrote: > During a run of 'git commit-graph verify', list the issues with the > header information in the commit-graph file. Some of this information > is inferred from the loaded 'struct commit_graph'. Some header > i

[PATCH 02/12] commit-graph: verify file header information

2018-05-10 Thread Derrick Stolee
During a run of 'git commit-graph verify', list the issues with the header information in the commit-graph file. Some of this information is inferred from the loaded 'struct commit_graph'. Some header information is checked as part of load_commit_graph_one(). Signed-of

[PATCH v5 05/11] commit-graph: always load commit-graph information

2018-05-01 Thread Derrick Stolee
ensure that any commit that exists in the commit-graph file has its generation number loaded. Create new load_commit_graph_info() method to fill in the information for a commit that exists only in the commit-graph file. Call it from parse_commit_buffer() after loading the other commit information from

Re: [PATCH v4 05/10] commit-graph: always load commit-graph information

2018-05-01 Thread Derrick Stolee
reate new load_commit_graph_info() method to fill in the information for a commit that exists only in the commit-graph file. Call it from parse_commit_buffer() after loading the other commit information from the given buffer. Only fill this information when specified by the 'check_graph'

Re: [PATCH v4 05/10] commit-graph: always load commit-graph information

2018-04-29 Thread Jakub Narebski
[Forgot about one thing] Derrick Stolee writes: > Create new load_commit_graph_info() method to fill in the information > for a commit that exists only in the commit-graph file. The above sentence is a bit hard to parse because of ambiguity: is it "the information" that ex

Re: [PATCH v4 05/10] commit-graph: always load commit-graph information

2018-04-29 Thread Jakub Narebski
ight? > > With generation numbers in the commit-graph, we need to ensure that any > commit that exists in the commit-graph file has its generation number > loaded. Is it generation number, or generation number and position in commit graph? > > Create new load_commit_graph_info() method

[PATCH v4 05/10] commit-graph: always load commit-graph information

2018-04-25 Thread Derrick Stolee
ensure that any commit that exists in the commit-graph file has its generation number loaded. Create new load_commit_graph_info() method to fill in the information for a commit that exists only in the commit-graph file. Call it from parse_commit_buffer() after loading the other commit information from

Re: [PATCH v3 8/9] commit-graph: always load commit-graph information

2018-04-23 Thread Derrick Stolee
information for a commit that exists only in the commit-graph file. Call it from parse_commit_buffer() after loading the other commit information from the given buffer. Only fill this information when specified by the 'check_graph' parameter. This avoids duplicate work when we already checked th

Re: [PATCH v2 3/6] generate-cmdlist.sh: keep all information in common-cmds.h

2018-04-23 Thread SZEDER Gábor
> Junio C Hamano writes: > > > Nguyễn Thái Ngọc Duy writes: > > > > > +category_list () { > > > + command_list "$1" | awk '{print $2;}' | sort | uniq > > > +} > > > > Piping output of awk to sort/uniq, instead of processing all inside > > awk within the END block of the script, means that we

Re: [PATCH v2 3/6] generate-cmdlist.sh: keep all information in common-cmds.h

2018-04-23 Thread Øystein Walle
Junio C Hamano writes: > Nguyễn Thái Ngọc Duy writes: > > > +category_list () { > > + command_list "$1" | awk '{print $2;}' | sort | uniq > > +} > > Piping output of awk to sort/uniq, instead of processing all inside > awk within the END block of the script, means that we are wasting > two

[PATCH v3 3/6] generate-cmdlist.sh: keep all information in common-cmds.h

2018-04-21 Thread Nguyễn Thái Ngọc Duy
common-cmds.h is used to extract the list of common commands (by group) and a one-line summary of each command. Some information is dropped, for example command category or summary of other commands. Update generate-cmdlist.sh to keep all the information. The extra info will be used shortly. The

Re: [RFC PATCH 03/12] commit-graph: check file header information

2018-04-19 Thread Jakub Narebski
Derrick Stolee writes: > During a run of 'git commit-graph check', list the issues with the > header information in the commit-graph file. Some of this information > is inferred from the loaded 'struct commit_graph'. > > Signed-off-by: Derrick S

Re: [PATCH v3 8/9] commit-graph: always load commit-graph information

2018-04-18 Thread Jakub Narebski
generation numbers in the commit-graph, we need to ensure that any > commit that exists in the commit-graph file has its generation number > loaded. All right, that is nice explanation of the why behind this change. > > Create new load_commit_graph_info() method to fill in the informat

[RFC PATCH 03/12] commit-graph: check file header information

2018-04-17 Thread Derrick Stolee
During a run of 'git commit-graph check', list the issues with the header information in the commit-graph file. Some of this information is inferred from the loaded 'struct commit_graph'. Signed-off-by: Derrick Stolee --- commit-graph.c | 29 -

[RFC PATCH 01/12] fixup! commit-graph: always load commit-graph information

2018-04-17 Thread Derrick Stolee
--- commit-graph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/commit-graph.c b/commit-graph.c index 21e853c21a..3f0c142603 100644 --- a/commit-graph.c +++ b/commit-graph.c @@ -304,7 +304,7 @@ static int find_commit_in_graph(struct commit *item, struct commit_graph *g, uin

Re: [PATCH v3 8/9] commit-graph: always load commit-graph information

2018-04-17 Thread Derrick Stolee
generation numbers in the commit-graph, we need to ensure that any commit that exists in the commit-graph file has its generation number loaded. Create new load_commit_graph_info() method to fill in the information for a commit that exists only in the commit-graph file. Call it from parse_commit_buffer

[PATCH v3 8/9] commit-graph: always load commit-graph information

2018-04-17 Thread Derrick Stolee
ensure that any commit that exists in the commit-graph file has its generation number loaded. Create new load_commit_graph_info() method to fill in the information for a commit that exists only in the commit-graph file. Call it from parse_commit_buffer() after loading the other commit information from

Re: [PATCH v2 3/6] generate-cmdlist.sh: keep all information in common-cmds.h

2018-04-16 Thread Junio C Hamano
SZEDER Gábor writes: >> +while read cmd category tags >> do >> - tag=$(echo "$tags" | sed "$substnum; s/[^0-9]//g") >> + name=${cmd/git-} > > There are two issues with this line: > > - This is a "regular" shell script, therefore it must not use pattern > substitution. Oops. I mis

Re: [PATCH v2 3/6] generate-cmdlist.sh: keep all information in common-cmds.h

2018-04-16 Thread Ramsay Jones
On 16/04/18 16:43, SZEDER Gábor wrote: > On Sun, Apr 15, 2018 at 6:42 PM, Nguyễn Thái Ngọc Duy > wrote: >> common-cmds.h is used to extract the list of common commands (by >> group) and a one-line summary of each command. Some information is >> dropped, for example com

Re: [PATCH v2 3/6] generate-cmdlist.sh: keep all information in common-cmds.h

2018-04-16 Thread Duy Nguyen
On Mon, Apr 16, 2018 at 8:28 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> @@ -23,28 +36,44 @@ sed -n ' >> ' "$1" >> printf '};\n\n' >> >> +echo "#define GROUP_NONE 0xff /* no common group */" > > Some later code forgets about this value, and causes "git" to > segfault at

Re: [PATCH v2 3/6] generate-cmdlist.sh: keep all information in common-cmds.h

2018-04-16 Thread SZEDER Gábor
On Sun, Apr 15, 2018 at 6:42 PM, Nguyễn Thái Ngọc Duy wrote: > common-cmds.h is used to extract the list of common commands (by > group) and a one-line summary of each command. Some information is > dropped, for example command category or summary of other commands. > Update generat

Re: [PATCH v2 3/6] generate-cmdlist.sh: keep all information in common-cmds.h

2018-04-15 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > @@ -23,28 +36,44 @@ sed -n ' > ' "$1" > printf '};\n\n' > > +echo "#define GROUP_NONE 0xff /* no common group */" Some later code forgets about this value, and causes "git" to segfault at the end of this entire series. Namely, here: > - for (i = 0;

Re: [PATCH v2 3/6] generate-cmdlist.sh: keep all information in common-cmds.h

2018-04-15 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > +category_list () { > + command_list "$1" | awk '{print $2;}' | sort | uniq > +} Piping output of awk to sort/uniq, instead of processing all inside awk within the END block of the script, means that we are wasting two processes---I do not think we care too mu

[PATCH v2 3/6] generate-cmdlist.sh: keep all information in common-cmds.h

2018-04-15 Thread Nguyễn Thái Ngọc Duy
common-cmds.h is used to extract the list of common commands (by group) and a one-line summary of each command. Some information is dropped, for example command category or summary of other commands. Update generate-cmdlist.sh to keep all the information. The extra info will be used shortly

Re: [PATCH/RFC 3/5] generate-cmdlist.sh: keep all information in common-cmds.h

2018-04-15 Thread Duy Nguyen
On Mon, Apr 9, 2018 at 6:59 AM, Eric Sunshine wrote: >> +awk '{print $2;}' | > > At one time, Junio expressed concerns[2] about having an 'awk' > dependency in the build system (in fact, with regards to this same > generation process). Whether he still has such concerns is unknown, > but it should

Re: [PATCH/RFC 3/5] generate-cmdlist.sh: keep all information in common-cmds.h

2018-04-09 Thread Duy Nguyen
On Mon, Apr 9, 2018 at 6:59 AM, Eric Sunshine wrote: > On Mon, Mar 26, 2018 at 12:55 PM, Nguyễn Thái Ngọc Duy > wrote: >> common-cmds.h is used to extract the list of common commands (by >> group) and a one-line summary of each command. Some information is >> drop

Re: [PATCH/RFC 3/5] generate-cmdlist.sh: keep all information in common-cmds.h

2018-04-08 Thread Eric Sunshine
On Mon, Apr 9, 2018 at 12:59 AM, Eric Sunshine wrote: > However, I'm concerned that this change may be going in the wrong > direction. A line in "### command list" section looks like this: > > command-name category [deprecated] [common] > > Although we don't currently have any commands marked

Re: [PATCH/RFC 3/5] generate-cmdlist.sh: keep all information in common-cmds.h

2018-04-08 Thread Eric Sunshine
On Mon, Mar 26, 2018 at 12:55 PM, Nguyễn Thái Ngọc Duy wrote: > common-cmds.h is used to extract the list of common commands (by > group) and a one-line summary of each command. Some information is > dropped, for example command category or summary of other commands. > Update generat

[PATCH/RFC 3/5] generate-cmdlist.sh: keep all information in common-cmds.h

2018-03-26 Thread Nguyễn Thái Ngọc Duy
common-cmds.h is used to extract the list of common commands (by group) and a one-line summary of each command. Some information is dropped, for example command category or summary of other commands. Update generate-cmdlist.sh to keep all the information. The extra info will be used shortly

information required

2018-03-14 Thread 2017supply2017c
Thanks for your last email response to me. The information required should include the following-: Your full names Your address Telephone number Your private email Occupation Age This is to enable my further discussion with you in confidence. Best regards and wishes to you. Mohammad Amir Khadov

information required

2018-03-04 Thread sales
= Thanks for your last email response to me. The information required should include the following-: Your full names Your address Telephone number Your private email Occupation Age This is to enable my further discussion with you in confidence. Best

[PATCH 157/194] shallow: migrate shallow information into the object parser

2018-02-05 Thread Stefan Beller
Signed-off-by: Stefan Beller --- commit.h | 11 --- object.h | 6 ++ repository.c | 4 shallow.c| 52 +--- 4 files changed, 39 insertions(+), 34 deletions(-) diff --git a/commit.h b/commit.h index 06795f0684..cdd12ad7

information required

2018-01-10 Thread From Amir Khadov
-- Thanks for your last email response to me. The information required should include the following-: Your full names Your address Telephone number Your private email Occupation Age This is to enable my further discussion with you in confidence. Best regards and wishes to you. Mohammad Amir

information required

2018-01-10 Thread From Amir Khadov
-- Thanks for your last email response to me. The information required should include the following-: Your full names Your address Telephone number Your private email Occupation Age This is to enable my further discussion with you in confidence. Best regards and wishes to you. Mohammad Amir

[PATCH v5 1/1] Doc/check-ref-format: clarify information about @{-N} syntax

2017-12-16 Thread Kaartic Sivaraam
When the N-th previous thing checked out syntax (@{-N}) is used with '--branch' option of check-ref-format the result may not be the name of a branch that currently exists or ever existed. This is because @{-N} is used to refer to the N-th last checked out "thing", which might be a commit object na

Re: [PATCH v4 2/2] Doc/check-ref-format: clarify information about @{-N} syntax

2017-12-15 Thread Kaartic Sivaraam
On Thursday 14 December 2017 11:32 PM, Junio C Hamano wrote: Kaartic Sivaraam writes: Looks alright. It was made unnecessarily harder to review because it was marked as 2/2, even though this no longer applies on top of the copy of 1/2 that was merged some time ago. Sorry about that but I don

Re: [PATCH v2 0/2] Offer more information in `git version --build-options`'s output

2017-12-15 Thread Junio C Hamano
style used for "sizeof-long", which hints that >> these are " " lines where whitespaces are >> avoided in a ), but hopefully this is primarily for human >> consumption and scrypts that are trying to find a specific piece of >> information would know

Re: [PATCH v2 0/2] Offer more information in `git version --build-options`'s output

2017-12-15 Thread Eric Sunshine
that > these are " " lines where whitespaces are > avoided in a ), but hopefully this is primarily for human > consumption and scrypts that are trying to find a specific piece of > information would know how to use 'grep', so the inconsistency does > not make much

Re: [PATCH v2 0/2] Offer more information in `git version --build-options`'s output

2017-12-15 Thread Junio C Hamano
d for "sizeof-long", which hints that these are " " lines where whitespaces are avoided in a ), but hopefully this is primarily for human consumption and scrypts that are trying to find a specific piece of information would know how to use 'grep', so the inconsistenc

[PATCH v2 0/2] Offer more information in `git version --build-options`'s output

2017-12-14 Thread Johannes Schindelin
In Git for Windows, we ask users to paste the output of said command into their bug reports, with the idea that this frequently helps identify where the problems are coming from. There are some obvious missing bits of information in said output, though, and this patch series tries to fill the

Re: [PATCH v4 2/2] Doc/check-ref-format: clarify information about @{-N} syntax

2017-12-14 Thread Junio C Hamano
Kaartic Sivaraam writes: > With the `--branch` option, the command takes a name and checks if > -it can be used as a valid branch name (e.g. when creating a new > -branch). The rule `git check-ref-format --branch $name` implements > -may be stricter than what `git check-ref-format refs/heads/$n

[PATCH v4 2/2] Doc/check-ref-format: clarify information about @{-N} syntax

2017-12-14 Thread Kaartic Sivaraam
When the N-th previous thing checked out syntax (@{-N}) is used with '--branch' option of check-ref-format the result may not be the name of a branch that currently exists or ever existed. This is because @{-N} is used to refer to the N-th last checked out "thing", which might be a commit object na

[PATCH 0/2] Offer more information in `git version --build-options`'s output

2017-12-08 Thread Johannes Schindelin
In Git for Windows, we ask users to paste the output of said command into their bug reports, with the idea that this frequently helps identify where the problems are coming from. There are some obvious missing bits of information in said output, though, and this patch series tries to fill the

Re: [PATCH v3 2/2] Doc/check-ref-format: clarify information about @{-N} syntax

2017-12-06 Thread Kaartic Sivaraam
On Sunday 03 December 2017 07:38 AM, Junio C Hamano wrote: Kaartic Sivaraam writes: NOTE: Though a commit-hash is a "syntactically" valid branch name, it is generally not considered as one for the use cases of "git check-ref-format --branch". That's because a user who does "git check-ref-form

Re: [PATCH v2 2/2] Doc/check-ref-format: clarify information about @{-N} syntax

2017-12-04 Thread Kaartic Sivaraam
On Tuesday 05 December 2017 12:14 AM, Junio C Hamano wrote: Kaartic Sivaraam writes: Stepping back a bit, the mild suspicion above says $ git checkout HEAD^0 ... do things ... $ git checkout -b temp ... do more things ... $ git checkout -B @{-1} that creates a new br

Re: [PATCH v2 2/2] Doc/check-ref-format: clarify information about @{-N} syntax

2017-12-04 Thread Junio C Hamano
Kaartic Sivaraam writes: >> Stepping back a bit, the mild suspicion above says >> >> $ git checkout HEAD^0 >> ... do things ... >> $ git checkout -b temp >> ... do more things ... >> $ git checkout -B @{-1} >> >> that creates a new branch whose name is 40-hex of a commit tha

Re: [PATCH v2 2/2] Doc/check-ref-format: clarify information about @{-N} syntax

2017-12-04 Thread Kaartic Sivaraam
On Sat, 2017-12-02 at 17:52 -0800, Junio C Hamano wrote: > Kaartic Sivaraam writes: > > > > I have a mild suspicion that "git checkout -B @{-1}" would want to > > > error out instead of creating a valid new branch whose name is > > > 40-hex that happen to be the name of the commit object you were

Re: [PATCH v3 2/2] Doc/check-ref-format: clarify information about @{-N} syntax

2017-12-02 Thread Junio C Hamano
Kaartic Sivaraam writes: > When the N-th previous thing checked out syntax (@{-N}) is used > with '--branch' option of check-ref-format the result might not > always be a valid branch name (see NOTE below). This is because > @{-N} is used to refer to the N-th last checked out "thing" which > migh

Re: [PATCH v2 2/2] Doc/check-ref-format: clarify information about @{-N} syntax

2017-12-02 Thread Junio C Hamano
Kaartic Sivaraam writes: >> I have a mild suspicion that "git checkout -B @{-1}" would want to >> error out instead of creating a valid new branch whose name is >> 40-hex that happen to be the name of the commit object you were >> detached at previously. > > I thought this the other way round. Ra

[PATCH v3 2/2] Doc/check-ref-format: clarify information about @{-N} syntax

2017-11-28 Thread Kaartic Sivaraam
When the N-th previous thing checked out syntax (@{-N}) is used with '--branch' option of check-ref-format the result might not always be a valid branch name (see NOTE below). This is because @{-N} is used to refer to the N-th last checked out "thing" which might be any commit (sometimes a branch).

Re: [PATCH v2 2/2] Doc/check-ref-format: clarify information about @{-N} syntax

2017-11-28 Thread Kaartic Sivaraam
On Tue, 2017-11-28 at 11:40 +0900, Junio C Hamano wrote: > Kaartic Sivaraam writes: > > > When the N-th previous thing checked out sytax is used with > > '--branch' option of check-ref-format the results might not > > always be a valid branch name > > I wonder if you want to rephrase this, becau

  1   2   3   4   5   >