"Johannes Schindelin via GitGitGadget" <[email protected]>
writes:
> +char *mingw_query_user_email(void)
> +{
> + return get_extended_user_info(NameUserPrincipal);
> +}
> +
> ...
>
> +#ifndef query_user_email
> +#define query_user_email() NULL
> +#endif
The three patches look sensible to me; will queue.
You may already have audited our use of "struct passwd",
"getpwnam()" and "getpwuid()"--I haven't. I think we use these only
to learn user's email (to be used as the default ident) and home
directory (to expand "git config --type=path"). If that is really
the case, it may be a worthwhile clean-up to introduce our own API
that offers these two exact functions, have the per-platform
implementation of the API in compat/, and get rid of "struct passwd"
and calls to getpw*() functions out of the core Git proper, to wean
ourselves away from depending on POSIX too much.
But of course that is a separate topic.
