Re: [PATCHv2 4/7] t7008: demonstrate behavior of grep with textconv

2013-04-24 Thread Junio C Hamano
Michael J Gruber writes: >>> +test_expect_failure 'grep does not honor textconv' ' >>> + echo "a:binaryQfile" >expect && >>> + git grep Qfile >actual && >> >> This should pass --textconv to "git grep". > > But "git grep" does not know that option yet, so the test would fail for > the wrong r

Re: [PATCHv2 4/7] t7008: demonstrate behavior of grep with textconv

2013-04-24 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 23.04.2013 17:16: > Michael J Gruber writes: > >> Currently, "git grep" does not honor any textconv filters. Demonstrate >> this in the tests. >> >> Signed-off-by: Michael J Gruber >> --- >> t/t7008-grep-binary.sh | 23 +++ >> 1 file change

Re: [PATCHv2 4/7] t7008: demonstrate behavior of grep with textconv

2013-04-23 Thread Junio C Hamano
Michael J Gruber writes: > Currently, "git grep" does not honor any textconv filters. Demonstrate > this in the tests. > > Signed-off-by: Michael J Gruber > --- > t/t7008-grep-binary.sh | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/t/t7008-grep-binary.sh b/t/