Michael J Gruber <g...@drmicha.warpmail.net> writes:

> Currently, "git grep" does not honor any textconv filters. Demonstrate
> this in the tests.
>
> Signed-off-by: Michael J Gruber <g...@drmicha.warpmail.net>
> ---
>  t/t7008-grep-binary.sh | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/t/t7008-grep-binary.sh b/t/t7008-grep-binary.sh
> index 26f8319..126fe4c 100755
> --- a/t/t7008-grep-binary.sh
> +++ b/t/t7008-grep-binary.sh
> @@ -145,4 +145,27 @@ test_expect_success 'grep respects not-binary diff 
> attribute' '
>       test_cmp expect actual
>  '
>  
> +cat >nul_to_q_textconv <<'EOF'
> +#!/bin/sh
> +"$PERL_PATH" -pe 'y/\000/Q/' < "$1"
> +EOF
> +chmod +x nul_to_q_textconv
> +
> +test_expect_success 'setup textconv filters' '
> +     echo a diff=foo >.gitattributes &&
> +     git config diff.foo.textconv "\"$(pwd)\""/nul_to_q_textconv
> +'
> +
> +test_expect_failure 'grep does not honor textconv' '
> +     echo "a:binaryQfile" >expect &&
> +     git grep Qfile >actual &&

This should pass --textconv to "git grep".

> +     test_cmp expect actual
> +'
> +
> +test_expect_failure 'grep blob does not honor textconv' '
> +     echo "HEAD:a:binaryQfile" >expect &&
> +     git grep Qfile HEAD:a >actual &&

Likewise.

> +     test_cmp expect actual
> +'
> +
>  test_done
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to