Re: [PATCH v2] submodule-config: use hashmap_iter_first()

2016-03-15 Thread Jeff King
On Tue, Mar 15, 2016 at 12:21:36PM -0700, Stefan Beller wrote: > On Tue, Mar 15, 2016 at 12:13 PM, Alexander Kuleshov > wrote: > > from the for simplification. > > I think what Eric wanted to point out, was to not have a continuous sentence > from commit message header to body. > > Either leav

Re: [PATCH v2] submodule-config: use hashmap_iter_first()

2016-03-15 Thread Eric Sunshine
On Tue, Mar 15, 2016 at 3:21 PM, Stefan Beller wrote: > On Tue, Mar 15, 2016 at 12:13 PM, Alexander Kuleshov > wrote: >> from the for simplification. > > I think what Eric wanted to point out, was to not have a continuous sentence > from commit message header to body. Yes, thanks for clarifying

Re: [PATCH v2] submodule-config: use hashmap_iter_first()

2016-03-15 Thread Stefan Beller
On Tue, Mar 15, 2016 at 12:13 PM, Alexander Kuleshov wrote: > from the for simplification. I think what Eric wanted to point out, was to not have a continuous sentence from commit message header to body. Either leave the body blank (as it is obvious) or write a whole sentence there: [PATCH v