On Tue, Mar 15, 2016 at 3:21 PM, Stefan Beller <sbel...@google.com> wrote:
> On Tue, Mar 15, 2016 at 12:13 PM, Alexander Kuleshov
> <kuleshovm...@gmail.com> wrote:
>> from the <hashmap.h> for simplification.
>
> I think what Eric wanted to point out, was to not have a continuous sentence
> from commit message header to body.

Yes, thanks for clarifying that.

> Either leave the body blank (as it is obvious) or write a whole sentence 
> there:
>
>   [PATCH v2] submodule-config: use hashmap_iter_first()
>
>   The hashmap API offers the `hashmap_iter_first` function as initializing and
>   getting the first entry is a common pattern. Use that instead of
> doing initialization
>   by hand and then get the first entry.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to