Re: [PATCH 4/8] Rename struct diff_filespec's sha1_valid member.

2016-06-07 Thread brian m. carlson
On Tue, Jun 07, 2016 at 12:14:42PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > On Tue, Jun 07, 2016 at 08:21:26AM +0200, Johannes Sixt wrote: > > > >> > diff --git a/combine-diff.c b/combine-diff.c > >> > index f39be434..a20caa80 100644 > >> > --- a/combine-diff.c > >> > +++ b/combine-

Re: [PATCH 4/8] Rename struct diff_filespec's sha1_valid member.

2016-06-07 Thread Junio C Hamano
Jeff King writes: > On Tue, Jun 07, 2016 at 08:21:26AM +0200, Johannes Sixt wrote: > >> > diff --git a/combine-diff.c b/combine-diff.c >> > index f39be434..a20caa80 100644 >> > --- a/combine-diff.c >> > +++ b/combine-diff.c >> > @@ -1269,7 +1269,7 @@ static struct diff_filepair *combined_pair(str

Re: [PATCH 4/8] Rename struct diff_filespec's sha1_valid member.

2016-06-06 Thread Jeff King
On Tue, Jun 07, 2016 at 08:21:26AM +0200, Johannes Sixt wrote: > > diff --git a/combine-diff.c b/combine-diff.c > > index f39be434..a20caa80 100644 > > --- a/combine-diff.c > > +++ b/combine-diff.c > > @@ -1269,7 +1269,7 @@ static struct diff_filepair *combined_pair(struct > > combine_diff_path *

Re: [PATCH 4/8] Rename struct diff_filespec's sha1_valid member.

2016-06-06 Thread Johannes Sixt
Am 07.06.2016 um 02:57 schrieb brian m. carlson: Now that this struct's sha1 member is called "oid", update the comment and the sha1_valid member to be called "oid_valid" instead. The following Coccinelle semantic patch was used to implement this, followed by the transformations in standard.cocc