Re: [PATCH 1/1] clean: show an error message when the path is too long

2019-07-18 Thread Johannes Schindelin
Hi, On Wed, 17 Jul 2019, Junio C Hamano wrote: > Junio C Hamano writes: > > >> The other warnings in that function are issued using > >> warning_errno() (shorter code, consistency is enforced) and > >> messages are marked for translation. That would be nice to have > >> here as well, no? > > >

Re: [PATCH 1/1] clean: show an error message when the path is too long

2019-07-17 Thread Junio C Hamano
Junio C Hamano writes: >> The other warnings in that function are issued using warning_errno() >> (shorter code, consistency is enforced) and messages are marked for >> translation. That would be nice to have here as well, no? > > Absolutely. Also, downcase "Could" and perhaps use _() around.

Re: [PATCH 1/1] clean: show an error message when the path is too long

2019-07-16 Thread Junio C Hamano
René Scharfe writes: >> diff --git a/builtin/clean.c b/builtin/clean.c >> index aaba4af3c2..7be689f480 100644 >> --- a/builtin/clean.c >> +++ b/builtin/clean.c >> @@ -194,7 +194,8 @@ static int remove_dirs(struct strbuf *path, const char >> *prefix, int force_flag, >> strbuf_setlen(

Re: [PATCH 1/1] clean: show an error message when the path is too long

2019-07-16 Thread SZEDER Gábor
On Tue, Jul 16, 2019 at 07:04:23AM -0700, Johannes Schindelin via GitGitGadget wrote: > +test_expect_success MINGW 'handle clean & core.longpaths = false nicely' ' > + git config core.longpaths false && > + test_when_finished git config --unset core.longpaths && 'test_config core.longpath

Re: [PATCH 1/1] clean: show an error message when the path is too long

2019-07-16 Thread René Scharfe
Am 16.07.19 um 16:04 schrieb Johannes Schindelin via GitGitGadget: > From: Johannes Schindelin > > Without an error message when stat() failed, e.g. `git clean` would > abort without an error message, leaving the user quite puzzled. > > In particular on Windows, where the default maximum path leng