Re: [PATCH] credential: cred helper fast exit can cause SIGPIPE, crash

2018-03-29 Thread Jeff King
On Thu, Mar 29, 2018 at 05:25:04PM +, Erik Brady -X (brady - ROBERT HALF INTERNATIONAL INC at Cisco) wrote: > OK, will retry on the comment. I guess I misunderstood the guidelines > a bit on the signoff as well (ie: non-optional), apologies. Will > resubmit via 'git send-email' after adjust

Re: [PATCH] credential: cred helper fast exit can cause SIGPIPE, crash

2018-03-29 Thread Erik Brady -X (brady - ROBERT HALF INTERNATIONAL INC at Cisco)
small credential output. -- As to testing, yes, that was my thought as well. Anyhow, I will try the above unless you see a problem or would like any further change (?). Thanks, Erik On 3/29/18, 4:19 AM, "Jeff King" wrote: On Wed, Mar 28, 2018 at 03:20:51PM -0700, Erik E Brady wr

Re: [PATCH] credential: cred helper fast exit can cause SIGPIPE, crash

2018-03-29 Thread Jeff King
On Wed, Mar 28, 2018 at 03:20:51PM -0700, Erik E Brady wrote: > Subject: Re: [PATCH] credential: cred helper fast exit can cause SIGPIPE, > crash Thanks for sending this. The patch itself looks good to me, but I have a few nits with your commit message. We usually write commit messages