On Thu, Mar 29, 2018 at 05:25:04PM +0000, Erik Brady -X (brady - ROBERT HALF INTERNATIONAL INC at Cisco) wrote:
> OK, will retry on the comment. I guess I misunderstood the guidelines > a bit on the signoff as well (ie: non-optional), apologies. Will > resubmit via 'git send-email' after adjusting the comment and > recommitting with the -s option. First time for everything I suppose, > doh. The signoff (for our project) is all about the "yes, this contribution can go under the gpl". So that part is very non-optional. :) > As to your comment suggestion, appreciated, looks good. I might > reword the #1 item you have just a bit (I removed the host specific > stuff since I think the race can occur regardless of host specific or > not... but I might be missing something there?). Anyhow, how about > something like this: Yeah, it can definitely occur regardless. It was just the plausible reason to have a handler which does not bother to look at the incoming data (since otherwise you are spewing your password to any host you connect to; maybe that's OK if you configure it only inside a specific repo and only fetch from one server). Your update looks fine to me. Thanks. -Peff
