Re: [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News

2019-02-20 Thread Johannes Schindelin
Hi Max, On Tue, 19 Feb 2019, Max Kirillov wrote: > On Mon, Feb 18, 2019 at 10:57:13PM +0100, Johannes Schindelin wrote: > > I have to take that assessment back. So sad. > > > > After that build, I cherry-picked the commit on top of shears/pu (which is > > Git for Windows' ever-green branch that

RE: [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News

2019-02-19 Thread Randall S. Becker
On February 19, 2019 15:16, Max Kirillov wrote: > On Mon, Feb 18, 2019 at 10:57:13PM +0100, Johannes Schindelin wrote: > > I have to take that assessment back. So sad. > > > > After that build, I cherry-picked the commit on top of shears/pu > > (which is Git for Windows' ever-green branch that con

Re: [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News

2019-02-19 Thread Max Kirillov
On Tue, Feb 19, 2019 at 10:15:36PM +0200, Max Kirillov wrote: > expecially at > Windows where you cannot just unlink busy file and reuse its > place in directory It was at Linux actually. Well, whatever the rename feels more sure thing to me.

Re: [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News

2019-02-19 Thread Max Kirillov
On Mon, Feb 18, 2019 at 10:57:13PM +0100, Johannes Schindelin wrote: > I have to take that assessment back. So sad. > > After that build, I cherry-picked the commit on top of shears/pu (which is > Git for Windows' ever-green branch that continuously rebases Git for > Windows' `master` onto git.git

RE: [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News

2019-02-19 Thread Johannes Schindelin
Hi, On Mon, 18 Feb 2019, Randall S. Becker wrote: > On February 18, 2019 13:46, Junio C Hamano wrote: > > Junio C Hamano writes: > > > > > I have been wondering about the whole /dev/zero business. Although we > > > have b46221ff ("Merge branch 'rb/no-dev-zero-in-test'", > > > 2019-02-13) in 'm

Re: [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News

2019-02-18 Thread Johannes Schindelin
Hi, On Mon, 18 Feb 2019, Johannes Schindelin wrote: > On Sat, 16 Feb 2019, Junio C Hamano wrote: > > > [...] but I'm inclined to > > > > - keep b46221ff in 'master', not reverted. > > - apply Max's "t5562: do not reuse output files" > > > > to 'master' and hope that we can declare victory in

RE: [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News

2019-02-18 Thread Randall S. Becker
On February 18, 2019 15:25, Max Kirillov wrote: > On Sat, Feb 16, 2019 at 10:57:52AM -0800, Junio C Hamano wrote: > > I'm inclined to > > > > - keep b46221ff in 'master', not reverted. > > from the branch, cc95bc2025 "t5562: replace /dev/zero with a pipe from > generate_zero_bytes" could be repla

Re: [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News

2019-02-18 Thread Max Kirillov
On Sat, Feb 16, 2019 at 10:57:52AM -0800, Junio C Hamano wrote: > I'm inclined to > > - keep b46221ff in 'master', not reverted. from the branch, cc95bc2025 "t5562: replace /dev/zero with a pipe from generate_zero_bytes" could be replaced with [1] "t5562: do not depend on /dev/zero", for simplic

Re: [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News

2019-02-18 Thread Johannes Schindelin
Hi Junio, On Sat, 16 Feb 2019, Junio C Hamano wrote: > "Randall S. Becker" writes: > > >> > The current condition of the code is (the generate_zero_bytes delete > >> > was previously removed so can be ignored for the patch): > >> > >> Just to make sure I do not misunderstand, this result is wi

RE: [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News

2019-02-18 Thread Randall S. Becker
On February 18, 2019 13:46, Junio C Hamano wrote: > Junio C Hamano writes: > > > I have been wondering about the whole /dev/zero business. Although we > > have b46221ff ("Merge branch 'rb/no-dev-zero-in-test'", > > 2019-02-13) in 'master', "git grep /dev/zero t" has hits in > > t/helper/test-sha

Re: [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News

2019-02-18 Thread Junio C Hamano
Junio C Hamano writes: > I have been wondering about the whole /dev/zero business. Although > we have b46221ff ("Merge branch 'rb/no-dev-zero-in-test'", > 2019-02-13) in 'master', "git grep /dev/zero t" has hits in > t/helper/test-sha1.sh and t/t4152-am-resume-override-opts.sh, so it > must have

Re: [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News

2019-02-16 Thread Junio C Hamano
"Randall S. Becker" writes: >> > The current condition of the code is (the generate_zero_bytes delete >> > was previously removed so can be ignored for the patch): >> >> Just to make sure I do not misunderstand, this result is with Max's patch but >> without the generate_zero_bytes stuff? > > Co

RE: [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News

2019-02-16 Thread Randall S. Becker
On February 16, 2019 13:06, Junio C Hamano wrote: > "Randall S. Becker" writes: > > On February 16, 2019 3:27, Max Kirillov wrote: > >> What you could try is > >> https://public-inbox.org/git/20181124093719.10705-1- > m...@max630.net/ > >> (I'm not sure it would not conflict by now), this would re

Re: [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News

2019-02-16 Thread Junio C Hamano
"Randall S. Becker" writes: > On February 16, 2019 3:27, Max Kirillov wrote: > >> What you could try is >> https://public-inbox.org/git/20181124093719.10705-1-...@max630.net/ >> (I'm not sure it would not conflict by now), this would remove dependency >> between tests. If it helps it would be ver

RE: [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News

2019-02-16 Thread Randall S. Becker
On February 16, 2019 11:51, I wrote: > To: 'Max Kirillov' > Cc: 'SZEDER Gábor' ; 'Johannes Schindelin' > ; 'Junio C Hamano' ; > git@vger.kernel.org > Subject: RE: [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News > > On Februar

RE: [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News

2019-02-16 Thread Randall S. Becker
On February 16, 2019 3:27, Max Kirillov wrote: > On Fri, Feb 15, 2019 at 04:13:15PM -0500, Randall S. Becker wrote: > > Sadly, the fix does not change the results. In fact, it makes the hang > > far more likely. Subtest 6,7,8 fails here, at close() > > Correct, I did not expect it to help, it was