Re: [RFCv2 05/16] remote.h: Change get_remote_heads return to void

2015-06-02 Thread Junio C Hamano
Stefan Beller writes: > On Tue, Jun 2, 2015 at 2:17 PM, Junio C Hamano wrote: >> Stefan Beller writes: >> >>> No function uses the return value of get_remote_heads, so we don't want >>> to confuse readers by it. >>> >>> Signed-off-by: Stefan Beller >>> --- >> >> This is somewhat a sad change,

Re: [RFCv2 05/16] remote.h: Change get_remote_heads return to void

2015-06-02 Thread Stefan Beller
On Tue, Jun 2, 2015 at 2:17 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> No function uses the return value of get_remote_heads, so we don't want >> to confuse readers by it. >> >> Signed-off-by: Stefan Beller >> --- > > This is somewhat a sad change, as the returned value is designed t

Re: [RFCv2 05/16] remote.h: Change get_remote_heads return to void

2015-06-02 Thread Junio C Hamano
Stefan Beller writes: > No function uses the return value of get_remote_heads, so we don't want > to confuse readers by it. > > Signed-off-by: Stefan Beller > --- This is somewhat a sad change, as the returned value is designed to be useful if caller wants to continue appending to the list. No

[RFCv2 05/16] remote.h: Change get_remote_heads return to void

2015-06-01 Thread Stefan Beller
No function uses the return value of get_remote_heads, so we don't want to confuse readers by it. Signed-off-by: Stefan Beller --- connect.c | 10 -- remote.h | 8 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/connect.c b/connect.c index 4295ba1..a2c777e 1006