Stefan Beller <sbel...@google.com> writes: > On Tue, Jun 2, 2015 at 2:17 PM, Junio C Hamano <gits...@pobox.com> wrote: >> Stefan Beller <sbel...@google.com> writes: >> >>> No function uses the return value of get_remote_heads, so we don't want >>> to confuse readers by it. >>> >>> Signed-off-by: Stefan Beller <sbel...@google.com> >>> --- >> >> This is somewhat a sad change, as the returned value is designed to >> be useful if caller wants to continue appending to the list. > > But there are no callers since like 2005. ;)
That is not a good excuse when it comes to the API design to deal with linked lists in a bog-standard way, though. Many callers of commit_list_insert() may ignore its return values, but even when the last caller stopped caring it, that does not necessarily mean the feature can be removed. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
