Re: [RFC PATCH v3 0/5] clone: dir iterator refactoring with tests

2019-02-26 Thread Matheus Tavares Bernardino
Hi, Ævar Thank you for helping me out on this series and, especially, for the tests part. Now that we've come to a consensus on what the overall series' "shape" should be, can I refine what's still needed and resubmit it, in the upcoming days, as a patch set with the test included? Best, Matheus

[RFC PATCH v3 0/5] clone: dir iterator refactoring with tests

2019-02-26 Thread Ævar Arnfjörð Bjarmason
There's still active review going on for the "v2"[1], in particular Duy's comments coming in as I write this. This doesn't address any of that. What it does do is have a better version of my patch to add tests for the current behavior. It now doesn't reply the on SHA1 prereq anymore, and we can te