On Fri, Aug 12, 2016 at 08:51:43AM -0700, Stefan Beller wrote:
> > Hmm. Using "!test_cmp" seems weird to me, just because it would falsely
> > claim success if something else unexpected changes. Our usual method for
> > making sure some particular output does not appear is "test_i18ngrep"
> > with
Stefan Beller writes:
> When a user asked for a detached HEAD specifically with `--detach`,
> we do not need to give advice on what a detached HEAD state entails as
> we can assume they know what they're getting into as they asked for it.
>
> Signed-off-by: Stefan Beller
> ---
>
> Thanks for the
On Fri, Aug 12, 2016 at 8:43 AM, Jeff King wrote:
> On Fri, Aug 12, 2016 at 08:37:44AM -0700, Stefan Beller wrote:
>
>> > Is there a reason for not unsetting `advice.detachedHead` at the
>> > end of the test?
>>
>> done
>>
>> I did not consider to clean up after myself... what a selfish world!
>
>
On Fri, Aug 12, 2016 at 08:37:44AM -0700, Stefan Beller wrote:
> > Is there a reason for not unsetting `advice.detachedHead` at the
> > end of the test?
>
> done
>
> I did not consider to clean up after myself... what a selfish world!
The right way to do it is:
test_config advice.detachedHea
When a user asked for a detached HEAD specifically with `--detach`,
we do not need to give advice on what a detached HEAD state entails as
we can assume they know what they're getting into as they asked for it.
Signed-off-by: Stefan Beller
---
Thanks for the review!
> Is there a reason for not
5 matches
Mail list logo
