On Fri, Aug 12, 2016 at 08:37:44AM -0700, Stefan Beller wrote: > > Is there a reason for not unsetting `advice.detachedHead` at the > > end of the test? > > done > > I did not consider to clean up after myself... what a selfish world!
The right way to do it is: test_config advice.detachedHead false && ... so that the cleanup runs whether or not you may it to the end of the script. > +test_expect_success 'no advice given for explicit detached head state' ' > + git config advice.detachedHead false && > + git checkout child && > + git checkout --detach HEAD >expect && > + git config advice.detachedHead true && > + git checkout child && > + git checkout --detach HEAD >actual && > + test_cmp expect actual && > + git checkout child && > + git checkout HEAD >actual && > + ! test_cmp expect actual && > + git config --unset advice.detachedHead > +' Hmm. Using "!test_cmp" seems weird to me, just because it would falsely claim success if something else unexpected changes. Our usual method for making sure some particular output does not appear is "test_i18ngrep" with a liberal pattern. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
