Re: [PATCHv12 0/7] Expose submodule parallelism to the user

2016-02-18 Thread Junio C Hamano
Stefan Beller writes: > On Thu, Feb 18, 2016 at 3:20 PM, Junio C Hamano wrote: >> Stefan Beller writes: >> >>> On Thu, Feb 18, 2016 at 3:12 PM, Stefan Beller wrote: > Unless you count "I want to write differently from what was > suggested" is a desirable thing to do, I do not see a poi

Re: [PATCHv12 0/7] Expose submodule parallelism to the user

2016-02-18 Thread Stefan Beller
On Thu, Feb 18, 2016 at 3:20 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> On Thu, Feb 18, 2016 at 3:12 PM, Stefan Beller wrote: Unless you count "I want to write differently from what was suggested" is a desirable thing to do, I do not see a point in favouring the above

Re: [PATCHv12 0/7] Expose submodule parallelism to the user

2016-02-18 Thread Junio C Hamano
Stefan Beller writes: > On Thu, Feb 18, 2016 at 3:12 PM, Stefan Beller wrote: >>> Unless you count "I want to write differently from what was >>> suggested" is a desirable thing to do, I do not see a point in >>> favouring the above that uses an extra variable and skip_prefix() >>> over what I g

Re: [PATCHv12 0/7] Expose submodule parallelism to the user

2016-02-18 Thread Stefan Beller
On Thu, Feb 18, 2016 at 3:12 PM, Stefan Beller wrote: >> Unless you count "I want to write differently from what was >> suggested" is a desirable thing to do, I do not see a point in >> favouring the above that uses an extra variable and skip_prefix() >> over what I gave you as "how about" patch.

Re: [PATCHv12 0/7] Expose submodule parallelism to the user

2016-02-18 Thread Stefan Beller
On Thu, Feb 18, 2016 at 2:55 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Thanks Junio for a review of v11! >> >> I addressed the memory issue with the interdiff (in patch 1/7) as follows: >> Interdiff to v11: >> >> diff --git a/submodule.c b/submodule.c >> index 263cb2a..45d0967 100644

Re: [PATCHv12 0/7] Expose submodule parallelism to the user

2016-02-18 Thread Junio C Hamano
Stefan Beller writes: > Thanks Junio for a review of v11! > > I addressed the memory issue with the interdiff (in patch 1/7) as follows: > Interdiff to v11: > > diff --git a/submodule.c b/submodule.c > index 263cb2a..45d0967 100644 > --- a/submodule.c > +++ b/submodule.c > @@ -219,6 +219,9 @@ voi

[PATCHv12 0/7] Expose submodule parallelism to the user

2016-02-18 Thread Stefan Beller
Thanks Junio for a review of v11! I addressed the memory issue with the interdiff (in patch 1/7) as follows: Interdiff to v11: diff --git a/submodule.c b/submodule.c index 263cb2a..45d0967 100644 --- a/submodule.c +++ b/submodule.c @@ -219,6 +219,9 @@ void gitmodules_config(void) int parse_submo