Re: [PATCH v6 2/9] connect: only match the host with core.gitProxy

2016-05-20 Thread Junio C Hamano
Mike Hommey writes: > On Fri, May 20, 2016 at 02:48:28PM -0700, Junio C Hamano wrote: >> So, even if we agree that per-port behaviour is not something we >> would use if we were building the system without any existing users >> today, I do not think we want "git now fails with an error" at all. >

Re: [PATCH v6 2/9] connect: only match the host with core.gitProxy

2016-05-20 Thread Mike Hommey
On Fri, May 20, 2016 at 02:48:28PM -0700, Junio C Hamano wrote: > So, even if we agree that per-port behaviour is not something we > would use if we were building the system without any existing users > today, I do not think we want "git now fails with an error" at all. > It goes against the approa

Re: [PATCH v6 2/9] connect: only match the host with core.gitProxy

2016-05-20 Thread Junio C Hamano
Mike Hommey writes: > Currently, core.gitProxy doesn't actually match purely on domain names > as documented: it also matches ports. > > So a core.gitProxy value like "script for kernel.org" doesn't make the > script called for an url like git://kernel.org:port/path, while it is > called for git:

[PATCH v6 2/9] connect: only match the host with core.gitProxy

2016-05-16 Thread Mike Hommey
Currently, core.gitProxy doesn't actually match purely on domain names as documented: it also matches ports. So a core.gitProxy value like "script for kernel.org" doesn't make the script called for an url like git://kernel.org:port/path, while it is called for git://kernel.org/path. This per-port