Re: [PATCH v6] l10n: localizable upload progress messages

2019-07-02 Thread Junio C Hamano
Dimitriy Ryazantcev writes: > -void strbuf_humanise_bytes(struct strbuf *buf, off_t bytes) > +static void strbuf_humanise(struct strbuf *buf, off_t bytes, > + int humanise_rate) > { > if (bytes > 1 << 30) { > - strbuf_addf(buf, "%u.%2.2u GiB", > +

[PATCH v6] l10n: localizable upload progress messages

2019-07-02 Thread Dimitriy Ryazantcev
Currenly the data rate in throughput_string(...) method is output by simple strbuf_humanise_bytes(...) call and '/s' append. But for proper translation of such string the translator needs full context. Add strbuf_humanise_rate(...) method to properly print out localizable version of data rate ('3.