Re: [PATCH v5 4/6] builtin/verify-tag: replace name argument with sha1

2016-04-06 Thread Santiago Torres
> > type = sha1_object_info(sha1, NULL); > > if (type != OBJ_TAG) > > return error("%s: cannot verify a non-tag object of type %s.", > > - name, typename(type)); > > + hex_sha1, typename(type)); > > So, if I said > > $ gi

Re: [PATCH v5 4/6] builtin/verify-tag: replace name argument with sha1

2016-04-06 Thread Junio C Hamano
santi...@nyu.edu writes: > From: Santiago Torres > > This change is meant to prepare verify_tag for libification. Many > existing modules/commands already do the refname to sha1 resolution, so > should avoid resolving the refname twice. To avoid breaking > builtin/verify-tag, we move the refname

Re: [PATCH v5 4/6] builtin/verify-tag: replace name argument with sha1

2016-04-05 Thread Eric Sunshine
On Tue, Apr 5, 2016 at 12:07 PM, wrote: > builtin/verify-tag: replace name argument with sha1 builtin/verify-tag: prepare verify_tag() for libification > This change is meant to prepare verify_tag for libification. Many > existing modules/commands already do the refname to sha1 resolution,

[PATCH v5 4/6] builtin/verify-tag: replace name argument with sha1

2016-04-05 Thread santiago
From: Santiago Torres This change is meant to prepare verify_tag for libification. Many existing modules/commands already do the refname to sha1 resolution, so should avoid resolving the refname twice. To avoid breaking builtin/verify-tag, we move the refname resolution outside of the verify_tag(