Re: [PATCH v5 2/3] config: add 'type' to config_source struct that identifies config type

2016-02-18 Thread Lars Schneider
On 17 Feb 2016, at 22:31, Junio C Hamano wrote: > Junio C Hamano writes: > >> larsxschnei...@gmail.com writes: >> >>> From: Lars Schneider >>> >>> Use the config type to print more detailed error messages that inform >>> the user about the origin of a config error (file, stdin, blob). >> >

Re: [PATCH v5 2/3] config: add 'type' to config_source struct that identifies config type

2016-02-17 Thread Junio C Hamano
Junio C Hamano writes: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider >> >> Use the config type to print more detailed error messages that inform >> the user about the origin of a config error (file, stdin, blob). > > "type" is too broad a word in the context of configuration file,

Re: [PATCH v5 2/3] config: add 'type' to config_source struct that identifies config type

2016-02-17 Thread Junio C Hamano
larsxschnei...@gmail.com writes: > From: Lars Schneider > > Use the config type to print more detailed error messages that inform > the user about the origin of a config error (file, stdin, blob). "type" is too broad a word in the context of configuration file, and does not help readers as a var

[PATCH v5 2/3] config: add 'type' to config_source struct that identifies config type

2016-02-17 Thread larsxschneider
From: Lars Schneider Use the config type to print more detailed error messages that inform the user about the origin of a config error (file, stdin, blob). Helped-by: Ramsay Jones Signed-off-by: Lars Schneider Acked-by: Jeff King --- cache.h| 6 -- config.c