larsxschnei...@gmail.com writes: > From: Lars Schneider <larsxschnei...@gmail.com> > > Use the config type to print more detailed error messages that inform > the user about the origin of a config error (file, stdin, blob).
"type" is too broad a word in the context of configuration file, and does not help readers as a variable or a field name in a structure. You are not talking about "this is a binary typed variable", for example. If showing the origin is useful to the user, that origin should be called origin, not type, I would think. > diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh > index 91235b7..82f82a1 100755 > --- a/t/t1308-config-set.sh > +++ b/t/t1308-config-set.sh > @@ -195,14 +195,14 @@ test_expect_success 'proper error on error in default > config files' ' > cp .git/config .git/config.old && > test_when_finished "mv .git/config.old .git/config" && > echo "[" >>.git/config && > - echo "fatal: bad config file line 34 in .git/config" >expect && > + echo "fatal: bad config line 34 in file .git/config" >expect && This definitely is a great improvement ;-) > test_expect_code 128 test-config get_value foo.bar 2>actual && > test_cmp expect actual > ' > > test_expect_success 'proper error on error in custom config files' ' > echo "[" >>syntax-error && > - echo "fatal: bad config file line 1 in syntax-error" >expect && > + echo "fatal: bad config line 1 in file syntax-error" >expect && > test_expect_code 128 test-config configset_get_value foo.bar > syntax-error 2>actual && > test_cmp expect actual > ' -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
