Re: [PATCH v5 00/10] Filter combination

2019-06-28 Thread Jonathan Tan
> This applies suggestions made by Jonathan Tan, as well as fixes a > Coccinelle-breaking error in strbuf usage, and makes an additional string > localizable. > > Thanks, > > Matthew DeVore (10): > list-objects-filter: encapsulate filter components > list-objects-filter: put omits set in filt

Re: [PATCH v5 00/10] Filter combination

2019-06-28 Thread Junio C Hamano
Matthew DeVore writes: > This applies suggestions made by Jonathan Tan, as well as fixes a > Coccinelle-breaking error in strbuf usage, and makes an additional string > localizable. OK, so the convention is that errbuf has already translated string, so the call to die() made in a fairly high poi

[PATCH v5 00/10] Filter combination

2019-06-27 Thread Matthew DeVore
This applies suggestions made by Jonathan Tan, as well as fixes a Coccinelle-breaking error in strbuf usage, and makes an additional string localizable. Thanks, Matthew DeVore (10): list-objects-filter: encapsulate filter components list-objects-filter: put omits set in filter struct list-o