Matthew DeVore <matv...@google.com> writes: > This applies suggestions made by Jonathan Tan, as well as fixes a > Coccinelle-breaking error in strbuf usage, and makes an additional string > localizable.
OK, so the convention is that errbuf has already translated string, so the call to die() made in a fairly high point in the callchain do not use _(). I looked at the new _() in deeper level of the callchain this round adds relative to the previous one, and they all looked sensible. The helper function should_delegate is now gone---it had only one callsite in the previous round, so I suspect the resulting code would be the same either way with moderately decent compilers. Will queue; thanks.
