Re: [PATCH v4 2/2] gitk: synchronize config write

2015-03-02 Thread Max Kirillov
On Mon, Mar 02, 2015 at 11:10:51AM +1100, Paul Mackerras wrote: > The idea looks good; I have a couple of comments on the patch. First, > 50 tries over 5 seconds seems a bit excessive to me, wouldn't (say) 20 > tries be enough? Is the 50 the result of some analysis? 5 seconds was just my persona

Re: [PATCH v4 2/2] gitk: synchronize config write

2015-03-01 Thread Paul Mackerras
On Mon, Nov 10, 2014 at 12:20:02AM +0200, Max Kirillov wrote: > If several gitk instances are closed simultaneously, safestuff procedure > can run at the same time, resulting in a conflict which may cause losing > of some of the instance's changes, failing the saving operation or even > corrupting

[PATCH v4 2/2] gitk: synchronize config write

2014-11-09 Thread Max Kirillov
If several gitk instances are closed simultaneously, safestuff procedure can run at the same time, resulting in a conflict which may cause losing of some of the instance's changes, failing the saving operation or even corrupting the configuration file. This can happen, for example, at user session