Re: [PATCH v3 2/2] submodule--helper.c: remove duplicate code

2017-03-10 Thread Stefan Beller
On Fri, Mar 10, 2017 at 12:40 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> On Fri, Mar 10, 2017 at 11:42 AM, Junio C Hamano wrote: >>> Brandon Williams writes: >>> On 03/09, Valery Tolstov wrote: > Remove code fragment from module_clone that duplicates functionality > of

Re: [PATCH v3 2/2] submodule--helper.c: remove duplicate code

2017-03-10 Thread Junio C Hamano
Stefan Beller writes: > On Fri, Mar 10, 2017 at 11:42 AM, Junio C Hamano wrote: >> Brandon Williams writes: >> >>> On 03/09, Valery Tolstov wrote: Remove code fragment from module_clone that duplicates functionality of connect_work_tree_and_git_dir in dir.c Signed-off-by: Va

Re: [PATCH v3 2/2] submodule--helper.c: remove duplicate code

2017-03-10 Thread Stefan Beller
On Fri, Mar 10, 2017 at 11:42 AM, Junio C Hamano wrote: > Brandon Williams writes: > >> On 03/09, Valery Tolstov wrote: >>> Remove code fragment from module_clone that duplicates functionality >>> of connect_work_tree_and_git_dir in dir.c >>> >>> Signed-off-by: Valery Tolstov >> >> Looks good. >

Re: [PATCH v3 2/2] submodule--helper.c: remove duplicate code

2017-03-10 Thread Junio C Hamano
Brandon Williams writes: > On 03/09, Valery Tolstov wrote: >> Remove code fragment from module_clone that duplicates functionality >> of connect_work_tree_and_git_dir in dir.c >> >> Signed-off-by: Valery Tolstov > > Looks good. I'll queue with your Reviewed-by: added. If sb/checkout-recurse-s

Re: [PATCH v3 2/2] submodule--helper.c: remove duplicate code

2017-03-09 Thread Valery Tolstov
As remainder. It is better if only [PATCH v3 2/2] is taken, on top the patch from here https://public-inbox.org/git/20170309221543.15897-8-sbel...@google.com/ The [PATCH v3 1/2] is just a copy of latter.

Re: [PATCH v3 2/2] submodule--helper.c: remove duplicate code

2017-03-09 Thread Brandon Williams
On 03/09, Valery Tolstov wrote: > Remove code fragment from module_clone that duplicates functionality > of connect_work_tree_and_git_dir in dir.c > > Signed-off-by: Valery Tolstov Looks good. -- Brandon Williams

[PATCH v3 2/2] submodule--helper.c: remove duplicate code

2017-03-08 Thread Valery Tolstov
Remove code fragment from module_clone that duplicates functionality of connect_work_tree_and_git_dir in dir.c Signed-off-by: Valery Tolstov --- builtin/submodule--helper.c | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/builtin/submodule--helper.c b/b