Re: [PATCH v3] rev-list: exclude promisor objects at walk time

2019-04-19 Thread Josh Steadmon
On 2019.04.13 01:34, Jeff King wrote: > On Fri, Apr 12, 2019 at 03:38:47PM -0700, Josh Steadmon wrote: > > > > > Thank you for catching this. I haven't yet figured out the cause. I will > > > > look into this more tomorrow and then send a V4 once I've fixed it. > > > > > > I'm concerned that this

Re: [PATCH v3] rev-list: exclude promisor objects at walk time

2019-04-12 Thread Jeff King
On Fri, Apr 12, 2019 at 03:38:47PM -0700, Josh Steadmon wrote: > > > Thank you for catching this. I haven't yet figured out the cause. I will > > > look into this more tomorrow and then send a V4 once I've fixed it. > > > > I'm concerned that this is a sign that the approach I suggested does not

Re: [PATCH v3] rev-list: exclude promisor objects at walk time

2019-04-12 Thread Josh Steadmon
On 2019.04.11 00:06, Jeff King wrote: > On Tue, Apr 09, 2019 at 04:42:55PM -0700, Josh Steadmon wrote: > > > > warning: reflog of 'HEAD' references pruned commits > > > warning: reflog of 'refs/heads/master' references pruned commits > > > fatal: unable to read 71905dfcd543b7cbb0b4b66fbd2037

Re: [PATCH v3] rev-list: exclude promisor objects at walk time

2019-04-10 Thread Jeff King
On Tue, Apr 09, 2019 at 04:42:55PM -0700, Josh Steadmon wrote: > > warning: reflog of 'HEAD' references pruned commits > > warning: reflog of 'refs/heads/master' references pruned commits > > fatal: unable to read 71905dfcd543b7cbb0b4b66fbd20379e67220557 > > error: last command exited with

Re: [PATCH v3] rev-list: exclude promisor objects at walk time

2019-04-09 Thread Josh Steadmon
On 2019.04.09 20:04, SZEDER Gábor wrote: > On Mon, Apr 08, 2019 at 02:06:04PM -0700, Josh Steadmon wrote: > > For large repositories, enumerating the list of all promisor objects (in > > order to exclude them from a rev-list walk) can take a significant > > amount of time). > > > > When --exclude-

Re: [PATCH v3] rev-list: exclude promisor objects at walk time

2019-04-09 Thread SZEDER Gábor
On Mon, Apr 08, 2019 at 02:06:04PM -0700, Josh Steadmon wrote: > For large repositories, enumerating the list of all promisor objects (in > order to exclude them from a rev-list walk) can take a significant > amount of time). > > When --exclude-promisor-objects is passed to rev-list, don't enumera

Re: [PATCH v3] rev-list: exclude promisor objects at walk time

2019-04-09 Thread Josh Steadmon
On 2019.04.10 00:43, Junio C Hamano wrote: > Jeff King writes: > > > On Wed, Apr 10, 2019 at 12:14:41AM +0900, Junio C Hamano wrote: > > > >> I've dealt with the stray double-sign-off locally, but is there > >> anything else planned for v4 or later? Is this performance-only > >> change, or does

Re: [PATCH v3] rev-list: exclude promisor objects at walk time

2019-04-09 Thread Junio C Hamano
Jeff King writes: > On Wed, Apr 10, 2019 at 12:14:41AM +0900, Junio C Hamano wrote: > >> I've dealt with the stray double-sign-off locally, but is there >> anything else planned for v4 or later? Is this performance-only >> change, or does it have an externally observable behaviour change >> that

Re: [PATCH v3] rev-list: exclude promisor objects at walk time

2019-04-09 Thread Jeff King
On Wed, Apr 10, 2019 at 12:14:41AM +0900, Junio C Hamano wrote: > Josh Steadmon writes: > > > For large repositories, enumerating the list of all promisor objects (in > > order to exclude them from a rev-list walk) can take a significant > > amount of time). > > > > When --exclude-promisor-objec

Re: [PATCH v3] rev-list: exclude promisor objects at walk time

2019-04-09 Thread Junio C Hamano
Josh Steadmon writes: > For large repositories, enumerating the list of all promisor objects (in > order to exclude them from a rev-list walk) can take a significant > amount of time). > > When --exclude-promisor-objects is passed to rev-list, don't enumerate > the promisor objects. Instead, filt

Re: [PATCH v3] rev-list: exclude promisor objects at walk time

2019-04-08 Thread Josh Steadmon
On 2019.04.09 00:23, Christian Couder wrote: > On Mon, Apr 8, 2019 at 11:46 PM Josh Steadmon wrote: > > > > Helped-By: Jonathan Tan > > Helped-By: Jeff King > > Helped-By: Jonathan Nieder > > Signed-off-by: Josh Steadmon > > > > Signed-off-by: Josh Steadmon > > Your S-o-B is duplicated an th

Re: [PATCH v3] rev-list: exclude promisor objects at walk time

2019-04-08 Thread Christian Couder
On Mon, Apr 8, 2019 at 11:46 PM Josh Steadmon wrote: > > Helped-By: Jonathan Tan > Helped-By: Jeff King > Helped-By: Jonathan Nieder > Signed-off-by: Josh Steadmon > > Signed-off-by: Josh Steadmon Your S-o-B is duplicated an there is a spurious line between the duplicated lines. Do you use a

[PATCH v3] rev-list: exclude promisor objects at walk time

2019-04-08 Thread Josh Steadmon
For large repositories, enumerating the list of all promisor objects (in order to exclude them from a rev-list walk) can take a significant amount of time). When --exclude-promisor-objects is passed to rev-list, don't enumerate the promisor objects. Instead, filter them (and any children objects)